From: ezequiel.garcia@free-electrons.com (Ezequiel Garcia)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 0/2] Translate of PCI address without PCI enabled
Date: Wed, 19 Feb 2014 21:50:28 -0300 [thread overview]
Message-ID: <20140220005027.GA5721@localhost> (raw)
In-Reply-To: <1392848096-17838-1-git-send-email-gregory.clement@free-electrons.com>
On Wed, Feb 19, 2014 at 11:14:54PM +0100, Gregory CLEMENT wrote:
> Hello,
>
> This patch set makes the use of the of PCI address translator less
> restrictive. At the end it will allow to use the mvebu_get_soc_id
> unconditionally.
>
> The mvebu SoC (such as Kirkwood, Dove or Armada XP for instance) come
> with an IP of a PCI controller. The ID and the revision of a SoC are
> stored in the registers of this controller. Being able to get this
> information allows to deals with errata more dynamically.
>
> To manage to read this information, we need to map the registers, and
> for this we need to use the of PCI translator which depend of the PCI
> support.
>
> However there are mvebu board without any PCI devices, and where
> selecting the PCI support would be useless.
>
> Moreover translating an address from a PCI node of the device-tree
> into a CPU physical address doesn't require the core PCI
> support. Those translations are just related to the device tree
> itself.
>
> The 1st patch introduces a new config symbol: OF_ADDRESS_PCI, which
> will be selected as soon as PCI will be selected, so we remains in the
> same situation the current code. It should go to the of tree.
>
> The 2nd patch selects OF_ADDRESS_PCI as soon as ARCH_MVEBU will be
> selected. This will make mvebu_get_soc_id available even without the
> PCI support. It should go to the mvebu tree.
>
> Thanks,
>
> Gregory CLEMENT (2):
> of: Allows to use the PCI translator without the PCI core
> ARM: mvebu: Allows to get the SoC ID even without PCI enabled
>
> arch/arm/mach-mvebu/Kconfig | 1 +
> drivers/of/Kconfig | 4 ++++
> drivers/of/address.c | 8 +++++---
> 3 files changed, 10 insertions(+), 3 deletions(-)
>
> --
> 1.8.1.2
>
On XP GP and CONFIG_PCI=n, without the patches I get this:
mvebu-soc-id: cannot map registers
and after applying the patches I have:
mvebu-soc-id: MVEBU SoC ID=0x7846, Rev=0x2
Tested-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Reviewed-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Thanks for taking care of this.
--
Ezequiel Garc?a, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
WARNING: multiple messages have this Message-ID (diff)
From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Gregory CLEMENT <gregory.clement@free-electrons.com>
Cc: Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
Jason Cooper <jason@lakedaemon.net>, Andrew Lunn <andrew@lunn.ch>,
Sebastian Hesselbarth <sebastian.hesselbarth@gmail.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
linux-arm-kernel@lists.infradead.org,
Lior Amsalem <alior@marvell.com>,
Tawfik Bayouk <tawfik@marvell.com>,
Nadav Haklai <nadavh@marvell.com>
Subject: Re: [PATCH 0/2] Translate of PCI address without PCI enabled
Date: Wed, 19 Feb 2014 21:50:28 -0300 [thread overview]
Message-ID: <20140220005027.GA5721@localhost> (raw)
In-Reply-To: <1392848096-17838-1-git-send-email-gregory.clement@free-electrons.com>
On Wed, Feb 19, 2014 at 11:14:54PM +0100, Gregory CLEMENT wrote:
> Hello,
>
> This patch set makes the use of the of PCI address translator less
> restrictive. At the end it will allow to use the mvebu_get_soc_id
> unconditionally.
>
> The mvebu SoC (such as Kirkwood, Dove or Armada XP for instance) come
> with an IP of a PCI controller. The ID and the revision of a SoC are
> stored in the registers of this controller. Being able to get this
> information allows to deals with errata more dynamically.
>
> To manage to read this information, we need to map the registers, and
> for this we need to use the of PCI translator which depend of the PCI
> support.
>
> However there are mvebu board without any PCI devices, and where
> selecting the PCI support would be useless.
>
> Moreover translating an address from a PCI node of the device-tree
> into a CPU physical address doesn't require the core PCI
> support. Those translations are just related to the device tree
> itself.
>
> The 1st patch introduces a new config symbol: OF_ADDRESS_PCI, which
> will be selected as soon as PCI will be selected, so we remains in the
> same situation the current code. It should go to the of tree.
>
> The 2nd patch selects OF_ADDRESS_PCI as soon as ARCH_MVEBU will be
> selected. This will make mvebu_get_soc_id available even without the
> PCI support. It should go to the mvebu tree.
>
> Thanks,
>
> Gregory CLEMENT (2):
> of: Allows to use the PCI translator without the PCI core
> ARM: mvebu: Allows to get the SoC ID even without PCI enabled
>
> arch/arm/mach-mvebu/Kconfig | 1 +
> drivers/of/Kconfig | 4 ++++
> drivers/of/address.c | 8 +++++---
> 3 files changed, 10 insertions(+), 3 deletions(-)
>
> --
> 1.8.1.2
>
On XP GP and CONFIG_PCI=n, without the patches I get this:
mvebu-soc-id: cannot map registers
and after applying the patches I have:
mvebu-soc-id: MVEBU SoC ID=0x7846, Rev=0x2
Tested-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Reviewed-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
Thanks for taking care of this.
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-02-20 0:50 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-19 22:14 [PATCH 0/2] Translate of PCI address without PCI enabled Gregory CLEMENT
2014-02-19 22:14 ` Gregory CLEMENT
2014-02-19 22:14 ` [PATCH 1/2] of: Allows to use the PCI translator without the PCI core Gregory CLEMENT
2014-02-19 22:14 ` Gregory CLEMENT
2014-02-19 22:14 ` Gregory CLEMENT
2014-02-19 22:14 ` [PATCH 2/2] ARM: mvebu: Allows to get the SoC ID even without PCI enabled Gregory CLEMENT
2014-02-19 22:14 ` Gregory CLEMENT
2014-02-19 22:14 ` Gregory CLEMENT
2014-02-20 0:50 ` Ezequiel Garcia [this message]
2014-02-20 0:50 ` [PATCH 0/2] Translate of PCI address " Ezequiel Garcia
2014-02-20 15:35 ` Grant Likely
2014-02-20 15:35 ` Grant Likely
2014-02-20 15:35 ` Grant Likely
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140220005027.GA5721@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.