From: Dan Carpenter <dan.carpenter@oracle.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Gleb Natapov <gleb@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, kvm@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch RFC] kvm, cpuid: silence a buffer overflow warning
Date: Thu, 20 Feb 2014 13:23:16 +0000 [thread overview]
Message-ID: <20140220132316.GA26776@mwanda> (raw)
In-Reply-To: <5305FE1E.6060902@redhat.com>
On Thu, Feb 20, 2014 at 02:07:42PM +0100, Paolo Bonzini wrote:
> Il 20/02/2014 13:34, Dan Carpenter ha scritto:
> > This seems like a harmless off by one overflow if "i" is the last
> > element in the vcpu->arch.cpuid_entries[] array.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > Not tested. I always wonder if it's worth fixing these or if it's worth
> > reporting them? Either of those seem like a lot of work for something
> > harmless.
>
> Could it oops if cpuid_nent is INT_MAX?
cpuid_nent is capped at KVM_MAX_CPUID_ENTRIES (80).
regards,
dan carpenter
WARNING: multiple messages have this Message-ID (diff)
From: Dan Carpenter <dan.carpenter@oracle.com>
To: Paolo Bonzini <pbonzini@redhat.com>
Cc: Gleb Natapov <gleb@kernel.org>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
x86@kernel.org, kvm@vger.kernel.org,
kernel-janitors@vger.kernel.org
Subject: Re: [patch RFC] kvm, cpuid: silence a buffer overflow warning
Date: Thu, 20 Feb 2014 16:23:16 +0300 [thread overview]
Message-ID: <20140220132316.GA26776@mwanda> (raw)
In-Reply-To: <5305FE1E.6060902@redhat.com>
On Thu, Feb 20, 2014 at 02:07:42PM +0100, Paolo Bonzini wrote:
> Il 20/02/2014 13:34, Dan Carpenter ha scritto:
> > This seems like a harmless off by one overflow if "i" is the last
> > element in the vcpu->arch.cpuid_entries[] array.
> >
> > Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
> > ---
> > Not tested. I always wonder if it's worth fixing these or if it's worth
> > reporting them? Either of those seem like a lot of work for something
> > harmless.
>
> Could it oops if cpuid_nent is INT_MAX?
cpuid_nent is capped at KVM_MAX_CPUID_ENTRIES (80).
regards,
dan carpenter
next prev parent reply other threads:[~2014-02-20 13:23 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-20 12:34 [patch RFC] kvm, cpuid: silence a buffer overflow warning Dan Carpenter
2014-02-20 12:34 ` Dan Carpenter
2014-02-20 13:07 ` Paolo Bonzini
2014-02-20 13:07 ` Paolo Bonzini
2014-02-20 13:18 ` walter harms
2014-02-20 13:18 ` walter harms
2014-02-20 13:19 ` Paolo Bonzini
2014-02-20 13:19 ` Paolo Bonzini
2014-02-20 13:23 ` Dan Carpenter [this message]
2014-02-20 13:23 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140220132316.GA26776@mwanda \
--to=dan.carpenter@oracle.com \
--cc=gleb@kernel.org \
--cc=hpa@zytor.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=pbonzini@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.