From: Jens Axboe <axboe@kernel.dk>
To: Philipp Reisner <philipp.reisner@linbit.com>
Cc: linux-kernel@vger.kernel.org, drbd-dev@lists.linbit.com
Subject: Re: [Drbd-dev] [PATCH] drbd: Fix future possible NULL pointer dereference
Date: Fri, 21 Feb 2014 15:42:53 -0800 [thread overview]
Message-ID: <20140221234253.GD29129@kernel.dk> (raw)
In-Reply-To: <1392803347-6075-2-git-send-email-philipp.reisner@linbit.com>
On Wed, Feb 19 2014, Philipp Reisner wrote:
> From: Andreas Gruenbacher <agruen@linbit.com>
>
> Right now every resource has exactly one connection. But we are preparing
> for dynamic connections. I.e. in the future thre can be resources without
> connections.
>
> However smatch points this out as 'variable dereferenced before check',
> which is correct.
>
> This issue was introduced in
> drbd: get_one_status(): Iterate over resource->devices instead of connection->peer_devices
Applied, thanks.
--
Jens Axboe
WARNING: multiple messages have this Message-ID (diff)
From: Jens Axboe <axboe@kernel.dk>
To: Philipp Reisner <philipp.reisner@linbit.com>
Cc: drbd-dev@lists.linbit.com, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] drbd: Fix future possible NULL pointer dereference
Date: Fri, 21 Feb 2014 15:42:53 -0800 [thread overview]
Message-ID: <20140221234253.GD29129@kernel.dk> (raw)
In-Reply-To: <1392803347-6075-2-git-send-email-philipp.reisner@linbit.com>
On Wed, Feb 19 2014, Philipp Reisner wrote:
> From: Andreas Gruenbacher <agruen@linbit.com>
>
> Right now every resource has exactly one connection. But we are preparing
> for dynamic connections. I.e. in the future thre can be resources without
> connections.
>
> However smatch points this out as 'variable dereferenced before check',
> which is correct.
>
> This issue was introduced in
> drbd: get_one_status(): Iterate over resource->devices instead of connection->peer_devices
Applied, thanks.
--
Jens Axboe
next prev parent reply other threads:[~2014-02-22 0:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-17 16:23 [Drbd-dev] [GIT pull] DRBD code reorganization Philipp Reisner
2014-02-17 16:23 ` Philipp Reisner
2014-02-18 20:20 ` [Drbd-dev] " Jens Axboe
2014-02-18 20:20 ` Jens Axboe
2014-02-19 9:49 ` [Drbd-dev] [PATCH] Fix smatch warning Philipp Reisner
2014-02-19 9:49 ` Philipp Reisner
2014-02-19 9:49 ` [Drbd-dev] [PATCH] drbd: Fix future possible NULL pointer dereference Philipp Reisner
2014-02-19 9:49 ` Philipp Reisner
2014-02-21 23:42 ` Jens Axboe [this message]
2014-02-21 23:42 ` Jens Axboe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140221234253.GD29129@kernel.dk \
--to=axboe@kernel.dk \
--cc=drbd-dev@lists.linbit.com \
--cc=linux-kernel@vger.kernel.org \
--cc=philipp.reisner@linbit.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.