From: Dave Chinner <david@fromorbit.com>
To: Theodore Ts'o <tytso@mit.edu>, Namjae Jeon <linkinjeon@gmail.com>,
viro@zeniv.linux.org.uk, bpm@sgi.com, adilger.kernel@dilger.ca,
jack@suse.cz, mtk.manpages@gmail.com, lczerner@redhat.com,
linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
Namjae Jeon <namjae.jeon@samsung.com>,
Ashish Sangwan <a.sangwan@samsung.com>
Subject: Re: [PATCH v5 1/10] fs: Add new flag(FALLOC_FL_COLLAPSE_RANGE) for fallocate
Date: Mon, 24 Feb 2014 08:36:06 +1100 [thread overview]
Message-ID: <20140223213606.GE4317@dastard> (raw)
In-Reply-To: <20140222140625.GD26637@thunk.org>
On Sat, Feb 22, 2014 at 09:06:25AM -0500, Theodore Ts'o wrote:
> On Wed, Feb 19, 2014 at 01:37:43AM +0900, Namjae Jeon wrote:
> > + /*
> > + * There is no need to overlap collapse range with EOF, in which case
> > + * it is effectively a truncate operation
> > + */
> > + if ((mode & FALLOC_FL_COLLAPSE_RANGE) &&
> > + (offset + len >= i_size_read(inode)))
> > + return -EINVAL;
> > +
>
> I wonder if we should just translate a collapse range that is
> equivalent to a truncate operation to, in fact, be a truncate
> operation?
Trying to collapse a range that extends beyond EOF, IMO, is likely
to only happen if the DVR/NLE application is buggy. Hence I think
that telling the application it is doing something that is likely to
be wrong is better than silently truncating the file....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: "Theodore Ts'o" <tytso@mit.edu>,
Namjae Jeon <linkinjeon@gmail.com>,
viro@zeniv.linux.org.uk, bpm@sgi.com, adilger.kernel@dilger.ca,
jack@suse.cz, mtk.manpages@gmail.com, lczerner@redhat.com,
linux-fsdevel@vger.kernel.org, xfs@oss.sgi.com,
linux-ext4@vger.kernel.org, linux-kernel@vger.kernel.org,
Namjae Jeon <namjae.jeon@samsung.com>,
Ashish Sangwan <a.sangwan@samsung.com>
Subject: Re: [PATCH v5 1/10] fs: Add new flag(FALLOC_FL_COLLAPSE_RANGE) for fallocate
Date: Mon, 24 Feb 2014 08:36:06 +1100 [thread overview]
Message-ID: <20140223213606.GE4317@dastard> (raw)
In-Reply-To: <20140222140625.GD26637@thunk.org>
On Sat, Feb 22, 2014 at 09:06:25AM -0500, Theodore Ts'o wrote:
> On Wed, Feb 19, 2014 at 01:37:43AM +0900, Namjae Jeon wrote:
> > + /*
> > + * There is no need to overlap collapse range with EOF, in which case
> > + * it is effectively a truncate operation
> > + */
> > + if ((mode & FALLOC_FL_COLLAPSE_RANGE) &&
> > + (offset + len >= i_size_read(inode)))
> > + return -EINVAL;
> > +
>
> I wonder if we should just translate a collapse range that is
> equivalent to a truncate operation to, in fact, be a truncate
> operation?
Trying to collapse a range that extends beyond EOF, IMO, is likely
to only happen if the DVR/NLE application is buggy. Hence I think
that telling the application it is doing something that is likely to
be wrong is better than silently truncating the file....
Cheers,
Dave.
--
Dave Chinner
david@fromorbit.com
next prev parent reply other threads:[~2014-02-23 21:36 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-18 16:37 [PATCH v5 1/10] fs: Add new flag(FALLOC_FL_COLLAPSE_RANGE) for fallocate Namjae Jeon
2014-02-18 16:37 ` Namjae Jeon
2014-02-22 14:06 ` Theodore Ts'o
2014-02-22 14:06 ` Theodore Ts'o
2014-02-23 21:36 ` Dave Chinner [this message]
2014-02-23 21:36 ` Dave Chinner
2014-02-25 23:41 ` Hugh Dickins
2014-02-25 23:41 ` Hugh Dickins
2014-02-25 23:41 ` Hugh Dickins
2014-02-26 1:57 ` Dave Chinner
2014-02-26 1:57 ` Dave Chinner
2014-02-26 1:57 ` Dave Chinner
2014-02-26 5:25 ` Hugh Dickins
2014-02-26 5:25 ` Hugh Dickins
2014-02-26 5:25 ` Hugh Dickins
2014-02-26 10:04 ` Dave Chinner
2014-02-26 10:04 ` Dave Chinner
2014-02-26 10:04 ` Dave Chinner
2014-02-26 23:48 ` Hugh Dickins
2014-02-26 23:48 ` Hugh Dickins
2014-02-26 23:48 ` Hugh Dickins
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140223213606.GE4317@dastard \
--to=david@fromorbit.com \
--cc=a.sangwan@samsung.com \
--cc=adilger.kernel@dilger.ca \
--cc=bpm@sgi.com \
--cc=jack@suse.cz \
--cc=lczerner@redhat.com \
--cc=linkinjeon@gmail.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mtk.manpages@gmail.com \
--cc=namjae.jeon@samsung.com \
--cc=tytso@mit.edu \
--cc=viro@zeniv.linux.org.uk \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.