All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dave Chinner <david@fromorbit.com>
To: Filipe David Borba Manana <fdmanana@gmail.com>
Cc: xfs@oss.sgi.com, linux-btrfs@vger.kernel.org
Subject: Re: [PATCH] xfstests: add test btrfs/042 for btrfs incremental send
Date: Mon, 24 Feb 2014 16:28:02 +1100	[thread overview]
Message-ID: <20140224052801.GK4317@dastard> (raw)
In-Reply-To: <1392940976-1790-1-git-send-email-fdmanana@gmail.com>

On Fri, Feb 21, 2014 at 12:02:56AM +0000, Filipe David Borba Manana wrote:
> Regression test for a btrfs incremental send issue where invalid paths for
> utimes, chown and chmod operations were sent to the send stream, causing
> btrfs receive to fail.
> 
> If a directory had a move/rename operation delayed, and none of its parent
> directories, except for the immediate one, had delayed move/rename operations,
> after processing the directory's references, the incremental send code would
> issue invalid paths for utimes, chown and chmod operations.
> 
> This issue is fixed by the following linux kernel btrfs patch:
> 
>    Btrfs: fix send issuing outdated paths for utimes, chown and chmod
> 
> Signed-off-by: Filipe David Borba Manana <fdmanana@gmail.com>
....
> +FSSUM_PROG=$here/src/fssum
> +[ -x $FSSUM_PROG ] || _notrun "fssum not built"

Helper...

.....
> +_scratch_unmount
> +_check_btrfs_filesystem $SCRATCH_DEV

And _check_scratch_fs....

> +_scratch_mkfs >/dev/null 2>&1
> +_scratch_mount
> +
> +_run_btrfs_util_prog receive $SCRATCH_MNT -f $tmp/1.snap
> +run_check $FSSUM_PROG -r $tmp/1.fssum $SCRATCH_MNT/mysnap1 2>> $seqres.full
> +
> +_run_btrfs_util_prog receive $SCRATCH_MNT -f $tmp/2.snap
> +run_check $FSSUM_PROG -r $tmp/2.fssum $SCRATCH_MNT/mysnap2 2>> $seqres.full

And the redirection....

I'm happy to see you write your tests consistently, Filipe :)

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

WARNING: multiple messages have this Message-ID (diff)
From: Dave Chinner <david@fromorbit.com>
To: Filipe David Borba Manana <fdmanana@gmail.com>
Cc: linux-btrfs@vger.kernel.org, xfs@oss.sgi.com
Subject: Re: [PATCH] xfstests: add test btrfs/042 for btrfs incremental send
Date: Mon, 24 Feb 2014 16:28:02 +1100	[thread overview]
Message-ID: <20140224052801.GK4317@dastard> (raw)
In-Reply-To: <1392940976-1790-1-git-send-email-fdmanana@gmail.com>

On Fri, Feb 21, 2014 at 12:02:56AM +0000, Filipe David Borba Manana wrote:
> Regression test for a btrfs incremental send issue where invalid paths for
> utimes, chown and chmod operations were sent to the send stream, causing
> btrfs receive to fail.
> 
> If a directory had a move/rename operation delayed, and none of its parent
> directories, except for the immediate one, had delayed move/rename operations,
> after processing the directory's references, the incremental send code would
> issue invalid paths for utimes, chown and chmod operations.
> 
> This issue is fixed by the following linux kernel btrfs patch:
> 
>    Btrfs: fix send issuing outdated paths for utimes, chown and chmod
> 
> Signed-off-by: Filipe David Borba Manana <fdmanana@gmail.com>
....
> +FSSUM_PROG=$here/src/fssum
> +[ -x $FSSUM_PROG ] || _notrun "fssum not built"

Helper...

.....
> +_scratch_unmount
> +_check_btrfs_filesystem $SCRATCH_DEV

And _check_scratch_fs....

> +_scratch_mkfs >/dev/null 2>&1
> +_scratch_mount
> +
> +_run_btrfs_util_prog receive $SCRATCH_MNT -f $tmp/1.snap
> +run_check $FSSUM_PROG -r $tmp/1.fssum $SCRATCH_MNT/mysnap1 2>> $seqres.full
> +
> +_run_btrfs_util_prog receive $SCRATCH_MNT -f $tmp/2.snap
> +run_check $FSSUM_PROG -r $tmp/2.fssum $SCRATCH_MNT/mysnap2 2>> $seqres.full

And the redirection....

I'm happy to see you write your tests consistently, Filipe :)

Cheers,

Dave.
-- 
Dave Chinner
david@fromorbit.com

_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs

  reply	other threads:[~2014-02-24  5:28 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-21  0:02 [PATCH] xfstests: add test btrfs/042 for btrfs incremental send Filipe David Borba Manana
2014-02-21  0:02 ` Filipe David Borba Manana
2014-02-24  5:28 ` Dave Chinner [this message]
2014-02-24  5:28   ` Dave Chinner
2014-02-24 11:55 ` [PATCH v2] " Filipe David Borba Manana
2014-02-24 11:55   ` Filipe David Borba Manana
2014-03-10 19:56   ` Josef Bacik
2014-03-10 19:56     ` Josef Bacik

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140224052801.GK4317@dastard \
    --to=david@fromorbit.com \
    --cc=fdmanana@gmail.com \
    --cc=linux-btrfs@vger.kernel.org \
    --cc=xfs@oss.sgi.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.