All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa@the-dreams.de>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 2/4] ARM: shmobile: r8a7791: add IIC(B) clocks to dtsi
Date: Mon, 24 Feb 2014 10:38:32 +0000	[thread overview]
Message-ID: <20140224103832.GC4445@katana> (raw)
In-Reply-To: <1389082976-22254-3-git-send-email-laurent.pinchart+renesas@ideasonboard.com>

[-- Attachment #1: Type: text/plain, Size: 581 bytes --]


> >  			renesas,clock-indices = <
> >  				R8A7791_CLK_TPU0 R8A7791_CLK_SDHI2 R8A7791_CLK_SDHI1
> >  				R8A7791_CLK_SDHI0 R8A7791_CLK_MMCIF0 R8A7791_CLK_CMT1
> > +				R8A7791_CLK_IIC0 R8A7791_CLK_IIC1
> 
> That's an arbitrary rule but we've followed it so far, could you please keep 
> the entries sorted by value as well, here and in patch 3/4 ?

OK, can do. Will create a less easy to parse diff, though. Another
question: What about loosening the 80-char rule and have four values per
line? This suits a 32 bit register much better IMO.

Thanks,

   Wolfram


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  parent reply	other threads:[~2014-02-24 10:38 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-07  8:22 [PATCH 2/4] ARM: shmobile: r8a7791: Add VIN clocks to device tree Laurent Pinchart
2014-02-23 12:40 ` [PATCH 2/4] ARM: shmobile: r8a7791: add IIC(B) clocks to dtsi Wolfram Sang
2014-02-23 22:21 ` Laurent Pinchart
2014-02-23 22:23 ` Laurent Pinchart
2014-02-24 10:38 ` Wolfram Sang [this message]
2014-02-24 11:36 ` Laurent Pinchart
2014-02-24 23:47 ` Simon Horman

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140224103832.GC4445@katana \
    --to=wsa@the-dreams.de \
    --cc=linux-sh@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.