From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: linux-sh@vger.kernel.org
Subject: Re: [PATCH 2/4] ARM: shmobile: r8a7791: add IIC(B) clocks to dtsi
Date: Mon, 24 Feb 2014 11:36:40 +0000 [thread overview]
Message-ID: <3971243.laxNKgqxOE@avalon> (raw)
In-Reply-To: <1389082976-22254-3-git-send-email-laurent.pinchart+renesas@ideasonboard.com>
[-- Attachment #1: Type: text/plain, Size: 796 bytes --]
Hi Wolfram,
On Monday 24 February 2014 11:38:32 Wolfram Sang wrote:
> > > renesas,clock-indices = <
> > >
> > > R8A7791_CLK_TPU0 R8A7791_CLK_SDHI2 R8A7791_CLK_SDHI1
> > > R8A7791_CLK_SDHI0 R8A7791_CLK_MMCIF0 R8A7791_CLK_CMT1
> > >
> > > + R8A7791_CLK_IIC0 R8A7791_CLK_IIC1
> >
> > That's an arbitrary rule but we've followed it so far, could you please
> > keep the entries sorted by value as well, here and in patch 3/4 ?
>
> OK, can do. Will create a less easy to parse diff, though. Another
> question: What about loosening the 80-char rule and have four values per
> line? This suits a 32 bit register much better IMO.
I'd be fine with that. There has never been a strict 80-char rule for .dts
files anyway.
--
Regards,
Laurent Pinchart
[-- Attachment #2: This is a digitally signed message part. --]
[-- Type: application/pgp-signature, Size: 490 bytes --]
next prev parent reply other threads:[~2014-02-24 11:36 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-01-07 8:22 [PATCH 2/4] ARM: shmobile: r8a7791: Add VIN clocks to device tree Laurent Pinchart
2014-02-23 12:40 ` [PATCH 2/4] ARM: shmobile: r8a7791: add IIC(B) clocks to dtsi Wolfram Sang
2014-02-23 22:21 ` Laurent Pinchart
2014-02-23 22:23 ` Laurent Pinchart
2014-02-24 10:38 ` Wolfram Sang
2014-02-24 11:36 ` Laurent Pinchart [this message]
2014-02-24 23:47 ` Simon Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3971243.laxNKgqxOE@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=linux-sh@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.