Re: [PATCH v2] lksctp-tools: Add recipe for lksctp

[Denys Dmytriyenko <denys@ti.com>]

On Mon, Feb 24, 2014 at 04:00:25PM +0000, Maupin, Chase wrote:
> >-----Original Message-----
> >From: meta-arago-bounces@arago-project.org [mailto:meta-arago-
> >bounces@arago-project.org] On Behalf Of Nelson, Sam
> >Sent: Saturday, February 22, 2014 8:47 PM
> >To: meta-arago@arago-project.org
> >Subject: [meta-arago] [PATCH v2] lksctp-tools: Add recipe for
> >lksctp
> >
> >- The linux kernel Stream control transmission protocol
> >- Original recipe by Jingting Zhou
> 
> Can you please give a more descriptive statement about where this recipe 
> came from?  What layer for example, a URL to the original recipe.

Actually, since this is coming from a forked meta-arago-mcsdk and maybe even 
from a private tree, I'd rather not advertise the information such as URL. If 
you want to mention it, just say it comes from previous version of MCSDK...


> Also, can you split this into two patches?  One that adds the original 
> recipe and one that splits out your changes so it is easier to tell what has 
> been modified on top.

??? I think you are missing the fact that it's an in-house recipe, not coming 
from Open Source...


> >Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> >
> >---
> >Updated RREPLACES_${PN}
> >Fix build issue with .so
> >---
> >---
> > .../recipes-bsp/lksctp-tools/lksctp-tools_1.0.7.bb |   51
> >++++++++++++++++++++
> > 1 file changed, 51 insertions(+)
> > create mode 100755 meta-arago-extras/recipes-bsp/lksctp-
> >tools/lksctp-tools_1.0.7.bb
> >
> >diff --git a/meta-arago-extras/recipes-bsp/lksctp-tools/lksctp-
> >tools_1.0.7.bb b/meta-arago-extras/recipes-bsp/lksctp-
> >tools/lksctp-tools_1.0.7.bb
> >new file mode 100755
> >index 0000000..5c75552
> >--- /dev/null
> >+++ b/meta-arago-extras/recipes-bsp/lksctp-tools/lksctp-
> >tools_1.0.7.bb
> >@@ -0,0 +1,51 @@
> >+DESCRIPTION = "The Linux Kernel Stream Control Transmission
> >Protocol (lksctp) project"
> >+SECTION = "libs"
> >+PRIORITY = "optional"
> >+LICENSE = "LGPLv2"
> >+LIC_FILES_CHKSUM =
> >"file://src/include/netinet/sctp.h;md5=8089fbe48b63b73c8d091bee750
> >b2ebc"
> >+
> >+INC_PR = "r0"
> >+PR = "${INC_PR}.0"
> >+
> >+SRC_URI = "${SOURCEFORGE_MIRROR}/lksctp/lksctp-tools-
> >${PV}.tar.gz"
> >+
> >+SRC_URI[md5sum] = "047562b40537eb3be5d5ec3ae0a2198b"
> >+SRC_URI[sha256sum] =
> >"e920e89d110cff9847f1d86a1d7a23a156a8abcc9e65a35655d687fd08377595"
> >+
> >+S = "${WORKDIR}/${BPN}-${PV}"
> >+
> >+BBCLASSEXTEND = "native"
> >+
> >+inherit autotools pkgconfig binconfig
> >+
> >+do_install_append_virtclass-native() {
> >+	:
> >+}
> >+
> >+RREPLACES_${PN} = "lksctp"
> >+
> >+LEAD_SONAME = "libsctp.so"
> >+
> >+PACKAGES =+ "${PN}-withsctp ${PN}-utils"
> >+
> >+FILES_${PN} = "${libexecdir}/* ${libdir}/lib*${SOLIBS} \
> >+            ${sysconfdir} ${sharedstatedir} ${localstatedir} \
> >+            ${base_libdir}/*${SOLIBS}"
> >+
> >+FILES_${PN}-dev += " \
> >+  ${datadir}/lksctp-tools/checksctp.c \
> >+  ${datadir}/lksctp-tools/sctp_socket.c \
> >+  ${datadir}/lksctp-tools/sctp_bind.c \
> >+  ${datadir}/lksctp-tools/sctp_darn.c \
> >+  ${datadir}/lksctp-tools/sctp_load_libs.c \
> >+  ${datadir}/lksctp-tools/sctp_sockopt.c \
> >+  ${datadir}/lksctp-tools/sctp_socket.h \
> >+  ${datadir}/lksctp-tools/sctp_test.c \
> >+  ${datadir}/lksctp-tools/sctp_darn.h \
> >+  ${libdir}/lksctp-tools/lib*.so"
> >+
> >+FILES_${PN}-utils = " \
> >+  ${bindir}/sctp_test \
> >+  ${bindir}/sctp_darn \
> >+  ${bindir}/checksctp \
> >+  ${bindir}/withsctp"
> >--
> >1.7.9.5
> >
> >_______________________________________________
> >meta-arago mailing list
> >meta-arago@arago-project.org
> >http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago
> _______________________________________________
> meta-arago mailing list
> meta-arago@arago-project.org
> http://arago-project.org/cgi-bin/mailman/listinfo/meta-arago