From: Hani Benhabiles <kroosec@gmail.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-trivial] [Qemu-devel] [PATCH] balloon: Fix device name in error message.
Date: Mon, 24 Feb 2014 19:59:14 +0100 [thread overview]
Message-ID: <20140224185914.GC3855@Inspiron-3521> (raw)
In-Reply-To: <8738j86fwa.fsf@blackfin.pond.sub.org>
On Mon, Feb 24, 2014 at 10:04:05AM +0100, Markus Armbruster wrote:
> I agree the error message is bad, but I'm afraid your patch makes it
> worse :)
>
> qemu_balloon() returns zero when balloon_event_fn has not been set with
> qemu_add_balloon_handler().
>
> Right now, the only device that calls qemu_add_balloon_handler() is
> virtio-balloon-device. In theory, there could be others in the future.
>
> virtio-balloon-device is a virtio-bus device. The bus can be provided
> by virtio-balloon-pci or virtio-balloon-ccw.
>
> Your error message is misleading when it's provided by the latter.
>
I see. Sorry for not throughly understanding the whole chain yet!
I somehow missed virtio-balloon-ccw, thus my false belief that
virtio-balloon-pci would be the only one to be ever needed/used.
> Moreover, you missed qmp_query_balloon().
>
> QERR_DEVICE_NOT_ACTIVE is also used with argument "spice", and the
> resulting error message is similarly bad. Perhaps something like this
> would do:
>
> #define QERR_DEVICE_NOT_ACTIVE \
> ERROR_CLASS_DEVICE_NOT_ACTIVE, "No %s device has been activated"
Sounds good to me. Will send a patch shortly.
WARNING: multiple messages have this Message-ID (diff)
From: Hani Benhabiles <kroosec@gmail.com>
To: Markus Armbruster <armbru@redhat.com>
Cc: qemu-trivial@nongnu.org, qemu-devel@nongnu.org,
Luiz Capitulino <lcapitulino@redhat.com>
Subject: Re: [Qemu-devel] [PATCH] balloon: Fix device name in error message.
Date: Mon, 24 Feb 2014 19:59:14 +0100 [thread overview]
Message-ID: <20140224185914.GC3855@Inspiron-3521> (raw)
In-Reply-To: <8738j86fwa.fsf@blackfin.pond.sub.org>
On Mon, Feb 24, 2014 at 10:04:05AM +0100, Markus Armbruster wrote:
> I agree the error message is bad, but I'm afraid your patch makes it
> worse :)
>
> qemu_balloon() returns zero when balloon_event_fn has not been set with
> qemu_add_balloon_handler().
>
> Right now, the only device that calls qemu_add_balloon_handler() is
> virtio-balloon-device. In theory, there could be others in the future.
>
> virtio-balloon-device is a virtio-bus device. The bus can be provided
> by virtio-balloon-pci or virtio-balloon-ccw.
>
> Your error message is misleading when it's provided by the latter.
>
I see. Sorry for not throughly understanding the whole chain yet!
I somehow missed virtio-balloon-ccw, thus my false belief that
virtio-balloon-pci would be the only one to be ever needed/used.
> Moreover, you missed qmp_query_balloon().
>
> QERR_DEVICE_NOT_ACTIVE is also used with argument "spice", and the
> resulting error message is similarly bad. Perhaps something like this
> would do:
>
> #define QERR_DEVICE_NOT_ACTIVE \
> ERROR_CLASS_DEVICE_NOT_ACTIVE, "No %s device has been activated"
Sounds good to me. Will send a patch shortly.
next prev parent reply other threads:[~2014-02-24 18:59 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-23 14:05 [Qemu-trivial] [PATCH] balloon: Fix device name in error message Hani Benhabiles
2014-02-23 14:05 ` [Qemu-devel] " Hani Benhabiles
2014-02-24 9:04 ` [Qemu-trivial] " Markus Armbruster
2014-02-24 9:04 ` Markus Armbruster
2014-02-24 18:59 ` Hani Benhabiles [this message]
2014-02-24 18:59 ` Hani Benhabiles
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140224185914.GC3855@Inspiron-3521 \
--to=kroosec@gmail.com \
--cc=armbru@redhat.com \
--cc=lcapitulino@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-trivial@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.