From: Matt Porter <mporter@linaro.org>
To: Tim Kryger <tim.kryger@linaro.org>
Cc: Christian Daudt <bcm@fixthebug.org>, Chris Ball <cjb@laptop.org>,
Axel Lin <axel.lin@ingics.com>, Alex Elder <elder@linaro.org>,
Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Linux MMC List <linux-mmc@vger.kernel.org>,
Ulf Hansson <ulf.hansson@linaro.org>
Subject: Re: [PATCH v4 5/8] mmc: sdhci-bcm-kona: Add basic use of clocks
Date: Mon, 24 Feb 2014 14:33:01 -0500 [thread overview]
Message-ID: <20140224193301.GW5038@beef> (raw)
In-Reply-To: <CAAYSxhrBSv8_Z1SfB-b3iGgq218Gttny4FEgYJnLtSFhJd2UFg@mail.gmail.com>
[trimmed cc]
On Fri, Jan 24, 2014 at 09:07:24AM -0800, Tim Kryger wrote:
> On Tue, Jan 7, 2014 at 11:37 AM, Tim Kryger <tim.kryger@linaro.org> wrote:
> > On Sat, Dec 14, 2013 at 12:14 AM, Christian Daudt <bcm@fixthebug.org> wrote:
> >> On Thu, Dec 5, 2013 at 11:20 AM, Tim Kryger <tim.kryger@linaro.org> wrote:
> >>> Enable the external clock needed by the host controller during the
> >>> probe and disable it during the remove.
> >>>
> >>> Signed-off-by: Tim Kryger <tim.kryger@linaro.org>
> >>> Reviewed-by: Markus Mayer <markus.mayer@linaro.org>
> >>> Reviewed-by: Matt Porter <matt.porter@linaro.org>
> >>
> >> Reviewed-by: Christian Daudt <bcm@fixthebug.org>
> >>
> >> Chris,
> >> Are you ok with me pulling this patch along with the rest of the
> >> patchset into the bcm tree?
> >>
> >> Thanks,
> >> csd
> >
> > Chris,
> >
> > Can you please provide an answer to csd?
> >
> > Thanks,
> > Tim Kryger
>
> Chris,
>
> I haven't heard back so this patch has been dropped for 3.14 to allow
> the remaining patches in the series to move forward. As such, I will
> be re-posting this patch for 3.15. It is essential for the
> bcm28155_ap board to transition away from fake fixed clocks to the
> real clock driver. This is because the bcm281xx clock driver does not
> set the CLK_IGNORE_UNUSED flag for the SDHCI peripheral clocks and the
> common clock code will shut them off in late init unless the SDHCI
> driver has asked for them to be enabled.
I just queued Alex's patch for 3.15 that decouples the dependency
between this patch and the bcm kona common clock driver.
Chris: we no longer need this to be taken through arm-soc since removing
the dependency. Could you please take this patch through your tree for
3.15?
Thanks,
Matt
WARNING: multiple messages have this Message-ID (diff)
From: mporter@linaro.org (Matt Porter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 5/8] mmc: sdhci-bcm-kona: Add basic use of clocks
Date: Mon, 24 Feb 2014 14:33:01 -0500 [thread overview]
Message-ID: <20140224193301.GW5038@beef> (raw)
In-Reply-To: <CAAYSxhrBSv8_Z1SfB-b3iGgq218Gttny4FEgYJnLtSFhJd2UFg@mail.gmail.com>
[trimmed cc]
On Fri, Jan 24, 2014 at 09:07:24AM -0800, Tim Kryger wrote:
> On Tue, Jan 7, 2014 at 11:37 AM, Tim Kryger <tim.kryger@linaro.org> wrote:
> > On Sat, Dec 14, 2013 at 12:14 AM, Christian Daudt <bcm@fixthebug.org> wrote:
> >> On Thu, Dec 5, 2013 at 11:20 AM, Tim Kryger <tim.kryger@linaro.org> wrote:
> >>> Enable the external clock needed by the host controller during the
> >>> probe and disable it during the remove.
> >>>
> >>> Signed-off-by: Tim Kryger <tim.kryger@linaro.org>
> >>> Reviewed-by: Markus Mayer <markus.mayer@linaro.org>
> >>> Reviewed-by: Matt Porter <matt.porter@linaro.org>
> >>
> >> Reviewed-by: Christian Daudt <bcm@fixthebug.org>
> >>
> >> Chris,
> >> Are you ok with me pulling this patch along with the rest of the
> >> patchset into the bcm tree?
> >>
> >> Thanks,
> >> csd
> >
> > Chris,
> >
> > Can you please provide an answer to csd?
> >
> > Thanks,
> > Tim Kryger
>
> Chris,
>
> I haven't heard back so this patch has been dropped for 3.14 to allow
> the remaining patches in the series to move forward. As such, I will
> be re-posting this patch for 3.15. It is essential for the
> bcm28155_ap board to transition away from fake fixed clocks to the
> real clock driver. This is because the bcm281xx clock driver does not
> set the CLK_IGNORE_UNUSED flag for the SDHCI peripheral clocks and the
> common clock code will shut them off in late init unless the SDHCI
> driver has asked for them to be enabled.
I just queued Alex's patch for 3.15 that decouples the dependency
between this patch and the bcm kona common clock driver.
Chris: we no longer need this to be taken through arm-soc since removing
the dependency. Could you please take this patch through your tree for
3.15?
Thanks,
Matt
next prev parent reply other threads:[~2014-02-24 19:33 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-12-05 19:20 [PATCH v4 0/8] Update Kona drivers to use clocks Tim Kryger
2013-12-05 19:20 ` Tim Kryger
2013-12-05 19:20 ` [PATCH v4 1/8] ARM: dts: Declare clocks as fixed on bcm11351 Tim Kryger
2013-12-05 19:20 ` Tim Kryger
2013-12-05 19:20 ` Tim Kryger
2013-12-10 7:18 ` Christian Daudt
2013-12-10 7:18 ` Christian Daudt
2013-12-10 20:26 ` Tim Kryger
2013-12-10 20:26 ` Tim Kryger
2013-12-13 7:48 ` Christian Daudt
2013-12-13 7:48 ` Christian Daudt
2013-12-13 15:56 ` Tim Kryger
2013-12-13 15:56 ` Tim Kryger
2013-12-05 19:20 ` [PATCH v4 2/8] ARM: dts: Specify clocks for UARTs " Tim Kryger
2013-12-05 19:20 ` Tim Kryger
2013-12-05 19:20 ` Tim Kryger
2013-12-13 7:56 ` Christian Daudt
2013-12-13 7:56 ` Christian Daudt
2013-12-05 19:20 ` [PATCH v4 3/8] Documentation: dt: kona-sdhci: Add clocks property Tim Kryger
2013-12-05 19:20 ` Tim Kryger
2013-12-05 19:20 ` Tim Kryger
2013-12-13 8:02 ` Christian Daudt
2013-12-13 8:02 ` Christian Daudt
2013-12-05 19:20 ` [PATCH v4 4/8] ARM: dts: Specify clocks for SDHCIs on bcm11351 Tim Kryger
2013-12-05 19:20 ` Tim Kryger
2013-12-05 19:20 ` Tim Kryger
2013-12-13 8:22 ` Christian Daudt
2013-12-13 8:22 ` Christian Daudt
2013-12-05 19:20 ` [PATCH v4 5/8] mmc: sdhci-bcm-kona: Add basic use of clocks Tim Kryger
2013-12-05 19:20 ` Tim Kryger
2013-12-14 8:14 ` Christian Daudt
2013-12-14 8:14 ` Christian Daudt
2013-12-14 8:14 ` Christian Daudt
2013-12-23 8:26 ` Christian Daudt
2013-12-23 8:26 ` Christian Daudt
2014-01-07 19:37 ` Tim Kryger
2014-01-07 19:37 ` Tim Kryger
2014-01-24 17:07 ` Tim Kryger
2014-01-24 17:07 ` Tim Kryger
2014-02-24 19:33 ` Matt Porter [this message]
2014-02-24 19:33 ` Matt Porter
2014-02-24 19:40 ` Chris Ball
2014-02-24 19:40 ` Chris Ball
2013-12-05 19:20 ` [PATCH v4 6/8] Documentation: dt: kona-timer: Add clocks property Tim Kryger
2013-12-05 19:20 ` Tim Kryger
2013-12-05 19:20 ` Tim Kryger
2013-12-14 8:19 ` Christian Daudt
2013-12-14 8:19 ` Christian Daudt
2013-12-05 19:20 ` [PATCH v4 7/8] clocksource: kona: Add basic use of external clock Tim Kryger
2013-12-05 19:20 ` Tim Kryger
2013-12-05 19:20 ` Tim Kryger
2013-12-14 8:26 ` Christian Daudt
2013-12-14 8:26 ` Christian Daudt
2013-12-16 10:34 ` Daniel Lezcano
2013-12-16 10:34 ` Daniel Lezcano
2013-12-05 19:20 ` [PATCH v4 8/8] ARM: dts: Specify clocks for timer on bcm11351 Tim Kryger
2013-12-05 19:20 ` Tim Kryger
2013-12-05 19:20 ` Tim Kryger
2013-12-13 8:06 ` Christian Daudt
2013-12-13 8:06 ` Christian Daudt
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140224193301.GW5038@beef \
--to=mporter@linaro.org \
--cc=axel.lin@ingics.com \
--cc=bcm@fixthebug.org \
--cc=cjb@laptop.org \
--cc=elder@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=tim.kryger@linaro.org \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.