From: Jan Kara <jack@suse.cz>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jan Kara <jack@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ext3: remove an unneeded check in ext3_new_blocks()
Date: Tue, 25 Feb 2014 09:49:29 +0000 [thread overview]
Message-ID: <20140225094929.GA1669@quack.suse.cz> (raw)
In-Reply-To: <20140225083945.GC5023@elgon.mountain>
On Tue 25-02-14 11:39:45, Dan Carpenter wrote:
> We know "fatal" is zero here. The code can be simplified a bit by
> assigning directly.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks. Added to my tree.
Honza
>
> diff --git a/fs/ext3/balloc.c b/fs/ext3/balloc.c
> index 22548f56197b..158b5d4ce067 100644
> --- a/fs/ext3/balloc.c
> +++ b/fs/ext3/balloc.c
> @@ -1727,10 +1727,7 @@ allocated:
> percpu_counter_sub(&sbi->s_freeblocks_counter, num);
>
> BUFFER_TRACE(gdp_bh, "journal_dirty_metadata for group descriptor");
> - err = ext3_journal_dirty_metadata(handle, gdp_bh);
> - if (!fatal)
> - fatal = err;
> -
> + fatal = ext3_journal_dirty_metadata(handle, gdp_bh);
> if (fatal)
> goto out;
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
WARNING: multiple messages have this Message-ID (diff)
From: Jan Kara <jack@suse.cz>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Jan Kara <jack@suse.cz>,
Andrew Morton <akpm@linux-foundation.org>,
Andreas Dilger <adilger.kernel@dilger.ca>,
linux-ext4@vger.kernel.org, kernel-janitors@vger.kernel.org
Subject: Re: [patch] ext3: remove an unneeded check in ext3_new_blocks()
Date: Tue, 25 Feb 2014 10:49:29 +0100 [thread overview]
Message-ID: <20140225094929.GA1669@quack.suse.cz> (raw)
In-Reply-To: <20140225083945.GC5023@elgon.mountain>
On Tue 25-02-14 11:39:45, Dan Carpenter wrote:
> We know "fatal" is zero here. The code can be simplified a bit by
> assigning directly.
>
> Signed-off-by: Dan Carpenter <dan.carpenter@oracle.com>
Thanks. Added to my tree.
Honza
>
> diff --git a/fs/ext3/balloc.c b/fs/ext3/balloc.c
> index 22548f56197b..158b5d4ce067 100644
> --- a/fs/ext3/balloc.c
> +++ b/fs/ext3/balloc.c
> @@ -1727,10 +1727,7 @@ allocated:
> percpu_counter_sub(&sbi->s_freeblocks_counter, num);
>
> BUFFER_TRACE(gdp_bh, "journal_dirty_metadata for group descriptor");
> - err = ext3_journal_dirty_metadata(handle, gdp_bh);
> - if (!fatal)
> - fatal = err;
> -
> + fatal = ext3_journal_dirty_metadata(handle, gdp_bh);
> if (fatal)
> goto out;
>
--
Jan Kara <jack@suse.cz>
SUSE Labs, CR
next prev parent reply other threads:[~2014-02-25 9:49 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-25 8:39 [patch] ext3: remove an unneeded check in ext3_new_blocks() Dan Carpenter
2014-02-25 8:39 ` Dan Carpenter
2014-02-25 9:49 ` Jan Kara [this message]
2014-02-25 9:49 ` Jan Kara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140225094929.GA1669@quack.suse.cz \
--to=jack@suse.cz \
--cc=adilger.kernel@dilger.ca \
--cc=akpm@linux-foundation.org \
--cc=dan.carpenter@oracle.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.