From: Andy Gross <agross@codeaurora.org>
To: Stanimir Varbanov <svarbanov@mm-sol.com>
Cc: Vinod Koul <vinod.koul@intel.com>,
Dan Williams <dan.j.williams@intel.com>,
dmaengine@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [Patch v7 2/2] dmaengine: add Qualcomm BAM dma driver
Date: Wed, 26 Feb 2014 11:06:56 -0600 [thread overview]
Message-ID: <20140226170656.GA21772@qualcomm.com> (raw)
In-Reply-To: <530E1BAB.6040609@mm-sol.com>
On Wed, Feb 26, 2014 at 06:51:55PM +0200, Stanimir Varbanov wrote:
> > + /* read revision and configuration information */
> > + val = readl_relaxed(bdev->regs + BAM_REVISION) & NUM_EES_MASK;
> > +
>
> The ees shit is not zero and you got wrong ee. Could you add the line
> below or something similar:
>
> val = (val >> NUM_EES_SHIFT) & NUM_EES_MASK;
>
Good catch. I missed the shift when I reworked and got lucky that the revision
is in the lower 8 bits and is non-zero.
--
sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: agross@codeaurora.org (Andy Gross)
To: linux-arm-kernel@lists.infradead.org
Subject: [Patch v7 2/2] dmaengine: add Qualcomm BAM dma driver
Date: Wed, 26 Feb 2014 11:06:56 -0600 [thread overview]
Message-ID: <20140226170656.GA21772@qualcomm.com> (raw)
In-Reply-To: <530E1BAB.6040609@mm-sol.com>
On Wed, Feb 26, 2014 at 06:51:55PM +0200, Stanimir Varbanov wrote:
> > + /* read revision and configuration information */
> > + val = readl_relaxed(bdev->regs + BAM_REVISION) & NUM_EES_MASK;
> > +
>
> The ees shit is not zero and you got wrong ee. Could you add the line
> below or something similar:
>
> val = (val >> NUM_EES_SHIFT) & NUM_EES_MASK;
>
Good catch. I missed the shift when I reworked and got lucky that the revision
is in the lower 8 bits and is non-zero.
--
sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-02-26 17:06 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-24 23:11 [Patch v7 0/2] Add Qualcomm BAM dmaengine driver Andy Gross
2014-02-24 23:11 ` Andy Gross
[not found] ` <1393283500-18599-1-git-send-email-agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-02-24 23:11 ` [Patch v7 1/2] dmaengine: qcom_bam_dma: Add device tree binding Andy Gross
2014-02-24 23:11 ` Andy Gross
2014-02-24 23:11 ` Andy Gross
2014-02-24 23:11 ` [Patch v7 2/2] dmaengine: add Qualcomm BAM dma driver Andy Gross
2014-02-24 23:11 ` Andy Gross
2014-02-25 0:09 ` Felipe Balbi
2014-02-25 0:09 ` Felipe Balbi
2014-02-25 0:09 ` Felipe Balbi
2014-02-25 3:05 ` Mark Brown
2014-02-25 3:05 ` Mark Brown
2014-02-25 5:00 ` Felipe Balbi
2014-02-25 5:00 ` Felipe Balbi
2014-02-25 5:00 ` Felipe Balbi
2014-02-26 16:51 ` Stanimir Varbanov
2014-02-26 16:51 ` Stanimir Varbanov
2014-02-26 17:06 ` Andy Gross [this message]
2014-02-26 17:06 ` Andy Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140226170656.GA21772@qualcomm.com \
--to=agross@codeaurora.org \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=svarbanov@mm-sol.com \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.