* [meta-fsl-arm][PATCH] image_types_fsl: fix barebox bootstream generation
@ 2014-02-27 9:55 Alexandre Belloni
2014-02-27 10:14 ` Alexandre Belloni
0 siblings, 1 reply; 5+ messages in thread
From: Alexandre Belloni @ 2014-02-27 9:55 UTC (permalink / raw)
To: meta-freescale; +Cc: Maxime Ripard, jimwall
Since the image_types.bbclass is not cd'ing to ${DEPLOY_DIR_IMAGE}
anymore, do that in a subshell before generating the boostream.
This fixes the following build failure:
ERROR: Error: The image creation script '/home/build/yocto/cfa/tmp/work/cfa10058-poky-linux-gnueabi/core-image-minimal/1.0-r0/temp/create_image.barebox.mxsboot-sdcard' returned 1:
error: unable to find command file imx-bootlets-barebox_ivt.bd-cfa10058
Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
---
classes/image_types_fsl.bbclass | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/classes/image_types_fsl.bbclass b/classes/image_types_fsl.bbclass
index fd2effd2be64..f0160dfe93be 100644
--- a/classes/image_types_fsl.bbclass
+++ b/classes/image_types_fsl.bbclass
@@ -42,9 +42,9 @@ IMAGE_CMD_barebox.mxsboot-sdcard () {
barebox_bd_file=imx-bootlets-barebox_ivt.bd-${MACHINE}
# Ensure the files are generated
- rm -f ${IMAGE_NAME}.barebox.sb ${IMAGE_NAME}.barebox.mxsboot-sdcard
- elftosb -f mx28 -z -c $barebox_bd_file -o ${IMAGE_NAME}.barebox.sb
- mxsboot sd ${IMAGE_NAME}.barebox.sb ${IMAGE_NAME}.barebox.mxsboot-sdcard
+ (cd ${DEPLOY_DIR_IMAGE}; rm -f ${IMAGE_NAME}.barebox.sb ${IMAGE_NAME}.barebox.mxsboot-sdcard; \
+ elftosb -f mx28 -z -c $barebox_bd_file -o ${IMAGE_NAME}.barebox.sb; \
+ mxsboot sd ${IMAGE_NAME}.barebox.sb ${IMAGE_NAME}.barebox.mxsboot-sdcard)
}
# U-Boot mxsboot generation to SD-Card
--
1.8.3.2
^ permalink raw reply related [flat|nested] 5+ messages in thread* Re: [meta-fsl-arm][PATCH] image_types_fsl: fix barebox bootstream generation
2014-02-27 9:55 [meta-fsl-arm][PATCH] image_types_fsl: fix barebox bootstream generation Alexandre Belloni
@ 2014-02-27 10:14 ` Alexandre Belloni
2014-02-27 14:16 ` Daiane.Angolini
0 siblings, 1 reply; 5+ messages in thread
From: Alexandre Belloni @ 2014-02-27 10:14 UTC (permalink / raw)
To: meta-freescale; +Cc: Maxime Ripard, jimwall
Just as a note, Someone should probably have a look at doing something
similar for linux.sb but I didn't take the time to test it.
On 27/02/2014 at 10:55:27 +0100, Alexandre Belloni wrote :
> Since the image_types.bbclass is not cd'ing to ${DEPLOY_DIR_IMAGE}
> anymore, do that in a subshell before generating the boostream.
> This fixes the following build failure:
>
> ERROR: Error: The image creation script '/home/build/yocto/cfa/tmp/work/cfa10058-poky-linux-gnueabi/core-image-minimal/1.0-r0/temp/create_image.barebox.mxsboot-sdcard' returned 1:
> error: unable to find command file imx-bootlets-barebox_ivt.bd-cfa10058
>
> Signed-off-by: Alexandre Belloni <alexandre.belloni@free-electrons.com>
> ---
> classes/image_types_fsl.bbclass | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
>
> diff --git a/classes/image_types_fsl.bbclass b/classes/image_types_fsl.bbclass
> index fd2effd2be64..f0160dfe93be 100644
> --- a/classes/image_types_fsl.bbclass
> +++ b/classes/image_types_fsl.bbclass
> @@ -42,9 +42,9 @@ IMAGE_CMD_barebox.mxsboot-sdcard () {
> barebox_bd_file=imx-bootlets-barebox_ivt.bd-${MACHINE}
>
> # Ensure the files are generated
> - rm -f ${IMAGE_NAME}.barebox.sb ${IMAGE_NAME}.barebox.mxsboot-sdcard
> - elftosb -f mx28 -z -c $barebox_bd_file -o ${IMAGE_NAME}.barebox.sb
> - mxsboot sd ${IMAGE_NAME}.barebox.sb ${IMAGE_NAME}.barebox.mxsboot-sdcard
> + (cd ${DEPLOY_DIR_IMAGE}; rm -f ${IMAGE_NAME}.barebox.sb ${IMAGE_NAME}.barebox.mxsboot-sdcard; \
> + elftosb -f mx28 -z -c $barebox_bd_file -o ${IMAGE_NAME}.barebox.sb; \
> + mxsboot sd ${IMAGE_NAME}.barebox.sb ${IMAGE_NAME}.barebox.mxsboot-sdcard)
> }
>
> # U-Boot mxsboot generation to SD-Card
> --
> 1.8.3.2
>
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread* Re: [meta-fsl-arm][PATCH] image_types_fsl: fix barebox bootstream generation
2014-02-27 10:14 ` Alexandre Belloni
@ 2014-02-27 14:16 ` Daiane.Angolini
2014-02-27 14:20 ` Alexandre Belloni
0 siblings, 1 reply; 5+ messages in thread
From: Daiane.Angolini @ 2014-02-27 14:16 UTC (permalink / raw)
To: Alexandre Belloni, meta-freescale@yoctoproject.org
Cc: Maxime Ripard, jimwall@q.com
> -----Original Message-----
> From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-
> bounces@yoctoproject.org] On Behalf Of Alexandre Belloni
> Sent: Thursday, February 27, 2014 7:15 AM
> To: meta-freescale@yoctoproject.org
> Cc: Maxime Ripard; jimwall@q.com
> Subject: Re: [meta-freescale] [meta-fsl-arm][PATCH] image_types_fsl: fix
> barebox bootstream generation
>
> Just as a note, Someone should probably have a look at doing something
> similar for linux.sb but I didn't take the time to test it.
Would be the case to add a #FIXME note in your piece of code?
Daiane
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [meta-fsl-arm][PATCH] image_types_fsl: fix barebox bootstream generation
2014-02-27 14:16 ` Daiane.Angolini
@ 2014-02-27 14:20 ` Alexandre Belloni
2014-02-27 15:27 ` Daiane.Angolini
0 siblings, 1 reply; 5+ messages in thread
From: Alexandre Belloni @ 2014-02-27 14:20 UTC (permalink / raw)
To: Daiane.Angolini@freescale.com
Cc: meta-freescale@yoctoproject.org, Maxime Ripard, jimwall@q.com
On 27/02/2014 at 14:16:55 +0000, Daiane.Angolini@freescale.com wrote :
>
>
> > -----Original Message-----
> > From: meta-freescale-bounces@yoctoproject.org [mailto:meta-freescale-
> > bounces@yoctoproject.org] On Behalf Of Alexandre Belloni
> > Sent: Thursday, February 27, 2014 7:15 AM
> > To: meta-freescale@yoctoproject.org
> > Cc: Maxime Ripard; jimwall@q.com
> > Subject: Re: [meta-freescale] [meta-fsl-arm][PATCH] image_types_fsl: fix
> > barebox bootstream generation
> >
> > Just as a note, Someone should probably have a look at doing something
> > similar for linux.sb but I didn't take the time to test it.
>
>
> Would be the case to add a #FIXME note in your piece of code?
>
I guess, Otavio will have a look quickly. Maybe this is not broken I'm
not sure it is worth saying it is broken if it isn't ;)
--
Alexandre Belloni, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [meta-fsl-arm][PATCH] image_types_fsl: fix barebox bootstream generation
2014-02-27 14:20 ` Alexandre Belloni
@ 2014-02-27 15:27 ` Daiane.Angolini
0 siblings, 0 replies; 5+ messages in thread
From: Daiane.Angolini @ 2014-02-27 15:27 UTC (permalink / raw)
To: Alexandre Belloni
Cc: meta-freescale@yoctoproject.org, Maxime Ripard, jimwall@q.com
> -----Original Message-----
> From: Alexandre Belloni [mailto:alexandre.belloni@free-electrons.com]
> Sent: Thursday, February 27, 2014 11:20 AM
> To: Angolini Daiane-B19406
> Cc: meta-freescale@yoctoproject.org; Maxime Ripard; jimwall@q.com
> Subject: Re: [meta-freescale] [meta-fsl-arm][PATCH] image_types_fsl: fix
> barebox bootstream generation
>
> On 27/02/2014 at 14:16:55 +0000, Daiane.Angolini@freescale.com wrote :
> >
> >
> > > -----Original Message-----
> > > From: meta-freescale-bounces@yoctoproject.org
> > > [mailto:meta-freescale- bounces@yoctoproject.org] On Behalf Of
> > > Alexandre Belloni
> > > Sent: Thursday, February 27, 2014 7:15 AM
> > > To: meta-freescale@yoctoproject.org
> > > Cc: Maxime Ripard; jimwall@q.com
> > > Subject: Re: [meta-freescale] [meta-fsl-arm][PATCH] image_types_fsl:
> > > fix barebox bootstream generation
> > >
> > > Just as a note, Someone should probably have a look at doing
> > > something similar for linux.sb but I didn't take the time to test it.
> >
> >
> > Would be the case to add a #FIXME note in your piece of code?
> >
>
> I guess, Otavio will have a look quickly. Maybe this is not broken I'm not
> sure it is worth saying it is broken if it isn't ;)
>
Perfect ;)
Daiane
^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2014-02-27 15:27 UTC | newest]
Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-27 9:55 [meta-fsl-arm][PATCH] image_types_fsl: fix barebox bootstream generation Alexandre Belloni
2014-02-27 10:14 ` Alexandre Belloni
2014-02-27 14:16 ` Daiane.Angolini
2014-02-27 14:20 ` Alexandre Belloni
2014-02-27 15:27 ` Daiane.Angolini
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.