From: "'gregkh@linuxfoundation.org'" <gregkh@linuxfoundation.org>
To: "Wang, Yalin" <Yalin.Wang@sonymobile.com>
Cc: "'alsa-devel@alsa-project.org'" <alsa-devel@alsa-project.org>,
"'broonie@opensource.wolfsonmicro.com'"
<broonie@opensource.wolfsonmicro.com>,
"'tiwai@suse.de'" <tiwai@suse.de>,
"'fweisbec@gmail.com'" <fweisbec@gmail.com>,
"'mingo@redhat.com'" <mingo@redhat.com>,
"'linux-input@vger.kernel.org'" <linux-input@vger.kernel.org>,
"'rydberg@euromail.se'" <rydberg@euromail.se>,
"'lrg@ti.com'" <lrg@ti.com>,
"'pablo@netfilter.org'" <pablo@netfilter.org>,
"'coreteam@netfilter.org'" <coreteam@netfilter.org>,
"'linux-arm-msm@vger.kernel.org'" <linux-arm-msm@vger.kernel.org>,
"'rostedt@goodmis.org'" <rostedt@goodmis.org>,
"'netfilter@vger.kernel.org'" <netfilter@vger.kernel.org>,
"'linux-arm-kernel@lists.infradead.org'"
<linux-arm-kernel@lists.infradead.org>,
"'netdev@vger.kernel.org'" <netdev@vger.kernel.org>,
"'dmitry.torokhov@gmail.com'" <dmitry.torokhov@gmail.com>,
'linux-kern
Subject: Re: change kmalloc into vmalloc for large memory allocations
Date: Fri, 28 Feb 2014 08:33:04 -0800 [thread overview]
Message-ID: <20140228163304.GA15614@kroah.com> (raw)
In-Reply-To: <35FD53F367049845BC99AC72306C23D102844605F38D@CNBJMBX05.corpusers.net>
On Fri, Feb 28, 2014 at 05:20:08PM +0800, Wang, Yalin wrote:
> Hi
>
>
> Yeah,
> Dma buffer must be allocated by kmalloc,
>
> But the modules I list should can all be changed to use
> vmalloc, because the buffer is only used by software,
> Not by any hardware .
Are you sure about that? The USB gadget driver needs DMA memory from
what I can tell, have you tried your change out on a system that does
not allow the USB controller to access non-DMA memory?
And I agree with Steve, just fix the individual drivers, don't do a
"hidden" change of where the memory is allocated from, that's not a good
idea and will cause problems later.
greg k-h
WARNING: multiple messages have this Message-ID (diff)
From: gregkh@linuxfoundation.org ('gregkh@linuxfoundation.org')
To: linux-arm-kernel@lists.infradead.org
Subject: change kmalloc into vmalloc for large memory allocations
Date: Fri, 28 Feb 2014 08:33:04 -0800 [thread overview]
Message-ID: <20140228163304.GA15614@kroah.com> (raw)
In-Reply-To: <35FD53F367049845BC99AC72306C23D102844605F38D@CNBJMBX05.corpusers.net>
On Fri, Feb 28, 2014 at 05:20:08PM +0800, Wang, Yalin wrote:
> Hi
>
>
> Yeah,
> Dma buffer must be allocated by kmalloc,
>
> But the modules I list should can all be changed to use
> vmalloc, because the buffer is only used by software,
> Not by any hardware .
Are you sure about that? The USB gadget driver needs DMA memory from
what I can tell, have you tried your change out on a system that does
not allow the USB controller to access non-DMA memory?
And I agree with Steve, just fix the individual drivers, don't do a
"hidden" change of where the memory is allocated from, that's not a good
idea and will cause problems later.
greg k-h
next prev parent reply other threads:[~2014-02-28 16:31 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-28 8:15 [alsa-devel] change kmalloc into vmalloc for large memory allocations Wang, Yalin
2014-02-28 8:15 ` Wang, Yalin
2014-02-28 8:15 ` Wang, Yalin
2014-02-28 8:54 ` Huang Shijie
2014-02-28 8:54 ` Huang Shijie
2014-02-28 9:20 ` Wang, Yalin
2014-02-28 9:20 ` Wang, Yalin
2014-02-28 9:20 ` Wang, Yalin
2014-02-28 16:33 ` 'gregkh@linuxfoundation.org' [this message]
2014-02-28 16:33 ` 'gregkh@linuxfoundation.org'
2014-03-03 2:51 ` Wang, Yalin
2014-03-03 2:51 ` Wang, Yalin
2014-03-03 2:51 ` Wang, Yalin
2014-03-03 3:08 ` 'gregkh@linuxfoundation.org'
2014-03-03 3:08 ` 'gregkh@linuxfoundation.org'
2014-03-03 3:08 ` 'gregkh@linuxfoundation.org'
2014-03-03 8:00 ` Wang, Yalin
2014-03-03 8:00 ` Wang, Yalin
2014-03-03 8:00 ` Wang, Yalin
2014-03-03 14:10 ` 'gregkh@linuxfoundation.org'
2014-03-03 14:10 ` 'gregkh@linuxfoundation.org'
2014-03-04 7:30 ` [PATCH] netfilter:Change nf_conntrack modules to use vmalloc Wang, Yalin
2014-03-04 7:30 ` Wang, Yalin
2014-02-28 14:11 ` change kmalloc into vmalloc for large memory allocations Steven Rostedt
2014-02-28 14:11 ` Steven Rostedt
2014-02-28 14:11 ` Steven Rostedt
2014-02-28 14:19 ` Takashi Iwai
2014-02-28 14:19 ` Takashi Iwai
2014-02-28 14:19 ` Takashi Iwai
2014-03-03 1:55 ` Wang, Yalin
2014-03-03 1:55 ` Wang, Yalin
2014-03-03 1:55 ` Wang, Yalin
2014-03-03 9:19 ` Takashi Iwai
2014-03-03 9:23 ` Takashi Iwai
2014-03-03 11:13 ` Wang, Yalin
2014-03-03 11:34 ` [alsa-devel] " Lars-Peter Clausen
2014-03-03 11:36 ` Wang, Yalin
2014-03-03 11:45 ` Lars-Peter Clausen
2014-03-03 11:45 ` [alsa-devel] " Lars-Peter Clausen
2014-03-03 13:29 ` Wang, Yalin
2014-03-03 14:22 ` Lars-Peter Clausen
2014-03-03 14:29 ` Wang, Yalin
2014-03-03 14:43 ` Takashi Iwai
2014-03-03 15:33 ` Wang, Yalin
2014-03-03 15:33 ` [alsa-devel] " Wang, Yalin
2014-03-04 3:46 ` Mark Brown
-- strict thread matches above, loose matches on Subject: below --
2014-02-28 8:15 Wang, Yalin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140228163304.GA15614@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=Yalin.Wang@sonymobile.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@opensource.wolfsonmicro.com \
--cc=coreteam@netfilter.org \
--cc=dmitry.torokhov@gmail.com \
--cc=fweisbec@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-input@vger.kernel.org \
--cc=lrg@ti.com \
--cc=mingo@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=netfilter@vger.kernel.org \
--cc=pablo@netfilter.org \
--cc=rostedt@goodmis.org \
--cc=rydberg@euromail.se \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.