* [PATCH] staging: sb105x: b_pci_mp.c: fix for non-member access
@ 2014-02-28 2:21 ` Kumar Amit Mehta
0 siblings, 0 replies; 6+ messages in thread
From: Kumar Amit Mehta @ 2014-02-28 2:21 UTC (permalink / raw)
To: gregkh
Cc: standby24x7, josh, rashika.kheria, lidza.louina, dan.carpenter,
lisa, devel, kernel-janitors, linux-kernel
'struct tty_struct’ has no member named ‘low_latency’
Signed-off-by: Kumar Amit Mehta <gmate.amit@gmail.com>
---
drivers/staging/sb105x/sb_pci_mp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/sb105x/sb_pci_mp.c b/drivers/staging/sb105x/sb_pci_mp.c
index c9d6ee3..5687d6c 100644
--- a/drivers/staging/sb105x/sb_pci_mp.c
+++ b/drivers/staging/sb105x/sb_pci_mp.c
@@ -898,7 +898,7 @@ static int mp_set_info(struct sb_uart_state *state, struct serial_struct *newinf
state->closing_wait = closing_wait;
port->fifosize = new_serial.xmit_fifo_size;
if (state->info->tty)
- state->info->tty->low_latency + state->info->tty->port->low_latency (port->flags & UPF_LOW_LATENCY) ? 1 : 0;
check_and_exit:
@@ -1571,7 +1571,7 @@ static int mp_open(struct tty_struct *tty, struct file *filp)
mtpt = (struct mp_port *)state->port;
tty->driver_data = state;
- tty->low_latency = (state->port->flags & UPF_LOW_LATENCY) ? 1 : 0;
+ tty->port->low_latency = (state->port->flags & UPF_LOW_LATENCY) ? 1 : 0;
tty->alt_speed = 0;
state->info->tty = tty;
--
1.8.5.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH] staging: sb105x: b_pci_mp.c: fix for non-member access
@ 2014-02-28 2:21 ` Kumar Amit Mehta
0 siblings, 0 replies; 6+ messages in thread
From: Kumar Amit Mehta @ 2014-02-28 2:21 UTC (permalink / raw)
To: gregkh
Cc: standby24x7, josh, rashika.kheria, lidza.louina, dan.carpenter,
lisa, devel, kernel-janitors, linux-kernel
'struct tty_struct’ has no member named ‘low_latency’
Signed-off-by: Kumar Amit Mehta <gmate.amit@gmail.com>
---
drivers/staging/sb105x/sb_pci_mp.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/staging/sb105x/sb_pci_mp.c b/drivers/staging/sb105x/sb_pci_mp.c
index c9d6ee3..5687d6c 100644
--- a/drivers/staging/sb105x/sb_pci_mp.c
+++ b/drivers/staging/sb105x/sb_pci_mp.c
@@ -898,7 +898,7 @@ static int mp_set_info(struct sb_uart_state *state, struct serial_struct *newinf
state->closing_wait = closing_wait;
port->fifosize = new_serial.xmit_fifo_size;
if (state->info->tty)
- state->info->tty->low_latency =
+ state->info->tty->port->low_latency =
(port->flags & UPF_LOW_LATENCY) ? 1 : 0;
check_and_exit:
@@ -1571,7 +1571,7 @@ static int mp_open(struct tty_struct *tty, struct file *filp)
mtpt = (struct mp_port *)state->port;
tty->driver_data = state;
- tty->low_latency = (state->port->flags & UPF_LOW_LATENCY) ? 1 : 0;
+ tty->port->low_latency = (state->port->flags & UPF_LOW_LATENCY) ? 1 : 0;
tty->alt_speed = 0;
state->info->tty = tty;
--
1.8.5.3
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: sb105x: b_pci_mp.c: fix for non-member access
2014-02-28 2:21 ` Kumar Amit Mehta
@ 2014-02-28 22:20 ` Greg KH
-1 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2014-02-28 22:20 UTC (permalink / raw)
To: Kumar Amit Mehta
Cc: devel, lisa, lidza.louina, kernel-janitors, josh, linux-kernel,
rashika.kheria, dan.carpenter
On Fri, Feb 28, 2014 at 04:21:03AM +0200, Kumar Amit Mehta wrote:
> 'struct tty_struct’ has no member named ‘low_latency’
This driver is marked BROKEN, and can't even compile, how did you test
this patch?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: sb105x: b_pci_mp.c: fix for non-member access
@ 2014-02-28 22:20 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2014-02-28 22:20 UTC (permalink / raw)
To: Kumar Amit Mehta
Cc: devel, lisa, lidza.louina, kernel-janitors, josh, linux-kernel,
rashika.kheria, dan.carpenter
On Fri, Feb 28, 2014 at 04:21:03AM +0200, Kumar Amit Mehta wrote:
> 'struct tty_struct’ has no member named ‘low_latency’
This driver is marked BROKEN, and can't even compile, how did you test
this patch?
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: sb105x: b_pci_mp.c: fix for non-member access
2014-02-28 22:20 ` Greg KH
@ 2014-02-28 22:24 ` Greg KH
-1 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2014-02-28 22:24 UTC (permalink / raw)
To: Kumar Amit Mehta
Cc: devel, lisa, lidza.louina, kernel-janitors, josh, linux-kernel,
rashika.kheria, dan.carpenter
On Fri, Feb 28, 2014 at 02:20:40PM -0800, Greg KH wrote:
> On Fri, Feb 28, 2014 at 04:21:03AM +0200, Kumar Amit Mehta wrote:
> > 'struct tty_struct’ has no member named ‘low_latency’
>
> This driver is marked BROKEN, and can't even compile, how did you test
> this patch?
Don't worry about it anymore, I've now deleted the driver entirely, as
no one has cared about it in the past year that it has been disabled
from the kernel build.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH] staging: sb105x: b_pci_mp.c: fix for non-member access
@ 2014-02-28 22:24 ` Greg KH
0 siblings, 0 replies; 6+ messages in thread
From: Greg KH @ 2014-02-28 22:24 UTC (permalink / raw)
To: Kumar Amit Mehta
Cc: devel, lisa, lidza.louina, kernel-janitors, josh, linux-kernel,
rashika.kheria, dan.carpenter
On Fri, Feb 28, 2014 at 02:20:40PM -0800, Greg KH wrote:
> On Fri, Feb 28, 2014 at 04:21:03AM +0200, Kumar Amit Mehta wrote:
> > 'struct tty_struct’ has no member named ‘low_latency’
>
> This driver is marked BROKEN, and can't even compile, how did you test
> this patch?
Don't worry about it anymore, I've now deleted the driver entirely, as
no one has cared about it in the past year that it has been disabled
from the kernel build.
thanks,
greg k-h
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2014-02-28 22:24 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-28 2:21 [PATCH] staging: sb105x: b_pci_mp.c: fix for non-member access Kumar Amit Mehta
2014-02-28 2:21 ` Kumar Amit Mehta
2014-02-28 22:20 ` Greg KH
2014-02-28 22:20 ` Greg KH
2014-02-28 22:24 ` Greg KH
2014-02-28 22:24 ` Greg KH
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.