All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tony Lindgren <tony@atomide.com>
To: Marek Belisko <marek@goldelico.com>
Cc: bcousson@baylibre.com, robh+dt@kernel.org, pawel.moll@arm.com,
	mark.rutland@arm.com, ijc+devicetree@hellion.org.uk,
	galak@codeaurora.org, linux@arm.linux.org.uk,
	linux-omap@vger.kernel.org, devicetree@vger.kernel.org,
	linux-arm-kernel@lists.infradead.org,
	linux-kernel@vger.kernel.org, neilb@suse.de, hns@goldelico.com
Subject: Re: [PATCH 5/9] ARM: dts: omap3-gta04: Add basic sound support.
Date: Fri, 28 Feb 2014 14:25:02 -0800	[thread overview]
Message-ID: <20140228222501.GL13624@atomide.com> (raw)
In-Reply-To: <1390685343-11663-6-git-send-email-marek@goldelico.com>

* Marek Belisko <marek@goldelico.com> [140125 13:31]:

Hmm care to add descriptions and repost the remaining patches
that I did not yet pick up for the fixes?

> Signed-off-by: NeilBrown <neilb@suse.de>

Hmm should this also have From: NeilBrown <neilb@suse.de>?

Also, while at it, maybe change your long time habit of adding
a period to the end of the subject line? That is of course
if you don't insist on having it, it's not usually used if
you look at git log --pretty=oneline :)

Regards,

Tony

> ---
>  arch/arm/boot/dts/omap3-gta04.dts | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/omap3-gta04.dts b/arch/arm/boot/dts/omap3-gta04.dts
> index 7e09410..a924a843 100644
> --- a/arch/arm/boot/dts/omap3-gta04.dts
> +++ b/arch/arm/boot/dts/omap3-gta04.dts
> @@ -36,6 +36,14 @@
>  			gpio-key,wakeup;
>  		};
>  	};
> +
> +	sound {
> +		compatible = "ti,omap-twl4030";
> +		ti,model = "gta04";
> +
> +		ti,mcbsp = <&mcbsp2>;
> +		ti,codec = <&twl_audio>;
> +	};
>  };
>  
>  &omap3_pmx_core {
> @@ -79,6 +87,13 @@
>  		reg = <0x48>;
>  		interrupts = <7>; /* SYS_NIRQ cascaded to intc */
>  		interrupt-parent = <&intc>;
> +
> +		twl_audio: audio {
> +			compatible = "ti,twl4030-audio";
> +			codec {
> +			};
> +		};
> +
>  		vaux4: regulator-vaux4 {
>  			compatible = "ti,twl4030-vaux4";
>  			regulator-min-microvolt = <2800000>;
> -- 
> 1.8.3.2
> 

WARNING: multiple messages have this Message-ID (diff)
From: tony@atomide.com (Tony Lindgren)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 5/9] ARM: dts: omap3-gta04: Add basic sound support.
Date: Fri, 28 Feb 2014 14:25:02 -0800	[thread overview]
Message-ID: <20140228222501.GL13624@atomide.com> (raw)
In-Reply-To: <1390685343-11663-6-git-send-email-marek@goldelico.com>

* Marek Belisko <marek@goldelico.com> [140125 13:31]:

Hmm care to add descriptions and repost the remaining patches
that I did not yet pick up for the fixes?

> Signed-off-by: NeilBrown <neilb@suse.de>

Hmm should this also have From: NeilBrown <neilb@suse.de>?

Also, while at it, maybe change your long time habit of adding
a period to the end of the subject line? That is of course
if you don't insist on having it, it's not usually used if
you look at git log --pretty=oneline :)

Regards,

Tony

> ---
>  arch/arm/boot/dts/omap3-gta04.dts | 15 +++++++++++++++
>  1 file changed, 15 insertions(+)
> 
> diff --git a/arch/arm/boot/dts/omap3-gta04.dts b/arch/arm/boot/dts/omap3-gta04.dts
> index 7e09410..a924a843 100644
> --- a/arch/arm/boot/dts/omap3-gta04.dts
> +++ b/arch/arm/boot/dts/omap3-gta04.dts
> @@ -36,6 +36,14 @@
>  			gpio-key,wakeup;
>  		};
>  	};
> +
> +	sound {
> +		compatible = "ti,omap-twl4030";
> +		ti,model = "gta04";
> +
> +		ti,mcbsp = <&mcbsp2>;
> +		ti,codec = <&twl_audio>;
> +	};
>  };
>  
>  &omap3_pmx_core {
> @@ -79,6 +87,13 @@
>  		reg = <0x48>;
>  		interrupts = <7>; /* SYS_NIRQ cascaded to intc */
>  		interrupt-parent = <&intc>;
> +
> +		twl_audio: audio {
> +			compatible = "ti,twl4030-audio";
> +			codec {
> +			};
> +		};
> +
>  		vaux4: regulator-vaux4 {
>  			compatible = "ti,twl4030-vaux4";
>  			regulator-min-microvolt = <2800000>;
> -- 
> 1.8.3.2
> 

  reply	other threads:[~2014-02-28 22:25 UTC|newest]

Thread overview: 32+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-01-25 21:28 [PATCH 0/9] ARM: dts: omap3-gta04: Various devicetree updates Marek Belisko
2014-01-25 21:28 ` Marek Belisko
2014-01-25 21:28 ` Marek Belisko
2014-01-25 21:28 ` [PATCH 1/9] ARM: dts: omap3-gta04: Fix 'aux' gpio key flags Marek Belisko
2014-01-25 21:28   ` Marek Belisko
2014-02-13 23:08   ` Tony Lindgren
2014-02-13 23:08     ` Tony Lindgren
2014-01-25 21:28 ` [PATCH 2/9] ARM: dts: omap3-gta04: Add bma180 accelerometer Marek Belisko
2014-01-25 21:28   ` Marek Belisko
2014-01-25 21:28 ` [PATCH 3/9] ARM: dts: omap3-gta04: Fix mmc1 properties Marek Belisko
2014-01-25 21:28   ` Marek Belisko
2014-02-13 23:08   ` Tony Lindgren
2014-02-13 23:08     ` Tony Lindgren
2014-01-25 21:28 ` [PATCH 4/9] ARM: dts: omap3-gta04: Enable mmc2 for wifi Marek Belisko
2014-01-25 21:28   ` Marek Belisko
2014-01-25 21:28 ` [PATCH 5/9] ARM: dts: omap3-gta04: Add basic sound support Marek Belisko
2014-01-25 21:28   ` Marek Belisko
2014-02-28 22:25   ` Tony Lindgren [this message]
2014-02-28 22:25     ` Tony Lindgren
2014-02-28 22:40     ` Belisko Marek
2014-02-28 22:40       ` Belisko Marek
     [not found]       ` <CAAfyv34Agdabr3eg1VS9mHmTtefHf3HQrS6CWF4D9jkp2fEqzA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-02-28 22:46         ` Tony Lindgren
2014-02-28 22:46           ` Tony Lindgren
2014-02-28 22:46           ` Tony Lindgren
2014-01-25 21:29 ` [PATCH 6/9] ARM: dts: omap3-gta04: Add twl4030 charger Marek Belisko
2014-01-25 21:29   ` Marek Belisko
2014-01-25 21:29 ` [PATCH 7/9] ARM: dts: omap3-gta04: Add touchscreen properties Marek Belisko
2014-01-25 21:29   ` Marek Belisko
2014-01-25 21:29 ` [PATCH 8/9] ARM: dts: omap3-gta04: Add support for magnetometer Marek Belisko
2014-01-25 21:29   ` Marek Belisko
2014-01-25 21:29 ` [PATCH 9/9] ARM: dts: omap3-gta04: Add ti,omap36xx to compatible property to avoid problems with booting Marek Belisko
2014-01-25 21:29   ` [PATCH 9/9] ARM: dts: omap3-gta04: Add ti, omap36xx " Marek Belisko

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140228222501.GL13624@atomide.com \
    --to=tony@atomide.com \
    --cc=bcousson@baylibre.com \
    --cc=devicetree@vger.kernel.org \
    --cc=galak@codeaurora.org \
    --cc=hns@goldelico.com \
    --cc=ijc+devicetree@hellion.org.uk \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-omap@vger.kernel.org \
    --cc=linux@arm.linux.org.uk \
    --cc=marek@goldelico.com \
    --cc=mark.rutland@arm.com \
    --cc=neilb@suse.de \
    --cc=pawel.moll@arm.com \
    --cc=robh+dt@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.