All of lore.kernel.org
 help / color / mirror / Atom feed
From: maxime.ripard@free-electrons.com (Maxime Ripard)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 3/3] ARM: sun7i/sun6i: irqchip: Update the documentation
Date: Mon, 3 Mar 2014 12:02:40 +0100	[thread overview]
Message-ID: <20140303110240.GW607@lukather> (raw)
In-Reply-To: <1393529662-8663-4-git-send-email-carlo@caione.org>

Hi,

On Thu, Feb 27, 2014 at 08:34:22PM +0100, Carlo Caione wrote:
> Added documentation for NMI irqchip.
> 
> Signed-off-by: Carlo Caione <carlo@caione.org>
> ---
>  .../allwinner,sun67i-sc-nmi.txt                    | 27 ++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/allwinner,sun67i-sc-nmi.txt
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun67i-sc-nmi.txt b/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun67i-sc-nmi.txt
> new file mode 100644
> index 0000000..ac31487
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun67i-sc-nmi.txt
> @@ -0,0 +1,27 @@
> +Allwinner Sunxi NMI Controller
> +==============================
> +
> +Required properties:
> +
> +- compatible : should be "allwinner,sun7i-a20-sc-nmi" or
> +  "allwinner,sun6i-a31-sc-nmi"
> +- reg : Specifies base physical address and size of the registers.
> +- interrupt-controller : Identifies the node as an interrupt controller
> +- #interrupt-cells : Specifies the number of cells needed to encode an
> +  interrupt source. The value shall be 2. The first cell is the IRQ number, the
> +  second cell the trigger type.

What values correspond to what trigger type? What are the accepted values?

> +- interrupt-parent: Specifies the parent interrupt controller.
> +- interrupts: Specifies the list of interrupt lines which are handled by
> +  the interrupt controller in the parent controller's notation. This value
> +  shall be the NMI.

Hmmm, there's only one interrupt, not a list of them.

> +
> +Example:
> +
> +sc-nmi-intc at 01c00030 {
> +	compatible = "allwinner,sun7i-a20-sc-nmi";
> +	interrupt-controller;
> +	#interrupt-cells = <2>;
> +	reg = <0x01c00030 0x0c>;
> +	interrupt-parent = <&gic>;
> +	interrupts = <0 0 4>;
> +};
> -- 
> 1.8.3.2
> 

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140303/96759468/attachment.sig>

WARNING: multiple messages have this Message-ID (diff)
From: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
To: Carlo Caione <carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>
Cc: linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
	linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
	mark.rutland-5wv7dgnIgG8@public.gmane.org,
	hdegoede-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org,
	tglx-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org,
	devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH v4 3/3] ARM: sun7i/sun6i: irqchip: Update the documentation
Date: Mon, 3 Mar 2014 12:02:40 +0100	[thread overview]
Message-ID: <20140303110240.GW607@lukather> (raw)
In-Reply-To: <1393529662-8663-4-git-send-email-carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 2126 bytes --]

Hi,

On Thu, Feb 27, 2014 at 08:34:22PM +0100, Carlo Caione wrote:
> Added documentation for NMI irqchip.
> 
> Signed-off-by: Carlo Caione <carlo-KA+7E9HrN00dnm+yROfE0A@public.gmane.org>
> ---
>  .../allwinner,sun67i-sc-nmi.txt                    | 27 ++++++++++++++++++++++
>  1 file changed, 27 insertions(+)
>  create mode 100644 Documentation/devicetree/bindings/interrupt-controller/allwinner,sun67i-sc-nmi.txt
> 
> diff --git a/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun67i-sc-nmi.txt b/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun67i-sc-nmi.txt
> new file mode 100644
> index 0000000..ac31487
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/interrupt-controller/allwinner,sun67i-sc-nmi.txt
> @@ -0,0 +1,27 @@
> +Allwinner Sunxi NMI Controller
> +==============================
> +
> +Required properties:
> +
> +- compatible : should be "allwinner,sun7i-a20-sc-nmi" or
> +  "allwinner,sun6i-a31-sc-nmi"
> +- reg : Specifies base physical address and size of the registers.
> +- interrupt-controller : Identifies the node as an interrupt controller
> +- #interrupt-cells : Specifies the number of cells needed to encode an
> +  interrupt source. The value shall be 2. The first cell is the IRQ number, the
> +  second cell the trigger type.

What values correspond to what trigger type? What are the accepted values?

> +- interrupt-parent: Specifies the parent interrupt controller.
> +- interrupts: Specifies the list of interrupt lines which are handled by
> +  the interrupt controller in the parent controller's notation. This value
> +  shall be the NMI.

Hmmm, there's only one interrupt, not a list of them.

> +
> +Example:
> +
> +sc-nmi-intc@01c00030 {
> +	compatible = "allwinner,sun7i-a20-sc-nmi";
> +	interrupt-controller;
> +	#interrupt-cells = <2>;
> +	reg = <0x01c00030 0x0c>;
> +	interrupt-parent = <&gic>;
> +	interrupts = <0 0 4>;
> +};
> -- 
> 1.8.3.2
> 

Thanks!
Maxime

-- 
Maxime Ripard, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

  reply	other threads:[~2014-03-03 11:02 UTC|newest]

Thread overview: 14+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-02-27 19:34 [PATCH v4 0/3] ARM: sun7i/sun6i: irqchip: Irqchip driver for NMI Carlo Caione
2014-02-27 19:34 ` Carlo Caione
2014-02-27 19:34 ` [PATCH v4 1/3] ARM: sun7i/sun6i: irqchip: Add irqchip driver for NMI controller Carlo Caione
2014-02-27 19:34   ` Carlo Caione
2014-03-03 10:55   ` Maxime Ripard
2014-03-03 10:55     ` Maxime Ripard
2014-02-27 19:34 ` [PATCH v4 2/3] ARM: sun7i/sun6i: dts: Add NMI irqchip support Carlo Caione
2014-02-27 19:34   ` Carlo Caione
2014-02-27 19:34 ` [PATCH v4 3/3] ARM: sun7i/sun6i: irqchip: Update the documentation Carlo Caione
2014-02-27 19:34   ` Carlo Caione
2014-03-03 11:02   ` Maxime Ripard [this message]
2014-03-03 11:02     ` Maxime Ripard
2014-03-03 13:37     ` [linux-sunxi] " Carlo Caione
2014-03-03 13:37       ` Carlo Caione

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140303110240.GW607@lukather \
    --to=maxime.ripard@free-electrons.com \
    --cc=linux-arm-kernel@lists.infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.