spear-cpufreq + multiplatform?

spear-cpufreq + multiplatform?

[Josh Cartwright]

Hey folks-

I noticed booting today's next on a non-spear platform, that I'm seeing
the following in my logs:

	[    2.126494] spear_cpufreq: Invalid cpufreq_tbl

Looking closer, it looks like the spear-cpufreq driver has a
late_initcall() that's not too multiplatform friendly.  Perhaps the
spear cpufreq initialization routine should be called explicitly from
some platform-specific code, or explicitly check to ensure it's running
on SPEAr?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

spear-cpufreq + multiplatform?

[Josh Cartwright]

Hey folks-

I noticed booting today's next on a non-spear platform, that I'm seeing
the following in my logs:

	[    2.126494] spear_cpufreq: Invalid cpufreq_tbl

Looking closer, it looks like the spear-cpufreq driver has a
late_initcall() that's not too multiplatform friendly.  Perhaps the
spear cpufreq initialization routine should be called explicitly from
some platform-specific code, or explicitly check to ensure it's running
on SPEAr?

-- 
Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
hosted by The Linux Foundation

Re: spear-cpufreq + multiplatform?

[Rob Herring]

On Mon, Mar 3, 2014 at 12:08 PM, Josh Cartwright <joshc@codeaurora.org> wrote:
> Hey folks-
>
> I noticed booting today's next on a non-spear platform, that I'm seeing
> the following in my logs:
>
>         [    2.126494] spear_cpufreq: Invalid cpufreq_tbl
>
> Looking closer, it looks like the spear-cpufreq driver has a
> late_initcall() that's not too multiplatform friendly.  Perhaps the
> spear cpufreq initialization routine should be called explicitly from
> some platform-specific code, or explicitly check to ensure it's running
> on SPEAr?

Yes, I've seen this on 3.14 as well.

There are also less harmful driver printk's for drivers where the
device is not present. Serial and EHCI drivers are the main culprits.

Rob

>
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> hosted by The Linux Foundation
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel@lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

spear-cpufreq + multiplatform?

[Rob Herring]

On Mon, Mar 3, 2014 at 12:08 PM, Josh Cartwright <joshc@codeaurora.org> wrote:
> Hey folks-
>
> I noticed booting today's next on a non-spear platform, that I'm seeing
> the following in my logs:
>
>         [    2.126494] spear_cpufreq: Invalid cpufreq_tbl
>
> Looking closer, it looks like the spear-cpufreq driver has a
> late_initcall() that's not too multiplatform friendly.  Perhaps the
> spear cpufreq initialization routine should be called explicitly from
> some platform-specific code, or explicitly check to ensure it's running
> on SPEAr?

Yes, I've seen this on 3.14 as well.

There are also less harmful driver printk's for drivers where the
device is not present. Serial and EHCI drivers are the main culprits.

Rob

>
> --
> Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum,
> hosted by The Linux Foundation
>
> _______________________________________________
> linux-arm-kernel mailing list
> linux-arm-kernel at lists.infradead.org
> http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

Re: spear-cpufreq + multiplatform?

[Viresh Kumar]

On Tue, Mar 4, 2014 at 2:08 AM, Josh Cartwright <joshc@codeaurora.org> wrote:
> Hey folks-
>
> I noticed booting today's next on a non-spear platform, that I'm seeing
> the following in my logs:
>
>         [    2.126494] spear_cpufreq: Invalid cpufreq_tbl
>
> Looking closer, it looks like the spear-cpufreq driver has a
> late_initcall() that's not too multiplatform friendly.  Perhaps the
> spear cpufreq initialization routine should be called explicitly from
> some platform-specific code, or explicitly check to ensure it's running
> on SPEAr?

So sorry for that. I can't get it fixed right now as am busy with some
conferences but will mark that in my todo list. Thanks for reporting it.

spear-cpufreq + multiplatform?

[Viresh Kumar]

On Tue, Mar 4, 2014 at 2:08 AM, Josh Cartwright <joshc@codeaurora.org> wrote:
> Hey folks-
>
> I noticed booting today's next on a non-spear platform, that I'm seeing
> the following in my logs:
>
>         [    2.126494] spear_cpufreq: Invalid cpufreq_tbl
>
> Looking closer, it looks like the spear-cpufreq driver has a
> late_initcall() that's not too multiplatform friendly.  Perhaps the
> spear cpufreq initialization routine should be called explicitly from
> some platform-specific code, or explicitly check to ensure it's running
> on SPEAr?

So sorry for that. I can't get it fixed right now as am busy with some
conferences but will mark that in my todo list. Thanks for reporting it.