All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denys@ti.com>
To: Sam Nelson <sam.nelson@ti.com>
Cc: meta-arago@arago-project.org
Subject: Re: [PATCH] initscripts: Add mkdir debugfs and mount
Date: Mon, 3 Mar 2014 21:46:28 -0500	[thread overview]
Message-ID: <20140304024628.GX22125@edge> (raw)
In-Reply-To: <1393879945-11703-1-git-send-email-sam.nelson@ti.com>

On Mon, Mar 03, 2014 at 03:52:25PM -0500, Sam Nelson wrote:
> - Add script to create /debug directory and mount debugfs
> 
> Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> ---
>  .../recipes-core/initscripts/files/debugfs.sh      |    8 ++++++++
>  .../initscripts/initscripts_1.0.bbappend           |    8 ++++++++
>  2 files changed, 16 insertions(+)
>  create mode 100755 meta-arago-distro/recipes-core/initscripts/files/debugfs.sh
>  create mode 100644 meta-arago-distro/recipes-core/initscripts/initscripts_1.0.bbappend
> 
> diff --git a/meta-arago-distro/recipes-core/initscripts/files/debugfs.sh b/meta-arago-distro/recipes-core/initscripts/files/debugfs.sh
> new file mode 100755
> index 0000000..17e2474
> --- /dev/null
> +++ b/meta-arago-distro/recipes-core/initscripts/files/debugfs.sh
> @@ -0,0 +1,8 @@
> +#!/bin/sh
> +
> +if ! [ -e /debug ] ; then
> +  mkdir -p /debug
> +fi
> +mount -t debugfs debugfs /debug

Why /debug? The convention is to use /sys/kernel/debug as a mount point for 
debugfs...


> +
> +exit 0
> diff --git a/meta-arago-distro/recipes-core/initscripts/initscripts_1.0.bbappend b/meta-arago-distro/recipes-core/initscripts/initscripts_1.0.bbappend
> new file mode 100644
> index 0000000..1d78ab3
> --- /dev/null
> +++ b/meta-arago-distro/recipes-core/initscripts/initscripts_1.0.bbappend
> @@ -0,0 +1,8 @@
> +FILESEXTRAPATHS_append := "${THISDIR}/files"
> +
> +SRC_URI += "file://debugfs.sh"
> +
> +do_install_append () {
> +	install -c -m 755 ${WORKDIR}/debugfs.sh ${D}${sysconfdir}/init.d/debugfs.sh
> +	update-rc.d -r ${D} devpts.sh start 09 S .

^^^^ copy/paste error - it still says devpts.sh here instead of debugfs.sh :)


Anyway, can you just add it to /etc/fstab? And if you use the default 
/sys/kernel/debug mount point, you won't need to pre-create it. But you 
may need to make sure /sys is mounted... Anyway, take a look at our 
base-files.bbappend in meta-arago-distro. Thanks.

-- 
Denys


  reply	other threads:[~2014-03-04  2:46 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-03 20:52 [PATCH] initscripts: Add mkdir debugfs and mount Sam Nelson
2014-03-04  2:46 ` Denys Dmytriyenko [this message]
2014-03-04 16:39   ` Nelson, Sam

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140304024628.GX22125@edge \
    --to=denys@ti.com \
    --cc=meta-arago@arago-project.org \
    --cc=sam.nelson@ti.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.