[PATCH] initscripts: Add mkdir debugfs and mount

[PATCH] initscripts: Add mkdir debugfs and mount

[Sam Nelson]

- Add script to create /debug directory and mount debugfs

Signed-off-by: Sam Nelson <sam.nelson@ti.com>
---
 .../recipes-core/initscripts/files/debugfs.sh      |    8 ++++++++
 .../initscripts/initscripts_1.0.bbappend           |    8 ++++++++
 2 files changed, 16 insertions(+)
 create mode 100755 meta-arago-distro/recipes-core/initscripts/files/debugfs.sh
 create mode 100644 meta-arago-distro/recipes-core/initscripts/initscripts_1.0.bbappend

diff --git a/meta-arago-distro/recipes-core/initscripts/files/debugfs.sh b/meta-arago-distro/recipes-core/initscripts/files/debugfs.sh
new file mode 100755
index 0000000..17e2474
--- /dev/null
+++ b/meta-arago-distro/recipes-core/initscripts/files/debugfs.sh
@@ -0,0 +1,8 @@
+#!/bin/sh
+
+if ! [ -e /debug ] ; then
+  mkdir -p /debug
+fi
+mount -t debugfs debugfs /debug
+
+exit 0
diff --git a/meta-arago-distro/recipes-core/initscripts/initscripts_1.0.bbappend b/meta-arago-distro/recipes-core/initscripts/initscripts_1.0.bbappend
new file mode 100644
index 0000000..1d78ab3
--- /dev/null
+++ b/meta-arago-distro/recipes-core/initscripts/initscripts_1.0.bbappend
@@ -0,0 +1,8 @@
+FILESEXTRAPATHS_append := "${THISDIR}/files"
+
+SRC_URI += "file://debugfs.sh"
+
+do_install_append () {
+	install -c -m 755 ${WORKDIR}/debugfs.sh ${D}${sysconfdir}/init.d/debugfs.sh
+	update-rc.d -r ${D} devpts.sh start 09 S .
+}
-- 
1.7.9.5

Re: [PATCH] initscripts: Add mkdir debugfs and mount

[Denys Dmytriyenko]

On Mon, Mar 03, 2014 at 03:52:25PM -0500, Sam Nelson wrote:
> - Add script to create /debug directory and mount debugfs
> 
> Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> ---
>  .../recipes-core/initscripts/files/debugfs.sh      |    8 ++++++++
>  .../initscripts/initscripts_1.0.bbappend           |    8 ++++++++
>  2 files changed, 16 insertions(+)
>  create mode 100755 meta-arago-distro/recipes-core/initscripts/files/debugfs.sh
>  create mode 100644 meta-arago-distro/recipes-core/initscripts/initscripts_1.0.bbappend
> 
> diff --git a/meta-arago-distro/recipes-core/initscripts/files/debugfs.sh b/meta-arago-distro/recipes-core/initscripts/files/debugfs.sh
> new file mode 100755
> index 0000000..17e2474
> --- /dev/null
> +++ b/meta-arago-distro/recipes-core/initscripts/files/debugfs.sh
> @@ -0,0 +1,8 @@
> +#!/bin/sh
> +
> +if ! [ -e /debug ] ; then
> +  mkdir -p /debug
> +fi
> +mount -t debugfs debugfs /debug

Why /debug? The convention is to use /sys/kernel/debug as a mount point for 
debugfs...


> +
> +exit 0
> diff --git a/meta-arago-distro/recipes-core/initscripts/initscripts_1.0.bbappend b/meta-arago-distro/recipes-core/initscripts/initscripts_1.0.bbappend
> new file mode 100644
> index 0000000..1d78ab3
> --- /dev/null
> +++ b/meta-arago-distro/recipes-core/initscripts/initscripts_1.0.bbappend
> @@ -0,0 +1,8 @@
> +FILESEXTRAPATHS_append := "${THISDIR}/files"
> +
> +SRC_URI += "file://debugfs.sh"
> +
> +do_install_append () {
> +	install -c -m 755 ${WORKDIR}/debugfs.sh ${D}${sysconfdir}/init.d/debugfs.sh
> +	update-rc.d -r ${D} devpts.sh start 09 S .

^^^^ copy/paste error - it still says devpts.sh here instead of debugfs.sh :)


Anyway, can you just add it to /etc/fstab? And if you use the default 
/sys/kernel/debug mount point, you won't need to pre-create it. But you 
may need to make sure /sys is mounted... Anyway, take a look at our 
base-files.bbappend in meta-arago-distro. Thanks.

-- 
Denys

Re: [PATCH] initscripts: Add mkdir debugfs and mount

[Nelson, Sam]

> -----Original Message-----
> From: Dmytriyenko, Denys
> Sent: Monday, March 03, 2014 9:46 PM
> To: Nelson, Sam
> Cc: meta-arago@arago-project.org
> Subject: Re: [meta-arago] [PATCH] initscripts: Add mkdir debugfs and mount
> 
> On Mon, Mar 03, 2014 at 03:52:25PM -0500, Sam Nelson wrote:
> > - Add script to create /debug directory and mount debugfs
> >
> > Signed-off-by: Sam Nelson <sam.nelson@ti.com>
> > ---
> >  .../recipes-core/initscripts/files/debugfs.sh      |    8 ++++++++
> >  .../initscripts/initscripts_1.0.bbappend           |    8 ++++++++
> >  2 files changed, 16 insertions(+)
> >  create mode 100755 meta-arago-distro/recipes-
> core/initscripts/files/debugfs.sh
> >  create mode 100644 meta-arago-distro/recipes-
> core/initscripts/initscripts_1.0.bbappend
> >
> > diff --git a/meta-arago-distro/recipes-core/initscripts/files/debugfs.sh
> b/meta-arago-distro/recipes-core/initscripts/files/debugfs.sh
> > new file mode 100755
> > index 0000000..17e2474
> > --- /dev/null
> > +++ b/meta-arago-distro/recipes-core/initscripts/files/debugfs.sh
> > @@ -0,0 +1,8 @@
> > +#!/bin/sh
> > +
> > +if ! [ -e /debug ] ; then
> > +  mkdir -p /debug
> > +fi
> > +mount -t debugfs debugfs /debug
> 
> Why /debug? The convention is to use /sys/kernel/debug as a mount point
> for
> debugfs...
> 
[Sam] Ok.   Actually the mount to  /sys/kernel/debug should suffice. I think we don't need this. 
No need for this commit.
> 
> > +
> > +exit 0
> > diff --git a/meta-arago-distro/recipes-
> core/initscripts/initscripts_1.0.bbappend b/meta-arago-distro/recipes-
> core/initscripts/initscripts_1.0.bbappend
> > new file mode 100644
> > index 0000000..1d78ab3
> > --- /dev/null
> > +++ b/meta-arago-distro/recipes-core/initscripts/initscripts_1.0.bbappend
> > @@ -0,0 +1,8 @@
> > +FILESEXTRAPATHS_append := "${THISDIR}/files"
> > +
> > +SRC_URI += "file://debugfs.sh"
> > +
> > +do_install_append () {
> > +	install -c -m 755 ${WORKDIR}/debugfs.sh
> ${D}${sysconfdir}/init.d/debugfs.sh
> > +	update-rc.d -r ${D} devpts.sh start 09 S .
> 
> ^^^^ copy/paste error - it still says devpts.sh here instead of debugfs.sh :)
> 
> 
> Anyway, can you just add it to /etc/fstab? And if you use the default
> /sys/kernel/debug mount point, you won't need to pre-create it. But you
> may need to make sure /sys is mounted... Anyway, take a look at our
> base-files.bbappend in meta-arago-distro. Thanks.
> 
> --
> Denys