* [PATCH] IOMMU: iommu module do not check NULL return of kmem_cache_zalloc
@ 2014-02-11 2:12 ` Zhouyi Zhou
0 siblings, 0 replies; 4+ messages in thread
From: Zhouyi Zhou @ 2014-02-11 2:12 UTC (permalink / raw)
To: Joerg Roedel, iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA
Cc: Zhouyi Zhou
From: Zhouyi Zhou <yizhouzhou-6xnC4QlcT6v/PtFMR13I2A@public.gmane.org>
The function iopte_alloc do not check NULL return of kmem_cache_zalloc,
call iopte_free with argument 0 will panic.
Signed-off-by: Zhouyi Zhou <yizhouzhou-6xnC4QlcT6v/PtFMR13I2A@public.gmane.org>
---
drivers/iommu/omap-iommu.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
index bcd78a7..5155714 100644
--- a/drivers/iommu/omap-iommu.c
+++ b/drivers/iommu/omap-iommu.c
@@ -551,7 +551,8 @@ static u32 *iopte_alloc(struct omap_iommu *obj, u32 *iopgd, u32 da)
dev_vdbg(obj->dev, "%s: a new pte:%p\n", __func__, iopte);
} else {
/* We raced, free the reduniovant table */
- iopte_free(iopte);
+ if (iopte)
+ iopte_free(iopte);
}
pte_ready:
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread* [PATCH] IOMMU: iommu module do not check NULL return of kmem_cache_zalloc
@ 2014-02-11 2:12 ` Zhouyi Zhou
0 siblings, 0 replies; 4+ messages in thread
From: Zhouyi Zhou @ 2014-02-11 2:12 UTC (permalink / raw)
To: Joerg Roedel, iommu, linux-kernel; +Cc: Zhouyi Zhou
From: Zhouyi Zhou <yizhouzhou@ict.ac.cn>
The function iopte_alloc do not check NULL return of kmem_cache_zalloc,
call iopte_free with argument 0 will panic.
Signed-off-by: Zhouyi Zhou <yizhouzhou@ict.ac.cn>
---
drivers/iommu/omap-iommu.c | 3 ++-
1 file changed, 2 insertions(+), 1 deletion(-)
diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
index bcd78a7..5155714 100644
--- a/drivers/iommu/omap-iommu.c
+++ b/drivers/iommu/omap-iommu.c
@@ -551,7 +551,8 @@ static u32 *iopte_alloc(struct omap_iommu *obj, u32 *iopgd, u32 da)
dev_vdbg(obj->dev, "%s: a new pte:%p\n", __func__, iopte);
} else {
/* We raced, free the reduniovant table */
- iopte_free(iopte);
+ if (iopte)
+ iopte_free(iopte);
}
pte_ready:
--
1.7.10.4
^ permalink raw reply related [flat|nested] 4+ messages in thread[parent not found: <1392084773-16843-1-git-send-email-zhouzhouyi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>]
* Re: [PATCH] IOMMU: iommu module do not check NULL return of kmem_cache_zalloc
2014-02-11 2:12 ` Zhouyi Zhou
@ 2014-03-04 15:41 ` Joerg Roedel
-1 siblings, 0 replies; 4+ messages in thread
From: Joerg Roedel @ 2014-03-04 15:41 UTC (permalink / raw)
To: Zhouyi Zhou
Cc: iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA,
linux-kernel-u79uwXL29TY76Z2rM5mHXA, Zhouyi Zhou
On Tue, Feb 11, 2014 at 10:12:53AM +0800, Zhouyi Zhou wrote:
> From: Zhouyi Zhou <yizhouzhou-6xnC4QlcT6v/PtFMR13I2A@public.gmane.org>
>
> The function iopte_alloc do not check NULL return of kmem_cache_zalloc,
> call iopte_free with argument 0 will panic.
>
> Signed-off-by: Zhouyi Zhou <yizhouzhou-6xnC4QlcT6v/PtFMR13I2A@public.gmane.org>
> ---
> drivers/iommu/omap-iommu.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
> index bcd78a7..5155714 100644
> --- a/drivers/iommu/omap-iommu.c
> +++ b/drivers/iommu/omap-iommu.c
> @@ -551,7 +551,8 @@ static u32 *iopte_alloc(struct omap_iommu *obj, u32 *iopgd, u32 da)
> dev_vdbg(obj->dev, "%s: a new pte:%p\n", __func__, iopte);
> } else {
> /* We raced, free the reduniovant table */
> - iopte_free(iopte);
> + if (iopte)
> + iopte_free(iopte);
Isn't it better to put the check into iopte_free?
Joerg
^ permalink raw reply [flat|nested] 4+ messages in thread* Re: [PATCH] IOMMU: iommu module do not check NULL return of kmem_cache_zalloc
@ 2014-03-04 15:41 ` Joerg Roedel
0 siblings, 0 replies; 4+ messages in thread
From: Joerg Roedel @ 2014-03-04 15:41 UTC (permalink / raw)
To: Zhouyi Zhou; +Cc: iommu, linux-kernel, Zhouyi Zhou
On Tue, Feb 11, 2014 at 10:12:53AM +0800, Zhouyi Zhou wrote:
> From: Zhouyi Zhou <yizhouzhou@ict.ac.cn>
>
> The function iopte_alloc do not check NULL return of kmem_cache_zalloc,
> call iopte_free with argument 0 will panic.
>
> Signed-off-by: Zhouyi Zhou <yizhouzhou@ict.ac.cn>
> ---
> drivers/iommu/omap-iommu.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/iommu/omap-iommu.c b/drivers/iommu/omap-iommu.c
> index bcd78a7..5155714 100644
> --- a/drivers/iommu/omap-iommu.c
> +++ b/drivers/iommu/omap-iommu.c
> @@ -551,7 +551,8 @@ static u32 *iopte_alloc(struct omap_iommu *obj, u32 *iopgd, u32 da)
> dev_vdbg(obj->dev, "%s: a new pte:%p\n", __func__, iopte);
> } else {
> /* We raced, free the reduniovant table */
> - iopte_free(iopte);
> + if (iopte)
> + iopte_free(iopte);
Isn't it better to put the check into iopte_free?
Joerg
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2014-03-04 15:41 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-02-11 2:12 [PATCH] IOMMU: iommu module do not check NULL return of kmem_cache_zalloc Zhouyi Zhou
2014-02-11 2:12 ` Zhouyi Zhou
[not found] ` <1392084773-16843-1-git-send-email-zhouzhouyi-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-03-04 15:41 ` Joerg Roedel
2014-03-04 15:41 ` Joerg Roedel
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.