Re: [meta-qt5][PATCH v4 2/2] packagegroup-qt5-toolchain-target: include all modules for development

[Denys Dmytriyenko <denis@denix.org>]

On Sun, Mar 02, 2014 at 03:22:45PM +1100, Jonathan Liu wrote:
> This adds the necessary target packages for development with all of the
> Qt 5 modules.
> 
> Signed-off-by: Jonathan Liu <net147@gmail.com>
> ---
>  .../packagegroup-qt5-toolchain-target.bb           | 80 ++++++++++++++++++----
>  1 file changed, 65 insertions(+), 15 deletions(-)
> 
> diff --git a/recipes-qt/packagegroups/packagegroup-qt5-toolchain-target.bb b/recipes-qt/packagegroups/packagegroup-qt5-toolchain-target.bb
> index 997df18..25983dc 100644
> --- a/recipes-qt/packagegroups/packagegroup-qt5-toolchain-target.bb
> +++ b/recipes-qt/packagegroups/packagegroup-qt5-toolchain-target.bb
> @@ -9,32 +9,82 @@ PACKAGEGROUP_DISABLE_COMPLEMENTARY = "1"
>  
>  # Requires meta-ruby to work
>  USE_RUBY = " \
> -    qtwebkit-mkspecs \
>      qtwebkit-dev \
> +    qtwebkit-mkspecs \
> +    qtwebkit-qmlplugins \
> +"
> +
> +# Requires Wayland to work
> +USE_WAYLAND = " \
> +    qtwayland-dev \
> +    qtwayland-mkspecs \
> +    qtwayland-plugins \
> +    qtwayland-tools \
> +"
> +
> +# Requires X11 to work
> +USE_X11 = " \
> +    qtx11extras-dev \
> +    qtx11extras-mkspecs \
>  "
>  
>  RDEPENDS_${PN} += " \
>      packagegroup-core-standalone-sdk-target \
>      libsqlite3-dev \
> -    qtbase-mkspecs \
> -    qtscript-mkspecs \
> -    qtxmlpatterns-mkspecs \
> -    qtdeclarative-mkspecs \
> -    qtsensors-mkspecs \
> +    qt3d-dev \
>      qt3d-mkspecs \
> -    qtlocation-mkspecs \
> -    qtsvg-mkspecs \
> +    qt3d-qmlplugins \
>      qtbase-dev \
> +    qtbase-fonts \
> +    qtbase-mkspecs \
> +    qtbase-plugins \
> +    qtbase-staticdev \
> +    qtconnectivity-dev \
> +    qtconnectivity-mkspecs \
> +    qtconnectivity-qmlplugins \
>      qtdeclarative-dev \
> -    qtscript-dev \
> -    qt3d-dev \
> +    qtdeclarative-mkspecs \
> +    qtdeclarative-plugins \
> +    qtdeclarative-qmlplugins \
> +    qtdeclarative-staticdev \
> +    qtgraphicaleffects-qmlplugins \
> +    qtimageformats-dev \
> +    qtimageformats-plugins \
>      qtlocation-dev \
> +    qtlocation-mkspecs \
> +    qtlocation-plugins \
> +    qtlocation-qmlplugins \
> +    qtmultimedia-dev \
> +    qtmultimedia-mkspecs \
> +    qtmultimedia-plugins \
> +    qtmultimedia-qmlplugins \
> +    qtquick1-dev \
> +    qtquick1-mkspecs \
> +    qtquick1-plugins \
> +    qtquick1-qmlplugins \
> +    qtquickcontrols-qmlplugins \
> +    qtscript-dev \
> +    qtscript-mkspecs \
>      qtsensors-dev \
> +    qtsensors-mkspecs \
> +    qtsensors-plugins \
> +    qtsensors-qmlplugins \
> +    qtserialport-dev \
> +    qtserialport-mkspecs \
>      qtsvg-dev \
> -    qtxmlpatterns-dev \
> -    qtdeclarative-dev \
> -    qtdeclarative-plugins \
> -    qtdeclarative-qmlplugins \
> -    qtgraphicaleffects-dev \
> +    qtsvg-mkspecs \
> +    qtsvg-plugins \
> +    qtsystems-dev \
> +    qtsystems-mkspecs \
> +    qtsystems-qmlplugins \
> +    qttools-dev \
> +    qttools-mkspecs \
> +    qttools-plugins \
> +    qttools-staticdev \
> +    qttools-tools \
> +    ${@base_contains('DISTRO_FEATURES', 'wayland', '${USE_WAYLAND}', '', d)} \
>      ${@base_contains('BBFILE_COLLECTIONS', 'ruby-layer', '${USE_RUBY}', '', d)} \
> +    ${@base_contains('DISTRO_FEATURES', 'x11', '${USE_X11}', '', d)} \

Like I said in v2 comment - I like the conditionals here. Can we possibly make 
other modules as conditionals as well? I.e. qt3d or qtwebkit when they are not 
built for the target?

-- 
Denys


> +    qtxmlpatterns-dev \
> +    qtxmlpatterns-mkspecs \
>  "
> -- 
> 1.9.0
> 
> _______________________________________________
> Openembedded-devel mailing list
> Openembedded-devel@lists.openembedded.org
> http://lists.openembedded.org/mailman/listinfo/openembedded-devel