Re: [meta-qt5][PATCH v4 2/2] packagegroup-qt5-toolchain-target: include all modules for development

[Jonathan Liu <net147@gmail.com>]

On 13/03/2014 9:37 AM, Otavio Salvador wrote:
> Hello,
>
> On Wed, Mar 12, 2014 at 6:03 PM, Jonathan Liu <net147@gmail.com> wrote:
>> On 13/03/2014 5:42 AM, Otavio Salvador wrote:
>>> On Tue, Mar 11, 2014 at 8:39 AM, Jonathan Liu <net147@gmail.com> wrote:
>>>> On 5/03/2014 1:34 AM, Otavio Salvador wrote:
>>>>> On Tue, Mar 4, 2014 at 12:43 AM, Jonathan Liu <net147@gmail.com> wrote:
>>>>>> On 4 March 2014 06:53, Otavio Salvador <otavio@ossystems.com.br> wrote:
>>>>>>> On Sun, Mar 2, 2014 at 1:22 AM, Jonathan Liu <net147@gmail.com> wrote:
>>>>>>>> This adds the necessary target packages for development with all of
>>>>>>>> the
>>>>>>>> Qt 5 modules.
>>>>>>>>
>>>>>>>> Signed-off-by: Jonathan Liu <net147@gmail.com>
>>>>>>> Why are you adding qttools here? this is not need for toolchain use,
>>>>>>> is it? It is need for host.
>>>>>> The QtTools module includes components that may be used by
>>>>>> applications - http://qt-project.org/doc/qt-5/qtmodules.html#qt-tools
>>>>>    From the doc it is not clear to me how it will be used in the target,
>>>>> it seems something used in host.
>>>>>
>>>>> Could you help me to understand your reasoning for it?
>>>>>
>>>> It includes Qt Help which is used to implement context-sensitive help to
>>>> the
>>>> user in Qt applications.
>>> I am fine with it than; do you have any other change pending? please
>>> let me know or I pick v2 of this.
>>>
>> I don't have any update pending. Please use the latest patch series (v4).
> NOTE: Runtime target 'qtquick1-dev' is unbuildable, removing...
> Missing or unbuildable dependency chain was: ['qtquick1-dev',
> 'qtwebkit', 'ruby-native']
> NOTE: Runtime target 'packagegroup-qt5-toolchain-target' is
> unbuildable, removing...
> Missing or unbuildable dependency chain was:
> ['packagegroup-qt5-toolchain-target', 'qtquick1-dev', 'qtwebkit',
> 'ruby-native']
>
> This failed to build with Ruby disabled :-)
>
Fixed with v5 patch series.

Regards,
Jonathan