From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: Maxime Ripard
<maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Cc: linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org,
linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org,
linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org,
kevin.z.m.zh-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org,
sunny-0TFLnhJekD6UEPyfVivIlAC/G2K4zDHf@public.gmane.org,
shuge-0TFLnhJekD6UEPyfVivIlAC/G2K4zDHf@public.gmane.org,
zhuzhenhua-0TFLnhJekD6UEPyfVivIlAC/G2K4zDHf@public.gmane.org
Subject: Re: [PATCH v3 2/5] i2c: mv64xxx: Add support for the Allwinner A31 I2C driver
Date: Wed, 5 Mar 2014 17:34:30 +0100 [thread overview]
Message-ID: <20140305163430.GC9228@katana> (raw)
In-Reply-To: <1393950521-4173-3-git-send-email-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
[-- Attachment #1: Type: text/plain, Size: 912 bytes --]
On Tue, Mar 04, 2014 at 05:28:38PM +0100, Maxime Ripard wrote:
> The Allwinner A31 I2C controller is almost identical to the one used in the
> other Allwinner SoCs, except for the fact that it needs to clear the interrupt
> by setting the INT_FLAGS bit in the control register, instead of clearing it.
>
> Signed-off-by: Maxime Ripard <maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
> Reviewed-by: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
> Tested-by: Gregory CLEMENT <gregory.clement-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
Applied to for-next, thanks!
Still...
> + if (of_device_is_compatible(np, "allwinner,sun6i-a31-i2c"))
> + drv_data->irq_clear_inverted = true;
... next time an errata is needed, I think it makes sense to refactor all
these checks into one struct which can be used as match->data directly.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/5] i2c: mv64xxx: Add support for the Allwinner A31 I2C driver
Date: Wed, 5 Mar 2014 17:34:30 +0100 [thread overview]
Message-ID: <20140305163430.GC9228@katana> (raw)
In-Reply-To: <1393950521-4173-3-git-send-email-maxime.ripard@free-electrons.com>
On Tue, Mar 04, 2014 at 05:28:38PM +0100, Maxime Ripard wrote:
> The Allwinner A31 I2C controller is almost identical to the one used in the
> other Allwinner SoCs, except for the fact that it needs to clear the interrupt
> by setting the INT_FLAGS bit in the control register, instead of clearing it.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> Reviewed-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> Tested-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Applied to for-next, thanks!
Still...
> + if (of_device_is_compatible(np, "allwinner,sun6i-a31-i2c"))
> + drv_data->irq_clear_inverted = true;
... next time an errata is needed, I think it makes sense to refactor all
these checks into one struct which can be used as match->data directly.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140305/ac325c78/attachment-0001.sig>
WARNING: multiple messages have this Message-ID (diff)
From: Wolfram Sang <wsa@the-dreams.de>
To: Maxime Ripard <maxime.ripard@free-electrons.com>
Cc: linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, linux-sunxi@googlegroups.com,
kevin.z.m.zh@gmail.com, sunny@allwinnertech.com,
shuge@allwinnertech.com, zhuzhenhua@allwinnertech.com
Subject: Re: [PATCH v3 2/5] i2c: mv64xxx: Add support for the Allwinner A31 I2C driver
Date: Wed, 5 Mar 2014 17:34:30 +0100 [thread overview]
Message-ID: <20140305163430.GC9228@katana> (raw)
In-Reply-To: <1393950521-4173-3-git-send-email-maxime.ripard@free-electrons.com>
[-- Attachment #1: Type: text/plain, Size: 819 bytes --]
On Tue, Mar 04, 2014 at 05:28:38PM +0100, Maxime Ripard wrote:
> The Allwinner A31 I2C controller is almost identical to the one used in the
> other Allwinner SoCs, except for the fact that it needs to clear the interrupt
> by setting the INT_FLAGS bit in the control register, instead of clearing it.
>
> Signed-off-by: Maxime Ripard <maxime.ripard@free-electrons.com>
> Reviewed-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
> Tested-by: Gregory CLEMENT <gregory.clement@free-electrons.com>
Applied to for-next, thanks!
Still...
> + if (of_device_is_compatible(np, "allwinner,sun6i-a31-i2c"))
> + drv_data->irq_clear_inverted = true;
... next time an errata is needed, I think it makes sense to refactor all
these checks into one struct which can be used as match->data directly.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-03-05 16:34 UTC|newest]
Thread overview: 60+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-04 16:28 [PATCH v3 0/5] ARM: sun6i: Add support for the A31 I2C controller Maxime Ripard
2014-03-04 16:28 ` Maxime Ripard
2014-03-04 16:28 ` Maxime Ripard
[not found] ` <1393950521-4173-1-git-send-email-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-03-04 16:28 ` [PATCH v3 1/5] i2c: mv64xxx: Add reset deassert call Maxime Ripard
2014-03-04 16:28 ` Maxime Ripard
2014-03-04 16:28 ` Maxime Ripard
[not found] ` <1393950521-4173-2-git-send-email-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-03-05 16:31 ` Wolfram Sang
2014-03-05 16:31 ` Wolfram Sang
2014-03-05 16:31 ` Wolfram Sang
2014-03-07 9:52 ` Russell King - ARM Linux
2014-03-07 9:52 ` Russell King - ARM Linux
2014-03-07 9:52 ` Russell King - ARM Linux
[not found] ` <20140307095222.GG21483-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2014-03-07 10:07 ` Maxime Ripard
2014-03-07 10:07 ` Maxime Ripard
2014-03-07 10:07 ` Maxime Ripard
2014-03-07 10:34 ` Russell King - ARM Linux
2014-03-07 10:34 ` Russell King - ARM Linux
2014-03-07 10:34 ` Russell King - ARM Linux
[not found] ` <20140307103433.GH21483-l+eeeJia6m9vn6HldHNs0ANdhmdF6hFW@public.gmane.org>
2014-03-07 10:37 ` Wolfram Sang
2014-03-07 10:37 ` Wolfram Sang
2014-03-07 10:37 ` Wolfram Sang
2014-03-07 11:11 ` Chen-Yu Tsai
2014-03-07 11:11 ` [linux-sunxi] " Chen-Yu Tsai
2014-03-07 11:11 ` Chen-Yu Tsai
[not found] ` <CAGb2v66xViOx+DdnuDwad0HsCx2YiYfxqBDAEwYdLHrSydOj0w-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2014-03-07 11:18 ` Wolfram Sang
2014-03-07 11:18 ` [linux-sunxi] " Wolfram Sang
2014-03-07 11:18 ` Wolfram Sang
2014-03-07 13:43 ` [PATCH] i2c: mv64xxx: Fix circular dependencies warning and compilation breakage Maxime Ripard
2014-03-07 13:43 ` Maxime Ripard
2014-03-07 13:43 ` Maxime Ripard
[not found] ` <1394199795-5516-1-git-send-email-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-03-07 14:24 ` Wolfram Sang
2014-03-07 14:24 ` Wolfram Sang
2014-03-07 14:24 ` Wolfram Sang
2014-03-07 14:26 ` Wolfram Sang
2014-03-07 14:26 ` Wolfram Sang
2014-03-07 14:26 ` Wolfram Sang
2014-03-07 14:48 ` Maxime Ripard
2014-03-07 14:48 ` Maxime Ripard
2014-03-07 14:48 ` Maxime Ripard
2014-03-07 13:44 ` Re: [PATCH v3 1/5] i2c: mv64xxx: Add reset deassert call Maxime Ripard
2014-03-07 13:44 ` [linux-sunxi] " Maxime Ripard
2014-03-07 13:44 ` Maxime Ripard
2014-03-04 16:28 ` [PATCH v3 2/5] i2c: mv64xxx: Add support for the Allwinner A31 I2C driver Maxime Ripard
2014-03-04 16:28 ` Maxime Ripard
2014-03-04 16:28 ` Maxime Ripard
[not found] ` <1393950521-4173-3-git-send-email-maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org>
2014-03-05 16:34 ` Wolfram Sang [this message]
2014-03-05 16:34 ` Wolfram Sang
2014-03-05 16:34 ` Wolfram Sang
2014-03-07 10:13 ` Maxime Ripard
2014-03-07 10:13 ` Maxime Ripard
2014-03-07 10:13 ` Maxime Ripard
2014-03-04 16:28 ` [PATCH v3 3/5] ARM: sun6i: Enable the I2C controllers Maxime Ripard
2014-03-04 16:28 ` Maxime Ripard
2014-03-04 16:28 ` Maxime Ripard
2014-03-04 16:28 ` [PATCH v3 4/5] ARM: sun6i: Enable the I2C muxing options Maxime Ripard
2014-03-04 16:28 ` Maxime Ripard
2014-03-04 16:28 ` Maxime Ripard
2014-03-04 16:28 ` [PATCH v3 5/5] ARM: sun6i: colombus: Enable the I2C controllers Maxime Ripard
2014-03-04 16:28 ` Maxime Ripard
2014-03-04 16:28 ` Maxime Ripard
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140305163430.GC9228@katana \
--to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
--cc=kevin.z.m.zh-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
--cc=linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org \
--cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
--cc=linux-sunxi-/JYPxA39Uh5TLH3MbocFFw@public.gmane.org \
--cc=maxime.ripard-wi1+55ScJUtKEb57/3fJTNBPR1lH4CV8@public.gmane.org \
--cc=shuge-0TFLnhJekD6UEPyfVivIlAC/G2K4zDHf@public.gmane.org \
--cc=sunny-0TFLnhJekD6UEPyfVivIlAC/G2K4zDHf@public.gmane.org \
--cc=zhuzhenhua-0TFLnhJekD6UEPyfVivIlAC/G2K4zDHf@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.