From: Wolfram Sang <wsa@the-dreams.de>
To: Bjorn Andersson <bjorn.andersson@sonymobile.com>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>, Rob Landley <rob@landley.net>,
Grant Likely <grant.likely@linaro.org>,
devicetree@vger.kernel.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-i2c@vger.kernel.org,
linux-arm-msm@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
Andy Gross <agross@codeaurora.org>,
Stephen Boyd <sboyd@codeaurora.org>,
"Ivan T. Ivanov" <iivanov@mm-sol.com>
Subject: Re: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller
Date: Wed, 5 Mar 2014 17:44:41 +0100 [thread overview]
Message-ID: <20140305164441.GD9228@katana> (raw)
In-Reply-To: <1392943090-30556-3-git-send-email-bjorn.andersson@sonymobile.com>
[-- Attachment #1: Type: text/plain, Size: 324 bytes --]
> + qup->adap.nr = pdev->id;
> + qup->adap.dev.parent = qup->dev;
> + qup->adap.dev.of_node = pdev->dev.of_node;
> + strlcpy(qup->adap.name, "QUP I2C adapter", sizeof(qup->adap.name));
> +
> + ret = i2c_add_numbered_adapter(&qup->adap);
I'd suggest to use just i2c_add_adapter and let the core check the
aliases for you.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller
Date: Wed, 5 Mar 2014 17:44:41 +0100 [thread overview]
Message-ID: <20140305164441.GD9228@katana> (raw)
In-Reply-To: <1392943090-30556-3-git-send-email-bjorn.andersson@sonymobile.com>
> + qup->adap.nr = pdev->id;
> + qup->adap.dev.parent = qup->dev;
> + qup->adap.dev.of_node = pdev->dev.of_node;
> + strlcpy(qup->adap.name, "QUP I2C adapter", sizeof(qup->adap.name));
> +
> + ret = i2c_add_numbered_adapter(&qup->adap);
I'd suggest to use just i2c_add_adapter and let the core check the
aliases for you.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140305/6fcc90a1/attachment.sig>
next prev parent reply other threads:[~2014-03-05 16:44 UTC|newest]
Thread overview: 42+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-02-21 0:38 [PATCH v3 0/2] Qualcomm Universal Peripheral (QUP) I2C controller Bjorn Andersson
2014-02-21 0:38 ` Bjorn Andersson
2014-02-21 0:38 ` Bjorn Andersson
[not found] ` <1392943090-30556-1-git-send-email-bjorn.andersson-/MT0OVThwyLZJqsBc5GL+g@public.gmane.org>
2014-02-21 0:38 ` [PATCH v3 1/2] i2c: qup: Add device tree bindings information Bjorn Andersson
2014-02-21 0:38 ` Bjorn Andersson
2014-02-21 0:38 ` Bjorn Andersson
2014-02-21 11:01 ` Mark Rutland
2014-02-21 11:01 ` Mark Rutland
2014-02-21 0:38 ` [PATCH v3 2/2] i2c: New bus driver for the Qualcomm QUP I2C controller Bjorn Andersson
2014-02-21 0:38 ` Bjorn Andersson
2014-02-21 0:38 ` Bjorn Andersson
2014-02-21 0:52 ` Joe Perches
2014-02-21 0:52 ` Joe Perches
2014-02-24 17:51 ` Bjorn Andersson
2014-02-24 17:51 ` Bjorn Andersson
2014-02-24 17:51 ` Bjorn Andersson
2014-02-21 2:53 ` Emilio López
2014-02-21 2:53 ` Emilio López
2014-02-24 18:00 ` Bjorn Andersson
2014-02-24 18:00 ` Bjorn Andersson
2014-02-21 8:16 ` Maxime Ripard
2014-02-21 8:16 ` Maxime Ripard
2014-02-21 8:16 ` Maxime Ripard
2014-02-24 18:03 ` Bjorn Andersson
2014-02-24 18:03 ` Bjorn Andersson
2014-02-21 11:06 ` Mark Rutland
2014-02-21 11:06 ` Mark Rutland
2014-02-25 16:07 ` Bjorn Andersson
2014-02-25 16:07 ` Bjorn Andersson
2014-02-25 16:56 ` Andy Gross
2014-02-25 16:56 ` Andy Gross
[not found] ` <1392943090-30556-3-git-send-email-bjorn.andersson-/MT0OVThwyLZJqsBc5GL+g@public.gmane.org>
2014-02-21 15:35 ` Kumar Gala
2014-02-21 15:35 ` Kumar Gala
2014-02-21 15:35 ` Kumar Gala
2014-02-24 10:33 ` Ivan T. Ivanov
2014-02-24 10:33 ` Ivan T. Ivanov
2014-02-24 17:40 ` Josh Cartwright
2014-02-24 17:40 ` Josh Cartwright
2014-02-24 18:05 ` Bjorn Andersson
2014-02-24 18:05 ` Bjorn Andersson
2014-03-05 16:44 ` Wolfram Sang [this message]
2014-03-05 16:44 ` Wolfram Sang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140305164441.GD9228@katana \
--to=wsa@the-dreams.de \
--cc=agross@codeaurora.org \
--cc=bjorn.andersson@sonymobile.com \
--cc=devicetree@vger.kernel.org \
--cc=galak@codeaurora.org \
--cc=grant.likely@linaro.org \
--cc=iivanov@mm-sol.com \
--cc=ijc+devicetree@hellion.org.uk \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mark.rutland@arm.com \
--cc=pawel.moll@arm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=sboyd@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.