From: Florian Westphal <fw@strlen.de>
To: Alexander Aring <alex.aring@gmail.com>
Cc: alex.bluesman.smirnov@gmail.com, dbaryshkov@gmail.com,
linux-zigbee-devel@lists.sourceforge.net, netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] 6lowpan: reassembly: fix kernel oops while unloading
Date: Wed, 5 Mar 2014 23:32:46 +0100 [thread overview]
Message-ID: <20140305223246.GA17526@breakpoint.cc> (raw)
In-Reply-To: <1394052211-6976-3-git-send-email-alex.aring@gmail.com>
Alexander Aring <alex.aring@gmail.com> wrote:
> It seems that the inet_frag_queue is deleted but the timer is running. This
> patch adds a for loop to iterate over all frag_queue entries in the
> frag_bucket and calling del_timer for each frag_queue entry while
> unloading the 6lowpan module.
>
> Signed-off-by: Alexander Aring <alex.aring@gmail.com>
> Reported-by: Phoebe Buckheister <phoebe.buckheister@itwm.fraunhofer.de>
> ---
> I am not sure about that I can do that in this simply way without hold
> any lock of the inet_frag_queue or inet_frag_bucket. Please help there.
> The kernel oops never occurs afterwards, but this isn't simple to test.
> I can't test all cases.
I find it hard to believe that this is a 6lowpan specific problem,
most likely this needs a fix in inet_fragment code.
I am currently looking at that code for different reasons anyway and can
investigate tomorrow if you do not have time for it.
next prev parent reply other threads:[~2014-03-05 22:32 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 20:43 [PATCH net-next 0/2] 6lowpan: fixes for new reassembly implementation Alexander Aring
[not found] ` <1394052211-6976-1-git-send-email-alex.aring-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-03-05 20:43 ` [PATCH net-next 1/2] 6lowpan: reassembly: fix return of init function Alexander Aring
2014-03-05 22:04 ` Sergei Shtylyov
2014-03-06 5:44 ` Alexander Aring
2014-03-06 13:30 ` Sergei Shtylyov
2014-03-05 20:43 ` [PATCH net-next 2/2] 6lowpan: reassembly: fix kernel oops while unloading Alexander Aring
2014-03-05 22:32 ` Florian Westphal [this message]
2014-03-06 6:09 ` Alexander Aring
2014-03-06 13:38 ` Florian Westphal
2014-03-06 16:36 ` Alexander Aring
2014-03-06 16:41 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140305223246.GA17526@breakpoint.cc \
--to=fw@strlen.de \
--cc=alex.aring@gmail.com \
--cc=alex.bluesman.smirnov@gmail.com \
--cc=dbaryshkov@gmail.com \
--cc=linux-zigbee-devel@lists.sourceforge.net \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.