From: Florian Westphal <fw@strlen.de>
To: Alexander Aring <alex.aring@gmail.com>
Cc: Florian Westphal <fw@strlen.de>,
alex.bluesman.smirnov@gmail.com, dbaryshkov@gmail.com,
netdev@vger.kernel.org
Subject: Re: [PATCH net-next 2/2] 6lowpan: reassembly: fix kernel oops while unloading
Date: Thu, 6 Mar 2014 17:41:35 +0100 [thread overview]
Message-ID: <20140306164135.GD17526@breakpoint.cc> (raw)
In-Reply-To: <20140306163635.GA21460@omega>
Alexander Aring <alex.aring@gmail.com> wrote:
> ah, ok.
>
> > I am currently testing this fix:
> >
> > diff --git a/net/ipv4/inet_fragment.c b/net/ipv4/inet_fragment.c
> > index 322dceb..3b01959 100644
> > --- a/net/ipv4/inet_fragment.c
> > +++ b/net/ipv4/inet_fragment.c
> > @@ -208,7 +208,7 @@ int inet_frag_evictor(struct netns_frags *nf, struct
> > inet_frags *f, bool force)
> > }
> >
> > work = frag_mem_limit(nf) - nf->low_thresh;
> > - while (work > 0) {
> > + while (work > 0 || force) {
> >
> >
>
> I looked at this and try my little testscript and I don't get the kernel
> oops also. What's the next step?
Thanks for testing!
I'll make official submit soon, adding proper changelog and your
tested-by tag.
prev parent reply other threads:[~2014-03-06 16:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-05 20:43 [PATCH net-next 0/2] 6lowpan: fixes for new reassembly implementation Alexander Aring
[not found] ` <1394052211-6976-1-git-send-email-alex.aring-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
2014-03-05 20:43 ` [PATCH net-next 1/2] 6lowpan: reassembly: fix return of init function Alexander Aring
2014-03-05 22:04 ` Sergei Shtylyov
2014-03-06 5:44 ` Alexander Aring
2014-03-06 13:30 ` Sergei Shtylyov
2014-03-05 20:43 ` [PATCH net-next 2/2] 6lowpan: reassembly: fix kernel oops while unloading Alexander Aring
2014-03-05 22:32 ` Florian Westphal
2014-03-06 6:09 ` Alexander Aring
2014-03-06 13:38 ` Florian Westphal
2014-03-06 16:36 ` Alexander Aring
2014-03-06 16:41 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140306164135.GD17526@breakpoint.cc \
--to=fw@strlen.de \
--cc=alex.aring@gmail.com \
--cc=alex.bluesman.smirnov@gmail.com \
--cc=dbaryshkov@gmail.com \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.