From: Wolfram Sang <wsa@the-dreams.de>
To: linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH V2 01/12] clk: shmobile: add CPG driver for rz-platforms
Date: Thu, 06 Mar 2014 13:06:55 +0000 [thread overview]
Message-ID: <20140306130655.GA10657@katana> (raw)
In-Reply-To: <1434755.d9svPEINg5@avalon>
[-- Attachment #1: Type: text/plain, Size: 605 bytes --]
> > + - clocks: References to possible parent clocks. Order must match clock
> > modes
> > + in the datasheet.
>
> I believe the order should be documented explicitly instead of referring to
> the datasheet.
I wanted to keep it generic in case future SoCs want to use the driver.
> > + num_clks = of_property_count_strings(np, "clock-output-names");
> > + if (WARN(num_clks <= 0, "can't count CPG clocks\n"))
> > + goto out;
>
> You can return directly instead of goto out.
I personally don't prefer the mixture of goto and direct return. Please
say if you insist on that.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
WARNING: multiple messages have this Message-ID (diff)
From: wsa@the-dreams.de (Wolfram Sang)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH V2 01/12] clk: shmobile: add CPG driver for rz-platforms
Date: Thu, 6 Mar 2014 14:06:55 +0100 [thread overview]
Message-ID: <20140306130655.GA10657@katana> (raw)
In-Reply-To: <1434755.d9svPEINg5@avalon>
> > + - clocks: References to possible parent clocks. Order must match clock
> > modes
> > + in the datasheet.
>
> I believe the order should be documented explicitly instead of referring to
> the datasheet.
I wanted to keep it generic in case future SoCs want to use the driver.
> > + num_clks = of_property_count_strings(np, "clock-output-names");
> > + if (WARN(num_clks <= 0, "can't count CPG clocks\n"))
> > + goto out;
>
> You can return directly instead of goto out.
I personally don't prefer the mixture of goto and direct return. Please
say if you insist on that.
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.infradead.org/pipermail/linux-arm-kernel/attachments/20140306/2817bf52/attachment-0001.sig>
next prev parent reply other threads:[~2014-03-06 13:06 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 11:32 [PATCH V2 00/12] CCF support for Renesas r7s72100 Wolfram Sang
2014-03-06 11:32 ` Wolfram Sang
2014-03-06 11:32 ` [PATCH V2 01/12] clk: shmobile: add CPG driver for rz-platforms Wolfram Sang
2014-03-06 11:32 ` Wolfram Sang
2014-03-06 12:12 ` Laurent Pinchart
2014-03-06 12:12 ` Laurent Pinchart
2014-03-06 13:06 ` Wolfram Sang [this message]
2014-03-06 13:06 ` Wolfram Sang
2014-03-06 13:21 ` Geert Uytterhoeven
2014-03-06 13:21 ` Geert Uytterhoeven
2014-03-06 11:32 ` [PATCH V2 02/12] ARM: shmobile: r7s72100: document MSTP clock support Wolfram Sang
2014-03-06 11:32 ` Wolfram Sang
2014-03-06 11:32 ` [PATCH V2 03/12] ARM: shmobile: r7s72100: add essential clock nodes to dtsi Wolfram Sang
2014-03-06 11:32 ` Wolfram Sang
2014-03-06 12:16 ` Laurent Pinchart
2014-03-06 12:16 ` Laurent Pinchart
2014-03-06 11:32 ` [PATCH V2 04/12] ARM: shmobile: r7s72100: genmai: populate nodes for external clocks Wolfram Sang
2014-03-06 11:32 ` Wolfram Sang
2014-03-06 11:32 ` [PATCH V2 05/12] ARM: shmobile: r7s72100: use workaround for non DT-clocks Wolfram Sang
2014-03-06 11:32 ` Wolfram Sang
2014-03-06 11:32 ` [PATCH V2 06/12] ARM: shmobile: r7s72100: add scif nodes to dtsi Wolfram Sang
2014-03-06 11:32 ` Wolfram Sang
2014-03-06 11:32 ` [PATCH V2 07/12] ARM: shmobile: r7s72100: genmai: activate scif2 for console output Wolfram Sang
2014-03-06 11:32 ` Wolfram Sang
2014-03-06 11:32 ` [PATCH V2 08/12] ARM: shmobile: r7s72100: genmai: platform scif devices only for legacy support Wolfram Sang
2014-03-06 11:32 ` Wolfram Sang
2014-03-06 11:32 ` [PATCH V2 09/12] ARM: shmobile: r7s72100: add i2c clocks to dtsi Wolfram Sang
2014-03-06 11:32 ` Wolfram Sang
2014-03-06 11:32 ` [PATCH V2 10/12] ARM: shmobile: r7s72100: remove I2C DT clocks from legacy clock support Wolfram Sang
2014-03-06 11:32 ` Wolfram Sang
2014-03-06 11:32 ` [PATCH V2 11/12] ARM: shmobile: r7s72100: add spi clocks to dtsi Wolfram Sang
2014-03-06 11:32 ` Wolfram Sang
2014-03-06 13:03 ` Geert Uytterhoeven
2014-03-06 13:03 ` Geert Uytterhoeven
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140306130655.GA10657@katana \
--to=wsa@the-dreams.de \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.