All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 6/6] liburcu: disable build with gcc-4.8.x on ARM
Date: Thu, 6 Mar 2014 23:17:23 +0100	[thread overview]
Message-ID: <20140306231723.32e217fd@skate> (raw)
In-Reply-To: <1393717193-19774-7-git-send-email-s.martin49@gmail.com>

Dear Samuel Martin,

On Sun,  2 Mar 2014 00:39:53 +0100, Samuel Martin wrote:

> +	# liburcu/gcc-4.8.x bug
> +	depends on !((BR2_arm || BR2_armeb) && (BR2_GCC_VERSION_4_8_X || \
> +		BR2_TOOLCHAIN_EXTERNAL_LINARO_2013_11 || \
> +		BR2_TOOLCHAIN_EXTERNAL_LINARO_2013_10 || \
> +		BR2_TOOLCHAIN_EXTERNAL_LINARO_2013_09 || \
> +		BR2_TOOLCHAIN_EXTERNAL_CODESOURCERY_ARM201311))

The exclusion of BR2_GCC_VERSION_4_8_X is wrong, because we have in
Buildroot the patch fixing the
http://gcc.gnu.org/bugzilla/show_bug.cgi?id=58854 gcc bug.

But generally, I'm not really happy with this approach, as we would
have to update these dependencies every time we bump/change the
external toolchain Kconfig options... Unfortunately I don't have a
better suggestion.

Maybe I would prefer something like:

config BR2_TOOLCHAIN_HAS_GCC_BUG_58854
	bool

And then the toolchain impacted by the bug would select it. For
example, are you sure the Linaro toolchains are affected by the
problem? Most likely they have backported the change that is needed to
fix this problem.

Best regards,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

  reply	other threads:[~2014-03-06 22:17 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-01 23:39 [Buildroot] [PATCH 0/6] Lttng packages bump Samuel Martin
2014-03-01 23:39 ` [Buildroot] [PATCH 1/6] liburcu: bump version to 0.8.3 Samuel Martin
2014-03-01 23:39 ` [Buildroot] [PATCH 2/6] lttng-libust: bump version to 2.4.0 Samuel Martin
2014-03-01 23:39 ` [Buildroot] [PATCH 3/6] lttng-modules: " Samuel Martin
2014-03-01 23:39 ` [Buildroot] [PATCH 4/6] lttng-tools: " Samuel Martin
2014-03-01 23:39 ` [Buildroot] [PATCH 5/6] lttng-babeltrace: bump version to 1.2.0 Samuel Martin
2014-03-01 23:39 ` [Buildroot] [PATCH 6/6] liburcu: disable build with gcc-4.8.x on ARM Samuel Martin
2014-03-06 22:17   ` Thomas Petazzoni [this message]
2014-03-07 12:59     ` Samuel Martin
2014-03-07 13:04       ` Thomas Petazzoni
2014-03-07 13:14         ` Samuel Martin
2014-03-07 13:25           ` Thomas Petazzoni

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140306231723.32e217fd@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.