All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 6/6] liburcu: disable build with gcc-4.8.x on ARM
Date: Fri, 7 Mar 2014 14:25:51 +0100	[thread overview]
Message-ID: <20140307142551.4723159f@skate> (raw)
In-Reply-To: <CAHXCMMLgnj7CEVFnkjjkc=PH9NfXZtDe92tnpo3YwwmTHjk-Qw@mail.gmail.com>

Dear Samuel Martin,

On Fri, 7 Mar 2014 14:14:45 +0100, Samuel Martin wrote:

> > So liburcu checks itself that the gcc version should be different than
> > 4.8.0, 4.8.1 and 4.8.2 ?
> 
> Yes, it's done by this patch:
> http://git.lttng.org/?p=userspace-rcu.git;a=commitdiff;h=4b79310

This patch is a bit stupid. It should actually test for the problem
itself, not make some assumption about the gcc version.

> Just to be clear, your suggestion is only about enabling gcc-4.8.2
> (with the fix), not gcc-4.8.0 nor gcc-4.8.1, right?

We don't support 4.8.0 and 4.8.1 in the internal toolchain backend.

> Then we have to check for each external toolchain if it has the fix.

Yes.

> What about custom toolchain based on gcc-4.8.2? Shall we able it
> (warning the user) or just disabling it?

For custom toolchains, we have absolutely no idea which gcc version is
being used at the Kconfig level, so I don't know how we could disallow
building the package in this case.

That being said, the kernel also mis-compiles on ARM with gcc 4.8.x if
you don't have this fix, and we haven't done anything to prevent people
from building the kernel against unfixed versions of gcc 4.8.x.
Therefore, should we care about liburcu ?

Thanks,

Thomas
-- 
Thomas Petazzoni, CTO, Free Electrons
Embedded Linux, Kernel and Android engineering
http://free-electrons.com

      reply	other threads:[~2014-03-07 13:25 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-01 23:39 [Buildroot] [PATCH 0/6] Lttng packages bump Samuel Martin
2014-03-01 23:39 ` [Buildroot] [PATCH 1/6] liburcu: bump version to 0.8.3 Samuel Martin
2014-03-01 23:39 ` [Buildroot] [PATCH 2/6] lttng-libust: bump version to 2.4.0 Samuel Martin
2014-03-01 23:39 ` [Buildroot] [PATCH 3/6] lttng-modules: " Samuel Martin
2014-03-01 23:39 ` [Buildroot] [PATCH 4/6] lttng-tools: " Samuel Martin
2014-03-01 23:39 ` [Buildroot] [PATCH 5/6] lttng-babeltrace: bump version to 1.2.0 Samuel Martin
2014-03-01 23:39 ` [Buildroot] [PATCH 6/6] liburcu: disable build with gcc-4.8.x on ARM Samuel Martin
2014-03-06 22:17   ` Thomas Petazzoni
2014-03-07 12:59     ` Samuel Martin
2014-03-07 13:04       ` Thomas Petazzoni
2014-03-07 13:14         ` Samuel Martin
2014-03-07 13:25           ` Thomas Petazzoni [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140307142551.4723159f@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.