From: Mike Snitzer <snitzer@redhat.com>
To: Jim Davis <jim.epost@gmail.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next <linux-next@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
agk@redhat.com, dm-devel@redhat.com, neilb@suse.de,
linux-raid@vger.kernel.org
Subject: Re: randconfig build error with next-20140307, in drivers/md/dm-era-target.c
Date: Fri, 7 Mar 2014 08:52:02 -0500 [thread overview]
Message-ID: <20140307135202.GA31136@redhat.com> (raw)
In-Reply-To: <CA+r1ZhiRiT-fQz9-QYAPaq9CBwUQMtHy2HpDg2nmbsqeU05yyA@mail.gmail.com>
On Fri, Mar 07 2014 at 6:57am -0500,
Jim Davis <jim.epost@gmail.com> wrote:
> Building with the attached random configuration file,
>
> LD init/built-in.o
> drivers/built-in.o: In function `do_work':
> dm-era-target.c:(.text+0x7304ea): undefined reference to `__udivdi3'
> drivers/built-in.o: In function `era_map':
> dm-era-target.c:(.text+0x730759): undefined reference to `__udivdi3'
> make: *** [vmlinux] Error 1
Thanks for the report. This patch will fix it (I'll fold it into the
"dm era: support non power-of-2 blocksize" commit now):
From 342553076366eac8b1718488045f710cd935636f Mon Sep 17 00:00:00 2001
From: Mike Snitzer <snitzer@redhat.com>
Date: Fri, 7 Mar 2014 08:47:56 -0500
Subject: [PATCH] dm era: fix 64 bit divide on 32 bit
LD init/built-in.o
drivers/built-in.o: In function `do_work':
dm-era-target.c:(.text+0x7304ea): undefined reference to `__udivdi3'
drivers/built-in.o: In function `era_map':
dm-era-target.c:(.text+0x730759): undefined reference to `__udivdi3'
make: *** [vmlinux] Error 1
---
drivers/md/dm-era-target.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/md/dm-era-target.c b/drivers/md/dm-era-target.c
index d7bd7b3..3a72206 100644
--- a/drivers/md/dm-era-target.c
+++ b/drivers/md/dm-era-target.c
@@ -1120,7 +1120,7 @@ static bool block_size_is_power_of_two(struct era *era)
static dm_block_t get_block(struct era *era, struct bio *bio)
{
- dm_block_t block_nr = bio->bi_iter.bi_sector;
+ sector_t block_nr = bio->bi_iter.bi_sector;
if (!block_size_is_power_of_two(era))
(void) sector_div(block_nr, era->sectors_per_block);
--
1.7.1
WARNING: multiple messages have this Message-ID (diff)
From: Mike Snitzer <snitzer@redhat.com>
To: Jim Davis <jim.epost@gmail.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>,
linux-next <linux-next@vger.kernel.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
agk@redhat.com, dm-devel@redhat.com, neilb@suse.de,
linux-raid@vger.kernel.org
Subject: Re: randconfig build error with next-20140307, in drivers/md/dm-era-target.c
Date: Fri, 7 Mar 2014 08:52:02 -0500 [thread overview]
Message-ID: <20140307135202.GA31136@redhat.com> (raw)
In-Reply-To: <CA+r1ZhiRiT-fQz9-QYAPaq9CBwUQMtHy2HpDg2nmbsqeU05yyA@mail.gmail.com>
On Fri, Mar 07 2014 at 6:57am -0500,
Jim Davis <jim.epost@gmail.com> wrote:
> Building with the attached random configuration file,
>
> LD init/built-in.o
> drivers/built-in.o: In function `do_work':
> dm-era-target.c:(.text+0x7304ea): undefined reference to `__udivdi3'
> drivers/built-in.o: In function `era_map':
> dm-era-target.c:(.text+0x730759): undefined reference to `__udivdi3'
> make: *** [vmlinux] Error 1
Thanks for the report. This patch will fix it (I'll fold it into the
"dm era: support non power-of-2 blocksize" commit now):
>From 342553076366eac8b1718488045f710cd935636f Mon Sep 17 00:00:00 2001
From: Mike Snitzer <snitzer@redhat.com>
Date: Fri, 7 Mar 2014 08:47:56 -0500
Subject: [PATCH] dm era: fix 64 bit divide on 32 bit
LD init/built-in.o
drivers/built-in.o: In function `do_work':
dm-era-target.c:(.text+0x7304ea): undefined reference to `__udivdi3'
drivers/built-in.o: In function `era_map':
dm-era-target.c:(.text+0x730759): undefined reference to `__udivdi3'
make: *** [vmlinux] Error 1
---
drivers/md/dm-era-target.c | 2 +-
1 files changed, 1 insertions(+), 1 deletions(-)
diff --git a/drivers/md/dm-era-target.c b/drivers/md/dm-era-target.c
index d7bd7b3..3a72206 100644
--- a/drivers/md/dm-era-target.c
+++ b/drivers/md/dm-era-target.c
@@ -1120,7 +1120,7 @@ static bool block_size_is_power_of_two(struct era *era)
static dm_block_t get_block(struct era *era, struct bio *bio)
{
- dm_block_t block_nr = bio->bi_iter.bi_sector;
+ sector_t block_nr = bio->bi_iter.bi_sector;
if (!block_size_is_power_of_two(era))
(void) sector_div(block_nr, era->sectors_per_block);
--
1.7.1
next prev parent reply other threads:[~2014-03-07 13:52 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 11:57 randconfig build error with next-20140307, in drivers/md/dm-era-target.c Jim Davis
2014-03-07 13:52 ` Mike Snitzer [this message]
2014-03-07 13:52 ` Mike Snitzer
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140307135202.GA31136@redhat.com \
--to=snitzer@redhat.com \
--cc=agk@redhat.com \
--cc=dm-devel@redhat.com \
--cc=jim.epost@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-next@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=neilb@suse.de \
--cc=sfr@canb.auug.org.au \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.