From: Vivek Goyal <vgoyal@redhat.com>
To: WANG Chao <chaowang@redhat.com>
Cc: Baoquan He <bhe@redhat.com>,
x86@kernel.org, kexec@lists.infradead.org,
linux-kernel@vger.kernel.org, "H. Peter Anvin" <hpa@zytor.com>,
Muli Ben-Yehuda <muli@cs.technion.ac.il>,
"Jon D. Mason" <jdmason@kudzu.us>
Subject: Re: [PATCH] x86, calgary: use 8M TCE table size by default
Date: Fri, 7 Mar 2014 09:14:13 -0500 [thread overview]
Message-ID: <20140307141413.GF1326@redhat.com> (raw)
In-Reply-To: <1394179816-15435-1-git-send-email-chaowang@redhat.com>
On Fri, Mar 07, 2014 at 04:10:16PM +0800, WANG Chao wrote:
[..]
> }
>
> - specified_table_size = determine_tce_table_size((is_kdump_kernel() ?
> - saved_max_pfn : max_pfn) * PAGE_SIZE);
> + specified_table_size = determine_tce_table_size();
I don't think you can get rid of saved_max_pfn right away. What if
somebody is using old first kernel and new second kernel. Then old kernel
will still be using a table size which is smaller than 8M.
Thanks
Vivek
_______________________________________________
kexec mailing list
kexec@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/kexec
WARNING: multiple messages have this Message-ID (diff)
From: Vivek Goyal <vgoyal@redhat.com>
To: WANG Chao <chaowang@redhat.com>
Cc: Muli Ben-Yehuda <muli@cs.technion.ac.il>,
"Jon D. Mason" <jdmason@kudzu.us>,
"H. Peter Anvin" <hpa@zytor.com>, Baoquan He <bhe@redhat.com>,
kexec@lists.infradead.org, x86@kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] x86, calgary: use 8M TCE table size by default
Date: Fri, 7 Mar 2014 09:14:13 -0500 [thread overview]
Message-ID: <20140307141413.GF1326@redhat.com> (raw)
In-Reply-To: <1394179816-15435-1-git-send-email-chaowang@redhat.com>
On Fri, Mar 07, 2014 at 04:10:16PM +0800, WANG Chao wrote:
[..]
> }
>
> - specified_table_size = determine_tce_table_size((is_kdump_kernel() ?
> - saved_max_pfn : max_pfn) * PAGE_SIZE);
> + specified_table_size = determine_tce_table_size();
I don't think you can get rid of saved_max_pfn right away. What if
somebody is using old first kernel and new second kernel. Then old kernel
will still be using a table size which is smaller than 8M.
Thanks
Vivek
next prev parent reply other threads:[~2014-03-07 14:14 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 8:10 [PATCH] x86, calgary: use 8M TCE table size by default WANG Chao
2014-03-07 8:10 ` WANG Chao
2014-03-07 14:14 ` Vivek Goyal [this message]
2014-03-07 14:14 ` Vivek Goyal
2014-03-07 15:52 ` WANG Chao
2014-03-07 15:52 ` WANG Chao
2014-03-07 16:09 ` Vivek Goyal
2014-03-07 16:09 ` Vivek Goyal
2014-03-09 7:08 ` Muli Ben-Yehuda
2014-03-09 7:08 ` Muli Ben-Yehuda
2014-03-10 8:38 ` WANG Chao
2014-03-10 8:38 ` WANG Chao
2014-03-10 12:38 ` Vivek Goyal
2014-03-10 12:38 ` Vivek Goyal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140307141413.GF1326@redhat.com \
--to=vgoyal@redhat.com \
--cc=bhe@redhat.com \
--cc=chaowang@redhat.com \
--cc=hpa@zytor.com \
--cc=jdmason@kudzu.us \
--cc=kexec@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=muli@cs.technion.ac.il \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.