From: Dave Jones <davej@redhat.com>
To: Vladimir Davydov <vdavydov@parallels.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, cl@linux-foundation.org, penberg@kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: slub: fix leak of 'name' in sysfs_slab_add
Date: Fri, 7 Mar 2014 10:32:59 -0500 [thread overview]
Message-ID: <20140307153259.GA778@redhat.com> (raw)
In-Reply-To: <5319649C.3060309@parallels.com>
On Fri, Mar 07, 2014 at 10:18:04AM +0400, Vladimir Davydov wrote:
> [adding Andrew to Cc]
>
> On 03/07/2014 01:11 AM, Dave Jones wrote:
> > The failure paths of sysfs_slab_add don't release the allocation of 'name'
> > made by create_unique_id() a few lines above the context of the diff below.
> > Create a common exit path to make it more obvious what needs freeing.
> >
> > Signed-off-by: Dave Jones <davej@fedoraproject.org>
> >
>
> Since this function was modified in the mmotm tree, I would propose
> something like this on top of mmotm to avoid further merge conflicts:
Looks good to me.
thanks,
Dave
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
WARNING: multiple messages have this Message-ID (diff)
From: Dave Jones <davej@redhat.com>
To: Vladimir Davydov <vdavydov@parallels.com>
Cc: Linux Kernel <linux-kernel@vger.kernel.org>,
linux-mm@kvack.org, cl@linux-foundation.org, penberg@kernel.org,
Andrew Morton <akpm@linux-foundation.org>
Subject: Re: slub: fix leak of 'name' in sysfs_slab_add
Date: Fri, 7 Mar 2014 10:32:59 -0500 [thread overview]
Message-ID: <20140307153259.GA778@redhat.com> (raw)
In-Reply-To: <5319649C.3060309@parallels.com>
On Fri, Mar 07, 2014 at 10:18:04AM +0400, Vladimir Davydov wrote:
> [adding Andrew to Cc]
>
> On 03/07/2014 01:11 AM, Dave Jones wrote:
> > The failure paths of sysfs_slab_add don't release the allocation of 'name'
> > made by create_unique_id() a few lines above the context of the diff below.
> > Create a common exit path to make it more obvious what needs freeing.
> >
> > Signed-off-by: Dave Jones <davej@fedoraproject.org>
> >
>
> Since this function was modified in the mmotm tree, I would propose
> something like this on top of mmotm to avoid further merge conflicts:
Looks good to me.
thanks,
Dave
next prev parent reply other threads:[~2014-03-07 15:33 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 21:11 slub: fix leak of 'name' in sysfs_slab_add Dave Jones
2014-03-06 21:11 ` Dave Jones
2014-03-07 6:18 ` Vladimir Davydov
2014-03-07 6:18 ` Vladimir Davydov
2014-03-07 15:32 ` Dave Jones [this message]
2014-03-07 15:32 ` Dave Jones
2014-03-07 17:14 ` Christoph Lameter
2014-03-07 17:14 ` Christoph Lameter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140307153259.GA778@redhat.com \
--to=davej@redhat.com \
--cc=akpm@linux-foundation.org \
--cc=cl@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=penberg@kernel.org \
--cc=vdavydov@parallels.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.