From: Andy Gross <agross@codeaurora.org>
To: "Shevchenko, Andriy" <andriy.shevchenko@intel.com>
Cc: "Koul, Vinod" <vinod.koul@intel.com>,
"Williams, Dan J" <dan.j.williams@intel.com>,
"dmaengine@vger.kernel.org" <dmaengine@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"linux-arm-msm@vger.kernel.org" <linux-arm-msm@vger.kernel.org>
Subject: Re: [Patch v8 2/2] dmaengine: add Qualcomm BAM dma driver
Date: Fri, 7 Mar 2014 17:11:08 -0600 [thread overview]
Message-ID: <20140307231108.GD3241@qualcomm.com> (raw)
In-Reply-To: <1393839482.28803.118.camel@smile.fi.intel.com>
On Mon, Mar 03, 2014 at 09:38:03AM +0000, Shevchenko, Andriy wrote:
<snip>
> > + if (IS_ERR(bdev->bamclk))
> > + return PTR_ERR(bdev->bamclk);
> > +
> > + ret = clk_prepare_enable(bdev->bamclk);
> > + if (ret) {
> > + dev_err(bdev->dev, "failed to prepare/enable clock\n");
> > + return ret;
> > + }
> > +
> > + ret = of_property_read_u32(pdev->dev.of_node, "qcom,ee", &bdev->ee);
> > + if (ret) {
> > + dev_err(bdev->dev, "Execution environment unspecified\n");
> > + return ret;
>
> goto err_disable_clk; ?
>
> >
> > + }
> > +
> > + ret = bam_init(bdev);
> > + if (ret)
> > + return ret;
>
> Ditto.
>
Good catch. I'll fix both of those.
--
sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
WARNING: multiple messages have this Message-ID (diff)
From: agross@codeaurora.org (Andy Gross)
To: linux-arm-kernel@lists.infradead.org
Subject: [Patch v8 2/2] dmaengine: add Qualcomm BAM dma driver
Date: Fri, 7 Mar 2014 17:11:08 -0600 [thread overview]
Message-ID: <20140307231108.GD3241@qualcomm.com> (raw)
In-Reply-To: <1393839482.28803.118.camel@smile.fi.intel.com>
On Mon, Mar 03, 2014 at 09:38:03AM +0000, Shevchenko, Andriy wrote:
<snip>
> > + if (IS_ERR(bdev->bamclk))
> > + return PTR_ERR(bdev->bamclk);
> > +
> > + ret = clk_prepare_enable(bdev->bamclk);
> > + if (ret) {
> > + dev_err(bdev->dev, "failed to prepare/enable clock\n");
> > + return ret;
> > + }
> > +
> > + ret = of_property_read_u32(pdev->dev.of_node, "qcom,ee", &bdev->ee);
> > + if (ret) {
> > + dev_err(bdev->dev, "Execution environment unspecified\n");
> > + return ret;
>
> goto err_disable_clk; ?
>
> >
> > + }
> > +
> > + ret = bam_init(bdev);
> > + if (ret)
> > + return ret;
>
> Ditto.
>
Good catch. I'll fix both of those.
--
sent by an employee of the Qualcomm Innovation Center, Inc.
The Qualcomm Innovation Center, Inc. is a member of the Code Aurora Forum,
hosted by The Linux Foundation
next prev parent reply other threads:[~2014-03-07 23:11 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-03 6:30 [Patch v8 0/2] Add Qualcomm BAM dmaengine driver Andy Gross
2014-03-03 6:30 ` Andy Gross
[not found] ` <1393828245-18766-1-git-send-email-agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-03-03 6:30 ` [Patch v8 1/2] dmaengine: qcom_bam_dma: Add device tree binding Andy Gross
2014-03-03 6:30 ` Andy Gross
2014-03-03 6:30 ` Andy Gross
2014-03-03 6:30 ` [Patch v8 2/2] dmaengine: add Qualcomm BAM dma driver Andy Gross
2014-03-03 6:30 ` Andy Gross
2014-03-03 6:49 ` Joe Perches
2014-03-03 6:49 ` Joe Perches
[not found] ` <1393828245-18766-3-git-send-email-agross-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>
2014-03-03 9:38 ` Shevchenko, Andriy
2014-03-03 9:38 ` Shevchenko, Andriy
2014-03-03 9:38 ` Shevchenko, Andriy
2014-03-07 23:11 ` Andy Gross [this message]
2014-03-07 23:11 ` Andy Gross
2014-03-07 22:29 ` Stanimir Vabanov
2014-03-07 22:29 ` Stanimir Vabanov
2014-03-07 23:07 ` Andy Gross
2014-03-07 23:07 ` Andy Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140307231108.GD3241@qualcomm.com \
--to=agross@codeaurora.org \
--cc=andriy.shevchenko@intel.com \
--cc=dan.j.williams@intel.com \
--cc=devicetree@vger.kernel.org \
--cc=dmaengine@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=vinod.koul@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.