[PATCH 1/2] drivers: mcb: Fix build error discovered by 0-day bot

[PATCH 1/2] drivers: mcb: Fix build error discovered by 0-day bot

[Johannes Thumshirn]

From: Johannes Thumshirn <morbidrsa@gmail.com>

Make mcb depend on HAS_IOMEM and mcb-pci depend on PCI. This fixes build errors
discovered by the 0-day kernel build testing system.

Signed-off-by: Johannes Thumshirn <johannes.thumshirn@men.de>
---
 drivers/mcb/Kconfig | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/drivers/mcb/Kconfig b/drivers/mcb/Kconfig
index b8f5d46..87d5a46 100644
--- a/drivers/mcb/Kconfig
+++ b/drivers/mcb/Kconfig
@@ -4,7 +4,7 @@
 
 menuconfig MCB
 	   tristate "MCB support"
-	   default m
+	   depends on HAS_IOMEM
 	   help
 
 	   The MCB (MEN Chameleon Bus) is a Bus specific to MEN Mikroelektronik
@@ -18,6 +18,7 @@ if MCB
 config MCB_PCI
 	   tristate "PCI based MCB carrier"
 	   default m
+	   depends on PCI
 	   help
 
 	   This is a MCB carrier on a PCI device. Both PCI attached on-board
-- 
1.8.5.3

[PATCH 2/2] iio: adc: Fix build error discovered by 0-day build bot

[Johannes Thumshirn]

From: Johannes Thumshirn <morbidrsa@gmail.com>

men_z188_adc needs to include linux/io.h. This fixes a build error
discovered by 0-day buid bot

Signed-off-by: Johannes Thumshirn <johannes.thumshirn@men.de>
---
 drivers/iio/adc/men_z188_adc.c | 1 +
 1 file changed, 1 insertion(+)

diff --git a/drivers/iio/adc/men_z188_adc.c b/drivers/iio/adc/men_z188_adc.c
index 7036503..6989c16 100644
--- a/drivers/iio/adc/men_z188_adc.c
+++ b/drivers/iio/adc/men_z188_adc.c
@@ -12,6 +12,7 @@
 #include <linux/kernel.h>
 #include <linux/module.h>
 #include <linux/mcb.h>
+#include <linux/io.h>
 #include <linux/iio/iio.h>
 
 #define Z188_ADC_MAX_CHAN	8
-- 
1.8.5.3

Re: [PATCH 2/2] iio: adc: Fix build error discovered by 0-day build bot

[Greg Kroah-Hartman]

On Mon, Mar 03, 2014 at 09:46:49PM +0100, Johannes Thumshirn wrote:
> From: Johannes Thumshirn <morbidrsa@gmail.com>
> 
> men_z188_adc needs to include linux/io.h. This fixes a build error
> discovered by 0-day buid bot
> 
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@men.de>
> ---
>  drivers/iio/adc/men_z188_adc.c | 1 +
>  1 file changed, 1 insertion(+)

Please properly credit who reported the issue with a "Reported-by:"
line.

Also send patches to the correct maintainers using
scripts/get_maintainers.pl, I am not the IIO maintainer.

thanks,

greg k-h

Re: [PATCH 2/2] iio: adc: Fix build error discovered by 0-day build bot

[Greg Kroah-Hartman]

On Sat, Mar 08, 2014 at 09:52:32PM -0800, Greg Kroah-Hartman wrote:
> On Mon, Mar 03, 2014 at 09:46:49PM +0100, Johannes Thumshirn wrote:
> > From: Johannes Thumshirn <morbidrsa@gmail.com>
> > 
> > men_z188_adc needs to include linux/io.h. This fixes a build error
> > discovered by 0-day buid bot
> > 
> > Signed-off-by: Johannes Thumshirn <johannes.thumshirn@men.de>
> > ---
> >  drivers/iio/adc/men_z188_adc.c | 1 +
> >  1 file changed, 1 insertion(+)
> 
> Please properly credit who reported the issue with a "Reported-by:"
> line.
> 
> Also send patches to the correct maintainers using
> scripts/get_maintainers.pl, I am not the IIO maintainer.

Ah, I see I took your previous patch, that makes a bit more sense why
you sent it to me, so I'll queue it up to fix the reported issue...

Re: [PATCH 1/2] drivers: mcb: Fix build error discovered by 0-day bot

[Greg Kroah-Hartman]

On Mon, Mar 03, 2014 at 09:46:48PM +0100, Johannes Thumshirn wrote:
> From: Johannes Thumshirn <morbidrsa@gmail.com>
> 
> Make mcb depend on HAS_IOMEM and mcb-pci depend on PCI. This fixes build errors
> discovered by the 0-day kernel build testing system.
> 
> Signed-off-by: Johannes Thumshirn <johannes.thumshirn@men.de>
> Reported-by: kbuild test robot <fengguang.wu@intel.com>
> ---
>  drivers/mcb/Kconfig | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/mcb/Kconfig b/drivers/mcb/Kconfig
> index b8f5d46..87d5a46 100644
> --- a/drivers/mcb/Kconfig
> +++ b/drivers/mcb/Kconfig
> @@ -4,7 +4,7 @@
>  
>  menuconfig MCB
>  	   tristate "MCB support"
> -	   default m
> +	   depends on HAS_IOMEM
>  	   help
>  
>  	   The MCB (MEN Chameleon Bus) is a Bus specific to MEN Mikroelektronik
> @@ -18,6 +18,7 @@ if MCB
>  config MCB_PCI
>  	   tristate "PCI based MCB carrier"
>  	   default m

This should not be default m either, please redo this against my latest
tree and resend.

thanks,

greg k-h