Re: [Qemu-devel] [PATCH RFC 2/2] qemu-img: migrate to use qemu-arg

[Leandro Dorileo <l@dorileo.org>]

Hi Paolo,

On Sun, Mar 09, 2014 at 08:30:28AM +0100, Paolo Bonzini wrote:
> Il 08/03/2014 19:47, Leandro Dorileo ha scritto:
> >Remove the arg parsing implementations using getopt and use qemu-arg.
> >Also remove the qemu-img-cmds.hx since it's now generated on building time,
> >adapted the build system to generate the .hx file using the qemu-img itself
> >using the qemu-arg internal command generate-hx.
> >
> >Signed-off-by: Leandro Dorileo <l@dorileo.org>
> 
> This makes it much harder to cross-compile QEMU.

What's non-portable in this case? what would limit the QEMU cross-compile?

>  Also, I wonder how hard it
> would be to apply the same approach to the main QEMU binary which already
> uses QemuOpts for its more complex arguments;

Yeah, you're right, QEMU binary is much more complex, In that case I think we
should put QemuOpts and QemuArg together or so, I still need to better understand
the current vl.c + QemuOpt source code to come up with a good solution.

> for sure you risk that
> accumulating multiple layers of abstractions makes the code even harder to
> read than it is now.

The idea is to keep things simple not the other way round. I think it's possible
to accommodate both cases without imposing more complexity.


Regards...

-- 
Leandro Dorileo