From: Paolo Bonzini <pbonzini@redhat.com>
To: Leandro Dorileo <l@dorileo.org>, qemu-devel@nongnu.org
Cc: Kevin Wolf <kwolf@redhat.com>,
Peter Maydell <peter.maydell@linaro.org>,
Fam Zheng <famz@redhat.com>, Stefan Weil <sw@weilnetz.de>,
Michael Tokarev <mjt@tls.msk.ru>,
Stefan Hajnoczi <stefanha@redhat.com>,
Laszlo Ersek <lersek@redhat.com>, Peter Lieven <pl@kamp.de>
Subject: Re: [Qemu-devel] [PATCH RFC 2/2] qemu-img: migrate to use qemu-arg
Date: Sun, 09 Mar 2014 08:30:28 +0100 [thread overview]
Message-ID: <531C1894.8020804@redhat.com> (raw)
In-Reply-To: <1394304438-14848-3-git-send-email-l@dorileo.org>
Il 08/03/2014 19:47, Leandro Dorileo ha scritto:
> Remove the arg parsing implementations using getopt and use qemu-arg.
> Also remove the qemu-img-cmds.hx since it's now generated on building time,
> adapted the build system to generate the .hx file using the qemu-img itself
> using the qemu-arg internal command generate-hx.
>
> Signed-off-by: Leandro Dorileo <l@dorileo.org>
This makes it much harder to cross-compile QEMU. Also, I wonder how
hard it would be to apply the same approach to the main QEMU binary
which already uses QemuOpts for its more complex arguments; for sure you
risk that accumulating multiple layers of abstractions makes the code
even harder to read than it is now.
Paolo
next prev parent reply other threads:[~2014-03-09 7:30 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-08 18:47 [Qemu-devel] [PATCH RFC 0/2] qemu-arg: general purpose argument parser Leandro Dorileo
2014-03-08 18:47 ` [Qemu-devel] [PATCH RFC 1/2] qemu-arg: introduce a " Leandro Dorileo
2014-03-08 18:47 ` [Qemu-devel] [PATCH RFC 2/2] qemu-img: migrate to use qemu-arg Leandro Dorileo
2014-03-09 7:30 ` Paolo Bonzini [this message]
2014-03-09 12:37 ` Leandro Dorileo
2014-03-09 13:03 ` Peter Maydell
2014-03-09 13:35 ` Leandro Dorileo
2014-03-08 18:55 ` [Qemu-devel] [PATCH RFC 0/2] qemu-arg: general purpose argument parser Peter Maydell
2014-03-08 20:28 ` Leandro Dorileo
2014-03-09 16:32 ` Andreas Färber
2014-03-09 21:47 ` Leandro Dorileo
2014-03-11 11:06 ` Kevin Wolf
2014-03-11 14:09 ` Leandro Dorileo
2014-03-11 15:22 ` Eric Blake
2014-03-16 21:23 ` Leandro Dorileo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=531C1894.8020804@redhat.com \
--to=pbonzini@redhat.com \
--cc=famz@redhat.com \
--cc=kwolf@redhat.com \
--cc=l@dorileo.org \
--cc=lersek@redhat.com \
--cc=mjt@tls.msk.ru \
--cc=peter.maydell@linaro.org \
--cc=pl@kamp.de \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
--cc=sw@weilnetz.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.