From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Pekon Gupta <pekon@ti.com>
Cc: Stefan Roese <sr@denx.de>,
avinashphilipk@gmail.com,
Brian Norris <computersforpeace@gmail.com>,
linux-mtd <linux-mtd@lists.infradead.org>,
Felipe Balbi <balbi@ti.com>
Subject: Re: [PATCH v6 4/4] mtd: devices: elm: update DRIVER_NAME as "omap-elm"
Date: Mon, 10 Mar 2014 10:59:46 -0300 [thread overview]
Message-ID: <20140310135946.GD5994@arch.cereza> (raw)
In-Reply-To: <1394197344-9468-5-git-send-email-pekon@ti.com>
On Mar 07, Pekon Gupta wrote:
> use "omap-elm" as DRIVER_NAME
> prefix DRIVER_NAME in debug and error messages
>
> Signed-off-by: Pekon Gupta <pekon@ti.com>
> ---
> drivers/mtd/devices/elm.c | 5 ++++-
> 1 file changed, 4 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/mtd/devices/elm.c b/drivers/mtd/devices/elm.c
> index 43fd81d..16e62ae 100644
> --- a/drivers/mtd/devices/elm.c
> +++ b/drivers/mtd/devices/elm.c
> @@ -15,6 +15,9 @@
> *
> */
>
> +#define DRIVER_NAME "omap-elm"
> +#define pr_fmt(fmt) DRIVER_NAME ": " fmt
> +
As per my previous comment about pr_{} vs. dev_{}, I think
you can now drop the pr_fmt and just leave the name change here.
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
next prev parent reply other threads:[~2014-03-10 14:00 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 13:02 [PATCH v6 0/4] mtd: devices: elm: add checks ELM H/W constrains, driver code cleanup Pekon Gupta
2014-03-07 13:02 ` [PATCH v6 1/4] mtd: devices: elm: check for hardware engine's design constrains Pekon Gupta
2014-03-10 13:35 ` Ezequiel Garcia
2014-03-12 11:08 ` Gupta, Pekon
2014-03-07 13:02 ` [PATCH v6 2/4] mtd: devices: elm: clean elm_load_syndrome Pekon Gupta
2014-03-07 13:02 ` [PATCH v6 3/4] mtd: devices: elm: configure parallel channels based on ecc_steps Pekon Gupta
2014-03-10 14:08 ` Ezequiel Garcia
2014-03-07 13:02 ` [PATCH v6 4/4] mtd: devices: elm: update DRIVER_NAME as "omap-elm" Pekon Gupta
2014-03-10 13:59 ` Ezequiel Garcia [this message]
2014-03-11 10:14 ` [PATCH v6 0/4] mtd: devices: elm: add checks ELM H/W constrains, driver code cleanup Lee Jones
2014-03-11 10:18 ` Gupta, Pekon
2014-03-11 11:47 ` Lee Jones
2014-03-11 11:57 ` Gupta, Pekon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140310135946.GD5994@arch.cereza \
--to=ezequiel.garcia@free-electrons.com \
--cc=avinashphilipk@gmail.com \
--cc=balbi@ti.com \
--cc=computersforpeace@gmail.com \
--cc=linux-mtd@lists.infradead.org \
--cc=pekon@ti.com \
--cc=sr@denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.