Re: [PATCH v6 3/4] mtd: devices: elm: configure parallel channels based on ecc_steps

[Ezequiel Garcia <ezequiel.garcia@free-electrons.com>]

On Mar 07, Pekon Gupta wrote:
> Though ELM hardware can process upto maximum of 8 channels in parallel for
> ECC error detection. But actual number of channels need to be processed in
> parallel depends on ecc_steps (for page mode configuration).
>
 
This commit log needs some love ;) How about something along these lines:

"ELM hardware can process up to ERR_VECTOR_MAX channels in parallel for
ECC error detection. However, the actual number of channels that need to
be processed is the ECC step number." ?

Perhaps you could add some more information (I'm not too familiar with ELM),
what's the impact of this change? Does it fix any bug or the over-looping
was harmless?

> Signed-off-by: Pekon Gupta <pekon@ti.com>
> ---
>  drivers/mtd/devices/elm.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/mtd/devices/elm.c b/drivers/mtd/devices/elm.c
> index f59c100..43fd81d 100644
> --- a/drivers/mtd/devices/elm.c
> +++ b/drivers/mtd/devices/elm.c
> @@ -174,7 +174,7 @@ static void elm_load_syndrome(struct elm_info *info,
>  	int i, offset;
>  	u32 val;
>  
> -	for (i = 0; i < ERROR_VECTOR_MAX; i++) {
> +	for (i = 0; i < info->ecc_steps; i++) {

I think it would be less confusing if you can add the ecc_steps field on this
patch, where you start to use it.
-- 
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com