From: "J. Bruce Fields" <bfields@fieldses.org>
To: Jeff Layton <jlayton@redhat.com>
Cc: linux-nfs@vger.kernel.org
Subject: Re: [PATCH] svcrdma: fix printk when memory allocation fails
Date: Mon, 10 Mar 2014 14:30:52 -0400 [thread overview]
Message-ID: <20140310183052.GC28006@fieldses.org> (raw)
In-Reply-To: <20140310183024.GB28006@fieldses.org>
On Mon, Mar 10, 2014 at 02:30:24PM -0400, J. Bruce Fields wrote:
> On Mon, Mar 10, 2014 at 11:33:48AM -0400, Jeff Layton wrote:
> > It retries in 1s, not 1000 jiffies.
>
> Queueing for 3.14, thanks.--b.
(Um, 3.15. I lose track.)
--b.
>
> >
> > Signed-off-by: Jeff Layton <jlayton@redhat.com>
> > ---
> > net/sunrpc/xprtrdma/svc_rdma_transport.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c
> > index 62e4f9bcc387..25688fa2207f 100644
> > --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c
> > +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c
> > @@ -477,8 +477,7 @@ struct page *svc_rdma_get_page(void)
> >
> > while ((page = alloc_page(GFP_KERNEL)) == NULL) {
> > /* If we can't get memory, wait a bit and try again */
> > - printk(KERN_INFO "svcrdma: out of memory...retrying in 1000 "
> > - "jiffies.\n");
> > + printk(KERN_INFO "svcrdma: out of memory...retrying in 1s\n");
> > schedule_timeout_uninterruptible(msecs_to_jiffies(1000));
> > }
> > return page;
> > --
> > 1.8.5.3
> >
prev parent reply other threads:[~2014-03-10 18:30 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 15:33 [PATCH] svcrdma: fix printk when memory allocation fails Jeff Layton
2014-03-10 18:30 ` J. Bruce Fields
2014-03-10 18:30 ` J. Bruce Fields [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140310183052.GC28006@fieldses.org \
--to=bfields@fieldses.org \
--cc=jlayton@redhat.com \
--cc=linux-nfs@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.