* [PATCH] svcrdma: fix printk when memory allocation fails
@ 2014-03-10 15:33 Jeff Layton
2014-03-10 18:30 ` J. Bruce Fields
0 siblings, 1 reply; 3+ messages in thread
From: Jeff Layton @ 2014-03-10 15:33 UTC (permalink / raw)
To: bfields; +Cc: linux-nfs
It retries in 1s, not 1000 jiffies.
Signed-off-by: Jeff Layton <jlayton@redhat.com>
---
net/sunrpc/xprtrdma/svc_rdma_transport.c | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c
index 62e4f9bcc387..25688fa2207f 100644
--- a/net/sunrpc/xprtrdma/svc_rdma_transport.c
+++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c
@@ -477,8 +477,7 @@ struct page *svc_rdma_get_page(void)
while ((page = alloc_page(GFP_KERNEL)) == NULL) {
/* If we can't get memory, wait a bit and try again */
- printk(KERN_INFO "svcrdma: out of memory...retrying in 1000 "
- "jiffies.\n");
+ printk(KERN_INFO "svcrdma: out of memory...retrying in 1s\n");
schedule_timeout_uninterruptible(msecs_to_jiffies(1000));
}
return page;
--
1.8.5.3
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] svcrdma: fix printk when memory allocation fails
2014-03-10 15:33 [PATCH] svcrdma: fix printk when memory allocation fails Jeff Layton
@ 2014-03-10 18:30 ` J. Bruce Fields
2014-03-10 18:30 ` J. Bruce Fields
0 siblings, 1 reply; 3+ messages in thread
From: J. Bruce Fields @ 2014-03-10 18:30 UTC (permalink / raw)
To: Jeff Layton; +Cc: linux-nfs
On Mon, Mar 10, 2014 at 11:33:48AM -0400, Jeff Layton wrote:
> It retries in 1s, not 1000 jiffies.
Queueing for 3.14, thanks.--b.
>
> Signed-off-by: Jeff Layton <jlayton@redhat.com>
> ---
> net/sunrpc/xprtrdma/svc_rdma_transport.c | 3 +--
> 1 file changed, 1 insertion(+), 2 deletions(-)
>
> diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c
> index 62e4f9bcc387..25688fa2207f 100644
> --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c
> +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c
> @@ -477,8 +477,7 @@ struct page *svc_rdma_get_page(void)
>
> while ((page = alloc_page(GFP_KERNEL)) == NULL) {
> /* If we can't get memory, wait a bit and try again */
> - printk(KERN_INFO "svcrdma: out of memory...retrying in 1000 "
> - "jiffies.\n");
> + printk(KERN_INFO "svcrdma: out of memory...retrying in 1s\n");
> schedule_timeout_uninterruptible(msecs_to_jiffies(1000));
> }
> return page;
> --
> 1.8.5.3
>
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] svcrdma: fix printk when memory allocation fails
2014-03-10 18:30 ` J. Bruce Fields
@ 2014-03-10 18:30 ` J. Bruce Fields
0 siblings, 0 replies; 3+ messages in thread
From: J. Bruce Fields @ 2014-03-10 18:30 UTC (permalink / raw)
To: Jeff Layton; +Cc: linux-nfs
On Mon, Mar 10, 2014 at 02:30:24PM -0400, J. Bruce Fields wrote:
> On Mon, Mar 10, 2014 at 11:33:48AM -0400, Jeff Layton wrote:
> > It retries in 1s, not 1000 jiffies.
>
> Queueing for 3.14, thanks.--b.
(Um, 3.15. I lose track.)
--b.
>
> >
> > Signed-off-by: Jeff Layton <jlayton@redhat.com>
> > ---
> > net/sunrpc/xprtrdma/svc_rdma_transport.c | 3 +--
> > 1 file changed, 1 insertion(+), 2 deletions(-)
> >
> > diff --git a/net/sunrpc/xprtrdma/svc_rdma_transport.c b/net/sunrpc/xprtrdma/svc_rdma_transport.c
> > index 62e4f9bcc387..25688fa2207f 100644
> > --- a/net/sunrpc/xprtrdma/svc_rdma_transport.c
> > +++ b/net/sunrpc/xprtrdma/svc_rdma_transport.c
> > @@ -477,8 +477,7 @@ struct page *svc_rdma_get_page(void)
> >
> > while ((page = alloc_page(GFP_KERNEL)) == NULL) {
> > /* If we can't get memory, wait a bit and try again */
> > - printk(KERN_INFO "svcrdma: out of memory...retrying in 1000 "
> > - "jiffies.\n");
> > + printk(KERN_INFO "svcrdma: out of memory...retrying in 1s\n");
> > schedule_timeout_uninterruptible(msecs_to_jiffies(1000));
> > }
> > return page;
> > --
> > 1.8.5.3
> >
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2014-03-10 18:30 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2014-03-10 15:33 [PATCH] svcrdma: fix printk when memory allocation fails Jeff Layton
2014-03-10 18:30 ` J. Bruce Fields
2014-03-10 18:30 ` J. Bruce Fields
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.