From: lee.jones@linaro.org (Lee Jones)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/5] pinctrl: st: Enhance the controller to manage unavailable registers
Date: Tue, 11 Mar 2014 11:12:34 +0000 [thread overview]
Message-ID: <20140311111234.GA21216@lee--X1> (raw)
In-Reply-To: <531EC6C0.4080202@st.com>
> >>From: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> >>
> >>This patch adds a new logic inside the st pinctrl to manage
> >>an unsupported scenario: some sysconfig are not available!
> >>
> >>This is the case of STiH407 where, although documented, the
> >>following registers from SYSCFG_FLASH have been removed from the SoC.
> >>
> >>SYSTEM_CONFIG3040
> >> Output Enable pad control for all PIO Alternate Functions
> >>and
> >>SYSTEM_ CONFIG3050
> >> Pull Up pad control for all PIO Alternate Functions
> >>
> >>Without managing this condition an imprecise external abort
> >>will be detect.
> >>
> >>To do this the patch also reviews the st_parse_syscfgs
> >>and other routines to manipulate the registers only if
> >>actually available.
> >>In any case, for example the st_parse_syscfgs detected
> >>an error condition but no action was made in the
> >>st_pctl_probe_dt.
> >>
> >>Signed-off-by: Maxime Coquelin <maxime.coquelin@st.com>
> >>Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
No problem with any of your comments. Once the fixups have been made,
feel free to apply my:
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org ? Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
WARNING: multiple messages have this Message-ID (diff)
From: Lee Jones <lee.jones@linaro.org>
To: Maxime Coquelin <maxime.coquelin@st.com>
Cc: Rob Landley <rob@landley.net>, Rob Herring <robh+dt@kernel.org>,
Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Russell King <linux@arm.linux.org.uk>,
Srinivas Kandagatla <srinivas.kandagatla@st.com>,
Stuart Menefy <stuart.menefy@st.com>,
Linus Walleij <linus.walleij@linaro.org>,
Giuseppe Cavallaro <peppe.cavallaro@st.com>,
linux-doc@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org,
kernel@stlinux.com
Subject: Re: [PATCH v3 2/5] pinctrl: st: Enhance the controller to manage unavailable registers
Date: Tue, 11 Mar 2014 11:12:34 +0000 [thread overview]
Message-ID: <20140311111234.GA21216@lee--X1> (raw)
In-Reply-To: <531EC6C0.4080202@st.com>
> >>From: Giuseppe Cavallaro <peppe.cavallaro@st.com>
> >>
> >>This patch adds a new logic inside the st pinctrl to manage
> >>an unsupported scenario: some sysconfig are not available!
> >>
> >>This is the case of STiH407 where, although documented, the
> >>following registers from SYSCFG_FLASH have been removed from the SoC.
> >>
> >>SYSTEM_CONFIG3040
> >> Output Enable pad control for all PIO Alternate Functions
> >>and
> >>SYSTEM_ CONFIG3050
> >> Pull Up pad control for all PIO Alternate Functions
> >>
> >>Without managing this condition an imprecise external abort
> >>will be detect.
> >>
> >>To do this the patch also reviews the st_parse_syscfgs
> >>and other routines to manipulate the registers only if
> >>actually available.
> >>In any case, for example the st_parse_syscfgs detected
> >>an error condition but no action was made in the
> >>st_pctl_probe_dt.
> >>
> >>Signed-off-by: Maxime Coquelin <maxime.coquelin@st.com>
> >>Signed-off-by: Giuseppe Cavallaro <peppe.cavallaro@st.com>
No problem with any of your comments. Once the fixups have been made,
feel free to apply my:
Acked-by: Lee Jones <lee.jones@linaro.org>
--
Lee Jones
Linaro STMicroelectronics Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2014-03-11 11:12 UTC|newest]
Thread overview: 53+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-07 14:40 [PATCH v3 0/5] Add STiH407 SoC and reference board support Maxime COQUELIN
2014-03-07 14:40 ` Maxime COQUELIN
2014-03-07 14:40 ` Maxime COQUELIN
2014-03-07 14:40 ` [PATCH v3 1/5] ARM: STi: Add STiH407 SoC support Maxime COQUELIN
2014-03-07 14:40 ` Maxime COQUELIN
2014-03-10 12:34 ` Lee Jones
2014-03-10 12:34 ` Lee Jones
2014-03-10 12:34 ` Lee Jones
2014-03-11 13:56 ` Maxime Coquelin
2014-03-11 13:56 ` Maxime Coquelin
2014-03-11 13:56 ` Maxime Coquelin
2014-03-07 14:40 ` [PATCH v3 2/5] pinctrl: st: Enhance the controller to manage unavailable registers Maxime COQUELIN
2014-03-07 14:40 ` Maxime COQUELIN
2014-03-07 15:37 ` srinivas kandagatla
2014-03-07 15:37 ` srinivas kandagatla
2014-03-07 15:37 ` srinivas kandagatla
2014-03-10 9:17 ` Lee Jones
2014-03-10 9:17 ` Lee Jones
2014-03-11 8:18 ` Maxime Coquelin
2014-03-11 8:18 ` Maxime Coquelin
2014-03-11 8:18 ` Maxime Coquelin
2014-03-11 10:55 ` Maxime Coquelin
2014-03-11 10:55 ` Maxime Coquelin
2014-03-11 10:55 ` Maxime Coquelin
2014-03-11 11:13 ` Lee Jones
2014-03-11 11:13 ` Lee Jones
2014-03-11 11:12 ` Lee Jones [this message]
2014-03-11 11:12 ` Lee Jones
2014-03-07 14:40 ` [PATCH v3 3/5] pinctrl: st: add pinctrl support for the STiH407 SoC Maxime COQUELIN
2014-03-07 14:40 ` Maxime COQUELIN
2014-03-07 15:36 ` srinivas kandagatla
2014-03-07 15:36 ` srinivas kandagatla
2014-03-07 15:36 ` srinivas kandagatla
2014-03-10 14:44 ` Lee Jones
2014-03-10 14:44 ` Lee Jones
2014-03-11 8:52 ` Maxime Coquelin
2014-03-11 8:52 ` Maxime Coquelin
2014-03-11 8:52 ` Maxime Coquelin
2014-03-07 14:40 ` [PATCH v3 4/5] ARM: dts: Add STiH407 SoC support Maxime COQUELIN
2014-03-07 14:40 ` Maxime COQUELIN
2014-03-07 14:40 ` Maxime COQUELIN
2014-03-10 12:28 ` Lee Jones
2014-03-10 12:28 ` Lee Jones
2014-03-10 12:28 ` Lee Jones
2014-03-10 16:16 ` Lee Jones
2014-03-10 16:16 ` Lee Jones
2014-03-11 10:09 ` Maxime Coquelin
2014-03-11 10:09 ` Maxime Coquelin
2014-03-11 10:09 ` Maxime Coquelin
2014-03-07 14:40 ` [PATCH v3 5/5] ARM: dts: STiH407: Add B2120 board support Maxime COQUELIN
2014-03-07 14:40 ` Maxime COQUELIN
2014-03-10 12:37 ` Lee Jones
2014-03-10 12:37 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140311111234.GA21216@lee--X1 \
--to=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.