From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Jan Beulich <JBeulich@suse.com>
Cc: Konrad Rzeszutek Wilk <konrad@kernel.org>,
aravind.gopalakrishnan@amd.com, xen-devel@lists.xenproject.org,
andrew.cooper3@citrix.com
Subject: Re: [PATCH 5/6] pci: Use #defines for PCI vendors.
Date: Tue, 11 Mar 2014 11:15:57 -0400 [thread overview]
Message-ID: <20140311151557.GI13345@phenom.dumpdata.com> (raw)
In-Reply-To: <531ED8EA0200007800122ABD@nat28.tlf.novell.com>
On Tue, Mar 11, 2014 at 08:35:38AM +0000, Jan Beulich wrote:
> >>> On 10.03.14 at 20:35, Konrad Rzeszutek Wilk <konrad@kernel.org> wrote:
> > --- /dev/null
> > +++ b/xen/include/xen/pci_ids.h
> > @@ -0,0 +1,9 @@
> > +#define PCI_VENDOR_ID_AMD 0x1022
> > +
> > +#define PCI_VENDOR_ID_BROADCOM 0x14e4
> > +
> > +#define PCI_VENDOR_ID_INTEL 0x8086
> > +
> > +#define PCI_VENDOR_ID_NVIDIA 0x10de
> > +
> > +#define PCI_VENDOR_ID_OXSEMI 0x1415
>
> If I'm going to be the one to commit this (and I don't forget), I'll
> take the liberty of sorting these numerically, matching Linux and
> making imo lookup easier, since especially considering company
> acquires/mergers the name to look for may be ambiguous.
Of course. I think I am depending on you to merge them as I don't
have the commit access.
If you would like, I can pluck them in a git tree with this above
fixed and your Reviewed-by added and I can just send you a GIT PULL
request.
Thank you!
>
> Jan
>
next prev parent reply other threads:[~2014-03-11 15:16 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-10 19:35 [PATCH v3] Enable serial output for Oxford Semiconductor PCIe cards and fix bugs Konrad Rzeszutek Wilk
2014-03-10 19:35 ` [PATCH 1/6] serial: Skip over PCIe device which have no quirks (fix AMT regression) Konrad Rzeszutek Wilk
2014-03-10 19:35 ` [PATCH 2/6] serial: Fix COM1 assumption if pci_uart_config did not find the AMT card Konrad Rzeszutek Wilk
2014-03-10 19:35 ` [PATCH 3/6] serial: Support OXPCIe952 aka Oxford Semiconductor Ltd Device c138 (1415:c138) Konrad Rzeszutek Wilk
2014-03-10 19:35 ` [PATCH 4/6] serial: Seperate the PCI device ids and parameters (v1) Konrad Rzeszutek Wilk
2014-03-10 19:35 ` [PATCH 5/6] pci: Use #defines for PCI vendors Konrad Rzeszutek Wilk
2014-03-11 8:35 ` Jan Beulich
2014-03-11 15:15 ` Konrad Rzeszutek Wilk [this message]
2014-03-11 16:00 ` Jan Beulich
2014-03-10 19:35 ` [PATCH 6/6] serial: Expand the PCI serial quirks for OXPCIe200 and OXPCIe952 1 Native UART Konrad Rzeszutek Wilk
2014-03-11 8:30 ` [PATCH v3] Enable serial output for Oxford Semiconductor PCIe cards and fix bugs Jan Beulich
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140311151557.GI13345@phenom.dumpdata.com \
--to=konrad.wilk@oracle.com \
--cc=JBeulich@suse.com \
--cc=andrew.cooper3@citrix.com \
--cc=aravind.gopalakrishnan@amd.com \
--cc=konrad@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.