From: mporter@linaro.org (Matt Porter)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v3 2/5] mfd: add bcm590xx pmu driver
Date: Tue, 11 Mar 2014 19:25:45 -0400 [thread overview]
Message-ID: <20140311232545.GP25092@beef> (raw)
In-Reply-To: <20140311224517.GA5672@lee--X1>
On Tue, Mar 11, 2014 at 10:45:17PM +0000, Lee Jones wrote:
> > > > Add a driver for the BCM590xx PMU multi-function devices. The driver
> > > > initially supports regmap initialization and instantiation of the
> > > > voltage regulator device function of the PMU.
> > > >
> > > > Signed-off-by: Matt Porter <mporter@linaro.org>
> > > > Reviewed-by: Tim Kryger <tim.kryger@linaro.org>
> > > > Reviewed-by: Markus Mayer <markus.mayer@linaro.org>
> > > > ---
> > > > drivers/mfd/Kconfig | 8 ++++
> > > > drivers/mfd/Makefile | 1 +
> > > > drivers/mfd/bcm590xx.c | 93 ++++++++++++++++++++++++++++++++++++++++++++
> > > > include/linux/mfd/bcm590xx.h | 31 +++++++++++++++
> > > > 4 files changed, 133 insertions(+)
> > > > create mode 100644 drivers/mfd/bcm590xx.c
> > > > create mode 100644 include/linux/mfd/bcm590xx.h
> > >
> > > I have a tiny nit that 'ret' doesn't need to be initialised before
> > > use in probe(), but apart from that...
> > >
> > > Looks pretty sensible:
> > > Acked-by: Lee Jones <lee.jones@linaro.org>
> >
> > Ok, thanks. When I get back in front of my desktop I'll send a v4 of
> > just this patch to address that nit. Mark already applied the regulator
> > driver from this series, will you be taking this through your tree? For
> > that matter, I wonder if the binding would also go through your tree
> > with this driver.
>
> At least the MFD portion and the DT binding doc will go through the
> MFD tree.
>
> Are there any inter-patch dependencies in the set? If so, we should
> know about them so we can coordinate a sensible solution.
Yes, the regulator driver (3/5) that Mark applied is dependent on this
patch...the regulator driver includes include/linux/mfd/bcm590xx.h.
-Matt
WARNING: multiple messages have this Message-ID (diff)
From: Matt Porter <mporter-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
To: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
Cc: Rob Herring <robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Pawel Moll <pawel.moll-5wv7dgnIgG8@public.gmane.org>,
Mark Rutland <mark.rutland-5wv7dgnIgG8@public.gmane.org>,
Ian Campbell
<ijc+devicetree-KcIKpvwj1kUDXYZnReoRVg@public.gmane.org>,
Kumar Gala <galak-sgV2jX0FEOL9JmXXK+q4OQ@public.gmane.org>,
Samuel Ortiz <sameo-VuQAYsv1563Yd54FQh9/CA@public.gmane.org>,
Liam Girdwood <lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>,
Mark Brown <broonie-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>,
Christian Daudt <bcm-xK7y4jjYLqYh9ZMKESR00Q@public.gmane.org>,
Devicetree List
<devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>,
Linux ARM Kernel List
<linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>,
Linux Kernel Mailing List
<linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>
Subject: Re: [PATCH v3 2/5] mfd: add bcm590xx pmu driver
Date: Tue, 11 Mar 2014 19:25:45 -0400 [thread overview]
Message-ID: <20140311232545.GP25092@beef> (raw)
In-Reply-To: <20140311224517.GA5672@lee--X1>
On Tue, Mar 11, 2014 at 10:45:17PM +0000, Lee Jones wrote:
> > > > Add a driver for the BCM590xx PMU multi-function devices. The driver
> > > > initially supports regmap initialization and instantiation of the
> > > > voltage regulator device function of the PMU.
> > > >
> > > > Signed-off-by: Matt Porter <mporter-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> > > > Reviewed-by: Tim Kryger <tim.kryger-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> > > > Reviewed-by: Markus Mayer <markus.mayer-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> > > > ---
> > > > drivers/mfd/Kconfig | 8 ++++
> > > > drivers/mfd/Makefile | 1 +
> > > > drivers/mfd/bcm590xx.c | 93 ++++++++++++++++++++++++++++++++++++++++++++
> > > > include/linux/mfd/bcm590xx.h | 31 +++++++++++++++
> > > > 4 files changed, 133 insertions(+)
> > > > create mode 100644 drivers/mfd/bcm590xx.c
> > > > create mode 100644 include/linux/mfd/bcm590xx.h
> > >
> > > I have a tiny nit that 'ret' doesn't need to be initialised before
> > > use in probe(), but apart from that...
> > >
> > > Looks pretty sensible:
> > > Acked-by: Lee Jones <lee.jones-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org>
> >
> > Ok, thanks. When I get back in front of my desktop I'll send a v4 of
> > just this patch to address that nit. Mark already applied the regulator
> > driver from this series, will you be taking this through your tree? For
> > that matter, I wonder if the binding would also go through your tree
> > with this driver.
>
> At least the MFD portion and the DT binding doc will go through the
> MFD tree.
>
> Are there any inter-patch dependencies in the set? If so, we should
> know about them so we can coordinate a sensible solution.
Yes, the regulator driver (3/5) that Mark applied is dependent on this
patch...the regulator driver includes include/linux/mfd/bcm590xx.h.
-Matt
--
To unsubscribe from this list: send the line "unsubscribe devicetree" in
the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
WARNING: multiple messages have this Message-ID (diff)
From: Matt Porter <mporter@linaro.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: Rob Herring <robh+dt@kernel.org>, Pawel Moll <pawel.moll@arm.com>,
Mark Rutland <mark.rutland@arm.com>,
Ian Campbell <ijc+devicetree@hellion.org.uk>,
Kumar Gala <galak@codeaurora.org>,
Samuel Ortiz <sameo@linux.intel.com>,
Liam Girdwood <lgirdwood@gmail.com>,
Mark Brown <broonie@kernel.org>,
Christian Daudt <bcm@fixthebug.org>,
Devicetree List <devicetree@vger.kernel.org>,
Linux ARM Kernel List <linux-arm-kernel@lists.infradead.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH v3 2/5] mfd: add bcm590xx pmu driver
Date: Tue, 11 Mar 2014 19:25:45 -0400 [thread overview]
Message-ID: <20140311232545.GP25092@beef> (raw)
In-Reply-To: <20140311224517.GA5672@lee--X1>
On Tue, Mar 11, 2014 at 10:45:17PM +0000, Lee Jones wrote:
> > > > Add a driver for the BCM590xx PMU multi-function devices. The driver
> > > > initially supports regmap initialization and instantiation of the
> > > > voltage regulator device function of the PMU.
> > > >
> > > > Signed-off-by: Matt Porter <mporter@linaro.org>
> > > > Reviewed-by: Tim Kryger <tim.kryger@linaro.org>
> > > > Reviewed-by: Markus Mayer <markus.mayer@linaro.org>
> > > > ---
> > > > drivers/mfd/Kconfig | 8 ++++
> > > > drivers/mfd/Makefile | 1 +
> > > > drivers/mfd/bcm590xx.c | 93 ++++++++++++++++++++++++++++++++++++++++++++
> > > > include/linux/mfd/bcm590xx.h | 31 +++++++++++++++
> > > > 4 files changed, 133 insertions(+)
> > > > create mode 100644 drivers/mfd/bcm590xx.c
> > > > create mode 100644 include/linux/mfd/bcm590xx.h
> > >
> > > I have a tiny nit that 'ret' doesn't need to be initialised before
> > > use in probe(), but apart from that...
> > >
> > > Looks pretty sensible:
> > > Acked-by: Lee Jones <lee.jones@linaro.org>
> >
> > Ok, thanks. When I get back in front of my desktop I'll send a v4 of
> > just this patch to address that nit. Mark already applied the regulator
> > driver from this series, will you be taking this through your tree? For
> > that matter, I wonder if the binding would also go through your tree
> > with this driver.
>
> At least the MFD portion and the DT binding doc will go through the
> MFD tree.
>
> Are there any inter-patch dependencies in the set? If so, we should
> know about them so we can coordinate a sensible solution.
Yes, the regulator driver (3/5) that Mark applied is dependent on this
patch...the regulator driver includes include/linux/mfd/bcm590xx.h.
-Matt
next prev parent reply other threads:[~2014-03-11 23:25 UTC|newest]
Thread overview: 36+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-11 15:46 [PATCH v3 0/5] BCM59056 PMU regulator support Matt Porter
2014-03-11 15:46 ` Matt Porter
2014-03-11 15:46 ` Matt Porter
2014-03-11 15:46 ` [PATCH v3 1/5] mfd: add bcm590xx pmu DT binding Matt Porter
2014-03-11 15:46 ` Matt Porter
2014-03-11 15:46 ` Matt Porter
2014-03-11 15:46 ` [PATCH v3 2/5] mfd: add bcm590xx pmu driver Matt Porter
2014-03-11 15:46 ` Matt Porter
2014-03-11 16:08 ` Lee Jones
2014-03-11 16:08 ` Lee Jones
2014-03-11 16:08 ` Lee Jones
2014-03-11 22:19 ` Matt Porter
2014-03-11 22:19 ` Matt Porter
2014-03-11 22:45 ` Lee Jones
2014-03-11 22:45 ` Lee Jones
2014-03-11 23:25 ` Matt Porter [this message]
2014-03-11 23:25 ` Matt Porter
2014-03-11 23:25 ` Matt Porter
2014-03-12 0:40 ` Mark Brown
2014-03-12 0:40 ` Mark Brown
2014-03-12 0:40 ` Mark Brown
2014-03-12 0:57 ` Matt Porter
2014-03-12 0:57 ` Matt Porter
2014-03-12 9:23 ` Lee Jones
2014-03-12 9:23 ` Lee Jones
2014-03-12 9:23 ` Lee Jones
2014-03-12 9:35 ` Lee Jones
2014-03-12 9:35 ` Lee Jones
2014-03-11 15:46 ` [PATCH v3 3/5] regulator: add bcm590xx regulator driver Matt Porter
2014-03-11 15:46 ` Matt Porter
2014-03-11 18:52 ` Mark Brown
2014-03-11 18:52 ` Mark Brown
2014-03-11 15:46 ` [PATCH v3 4/5] ARM: configs: bcm_defconfig: enable bcm590xx regulator support Matt Porter
2014-03-11 15:46 ` Matt Porter
2014-03-11 15:46 ` [PATCH v3 5/5] ARM: dts: add bcm590xx pmu support and enable for bcm28155-ap Matt Porter
2014-03-11 15:46 ` Matt Porter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140311232545.GP25092@beef \
--to=mporter@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.