All of lore.kernel.org
 help / color / mirror / Atom feed
From: Julian Wollrath <jwollrath@web.de>
To: joeyli <jlee@suse.com>
Cc: Thomas Gleixner <tglx@linutronix.de>,
	x86@kernel.org, LKML <linux-kernel@vger.kernel.org>,
	Lee@linutronix.de,
	"Rafael J. Wysocki" <rafael.j.wysocki@intel.com>
Subject: Re: [RESEND] Fast TSC calibration fails with v3.14-rc1 and later
Date: Wed, 12 Mar 2014 11:20:10 +0100	[thread overview]
Message-ID: <20140312112010.48e46749@ilfaris> (raw)
In-Reply-To: <1394596807.26565.135.camel@linux-s257.site>

> This patch restricts the position to run acpi_early_init() before
> timekeeping_init() when only "CMOS RTC Not Present" bit set in FADT.
> 
> Could you please help to test it on your machine?
That patch fixes the problem, thank you.

Cheers,
Julian Wollrath
> 
> 
> Thanks a lot!
> Joey Lee
> 
> 
> >From 8ef4fff76dd2f50bef1e8eb9c96f3b0228a38401 Mon Sep 17 00:00:00
> >2001
> From: Lee, Chun-Yi <jlee@suse.com>
> Date: Wed, 12 Mar 2014 11:36:32 +0800
> Subject: [PATCH] ACPI / init: Run acpi_early_init() before
> timekeeping_init() when CMOS RTC Not Present bit set
> 
> This is a variant patch from Rafael J. Wysocki's
> ACPI / init: Run acpi_early_init() before efi_enter_virtual_mode()
> 
> According to Matt Fleming, if acpi_early_init() was executed before
> efi_enter_virtual_mode(), the EFI initialization could benefit from
> it, so Rafael's patch makes that happen.
> 
> And, later we want accessing ACPI TAD device to set system clock, so
> move acpi_early_init() before timekeeping_init() when "CMOS RTC Not
> Present" bit set. This position is also before
> efi_enter_virtual_mode().
> 
> Signed-off-by: Lee, Chun-Yi <jlee@suse.com>
> ---
>  init/main.c |    7 ++++++-
>  1 files changed, 6 insertions(+), 1 deletions(-)
> 
> diff --git a/init/main.c b/init/main.c
> index eb03090..e1b69d2 100644
> --- a/init/main.c
> +++ b/init/main.c
> @@ -561,7 +561,9 @@ asmlinkage void __init start_kernel(void)
>  	init_timers();
>  	hrtimers_init();
>  	softirq_init();
> -	acpi_early_init();
> +	if (acpi_gbl_FADT.header.revision >= 5 &&
> +	    acpi_gbl_FADT.boot_flags & ACPI_FADT_NO_CMOS_RTC)
> +		acpi_early_init();
>  	timekeeping_init();
>  	time_init();
>  	sched_clock_postinit();
> @@ -613,6 +615,9 @@ asmlinkage void __init start_kernel(void)
>  	calibrate_delay();
>  	pidmap_init();
>  	anon_vma_init();
> +	if (!(acpi_gbl_FADT.header.revision >= 5 &&
> +	      acpi_gbl_FADT.boot_flags & ACPI_FADT_NO_CMOS_RTC))
> +		acpi_early_init();
>  #ifdef CONFIG_X86
>  	if (efi_enabled(EFI_RUNTIME_SERVICES))
>  		efi_enter_virtual_mode();


  reply	other threads:[~2014-03-12 10:20 UTC|newest]

Thread overview: 41+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-03-10 10:04 [RESEND] Fast TSC calibration fails with v3.14-rc1 and later Julian Wollrath
2014-03-10 10:27 ` Paul Bolle
2014-03-10 14:06   ` Thomas Gleixner
2014-03-10 15:28     ` Paul Bolle
2014-03-10 17:04       ` Thomas Gleixner
2014-03-10 18:32         ` Paul Bolle
2014-03-10 18:57           ` Thomas Gleixner
2014-03-10 19:19             ` Paul Bolle
2014-03-10 20:50               ` Thomas Gleixner
2014-03-10 23:06                 ` Paul Bolle
2014-03-11 16:02                   ` Thomas Gleixner
2014-03-11 13:27       ` Julian Wollrath
2014-03-10 10:39 ` Thomas Gleixner
2014-03-11 13:29   ` Julian Wollrath
2014-03-11 13:56     ` Thomas Gleixner
2014-03-11 17:15       ` Julian Wollrath
2014-03-12  4:00         ` joeyli
2014-03-12 10:20           ` Julian Wollrath [this message]
2014-03-12 13:52             ` joeyli
2014-03-12 11:20           ` Rafael J. Wysocki
2014-03-12 13:30             ` Rafael J. Wysocki
2014-03-12 13:55               ` Julian Wollrath
2014-03-12 15:41               ` joeyli
2014-03-12 16:20                 ` Thomas Gleixner
2014-03-12 16:23                   ` Thomas Gleixner
2014-03-12 16:39                     ` Thomas Gleixner
2014-03-12 23:27                       ` Rafael J. Wysocki
2014-03-12 23:49                         ` Thomas Gleixner
2014-03-13  0:13                           ` Rafael J. Wysocki
2014-03-13  2:56                           ` joeyli
2014-03-13  0:54                         ` Thomas Gleixner
2014-03-13  1:01                           ` Thomas Gleixner
2014-03-13  2:38                           ` joeyli
2014-03-13  3:11                             ` H. Peter Anvin
2014-03-13  3:55                               ` joeyli
2014-03-13  3:59                                 ` H. Peter Anvin
2014-03-13  4:12                                   ` joeyli
2014-03-13  8:12                                     ` Thomas Gleixner
2014-03-13  8:59                                       ` joeyli
2014-03-13  3:41                           ` H. Peter Anvin
2014-03-12 14:00             ` joeyli

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20140312112010.48e46749@ilfaris \
    --to=jwollrath@web.de \
    --cc=Lee@linutronix.de \
    --cc=jlee@suse.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=rafael.j.wysocki@intel.com \
    --cc=tglx@linutronix.de \
    --cc=x86@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.