From: Matt Roper <matthew.d.roper@intel.com>
To: Bob Paauwe <bob.j.paauwe@intel.com>
Cc: dri-devel@lists.freedesktop.org
Subject: Re: [RFCv2 05/10] drm: Add plane type property
Date: Wed, 12 Mar 2014 09:43:11 -0700 [thread overview]
Message-ID: <20140312164311.GG6117@intel.com> (raw)
In-Reply-To: <20140311164500.16e2316b@bpaauwe-desk.fm.intel.com>
On Tue, Mar 11, 2014 at 04:45:00PM -0700, Bob Paauwe wrote:
> On Fri, 7 Mar 2014 16:03:17 -0800
> Matt Roper <matthew.d.roper@intel.com> wrote:
...
> > +static int drm_mode_create_standard_plane_properties(struct drm_device *dev)
> > +{
> > + struct drm_property *type;
> > +
> > + /*
> > + * Standard properties (apply to all planes)
> > + */
> > + type = drm_property_create_enum(dev, 0,
> > + "TYPE", drm_plane_type_enum_list,
> > + ARRAY_SIZE(drm_plane_type_enum_list));
>
> Should this property be created with DRM_MODE_PROP_IMMUTABLE set? What
> happens if user space tries to change this property to a different type?
>
Yep, good point. I'll add that flag in my next revision of the
patchset.
Thanks!
Matt
--
Matt Roper
Graphics Software Engineer
ISG Platform Enabling & Development
Intel Corporation
(916) 356-2795
next prev parent reply other threads:[~2014-03-12 16:43 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-08 0:03 [RFCv2 00/10] Universal plane support Matt Roper
2014-03-08 0:03 ` [RFCv2 01/10] drm: Add support for multiple plane types Matt Roper
2014-03-08 0:03 ` [RFCv2 02/10] drm: Add primary plane helpers Matt Roper
2014-03-08 0:03 ` [RFCv2 03/10] drm/exynos: Restrict plane loops to only operate on overlay planes Matt Roper
2014-03-08 0:03 ` [RFCv2 04/10] drm/i915: " Matt Roper
2014-03-08 0:03 ` [RFCv2 05/10] drm: Add plane type property Matt Roper
2014-03-11 23:45 ` Bob Paauwe
2014-03-12 16:43 ` Matt Roper [this message]
2014-03-08 0:03 ` [RFCv2 06/10] drm: Specify primary plane at CRTC initialization Matt Roper
2014-03-09 21:12 ` Rob Clark
2014-03-10 14:54 ` Matt Roper
2014-03-10 15:25 ` Rob Clark
2014-03-08 0:03 ` [RFCv2 07/10] drm: Replace crtc fb with primary plane fb Matt Roper
2014-03-08 0:03 ` [RFCv2 08/10] drm: Allow userspace to ask for full plane list (universal planes) Matt Roper
2014-03-08 0:03 ` [RFCv2 09/10] drm/i915: Rename similar plane functions to avoid confusion Matt Roper
2014-03-08 0:03 ` [RFCv2 10/10] drm/i915: Intel-specific primary plane handling Matt Roper
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140312164311.GG6117@intel.com \
--to=matthew.d.roper@intel.com \
--cc=bob.j.paauwe@intel.com \
--cc=dri-devel@lists.freedesktop.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.