From: Mark Brown <broonie@kernel.org>
To: Lee Jones <lee.jones@linaro.org>
Cc: Chanwoo Choi <cw00.choi@samsung.com>,
Robert Baldyga <r.baldyga@samsung.com>,
sameo@linux.intel.com, myungjoo.ham@samsung.com,
dmitry.torokhov@gmail.com, cooloney@gmail.com, rpurdie@rpsys.net,
dbaryshkov@gmail.com, dwmw2@infradead.org, lgirdwood@gmail.com,
a.zummo@towertech.it, paul.gortmaker@windriver.com,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
linux-leds@vger.kernel.org, rtc-linux@googlegroups.com,
m.szyprowski@samsung.com, k.kozlowski@samsung.com
Subject: Re: [PATCH v3 4/4] mfd: max8997: move regmap handling to function drivers
Date: Thu, 13 Mar 2014 14:09:01 +0000 [thread overview]
Message-ID: <20140313140901.GW366@sirena.org.uk> (raw)
In-Reply-To: <20140313125504.GA10356@lee--X1>
[-- Attachment #1: Type: text/plain, Size: 743 bytes --]
On Thu, Mar 13, 2014 at 12:55:04PM +0000, Lee Jones wrote:
> > Is it necessary? If previous mfd driver has various i2c line, previous mfd driver
> > initialize regmap/i2c setting on mfd driver.
> > I'm not sure that regmap/i2c setting code move from mfd driver to each driver.
> >
> > Dear Lee Jones,
> > I need your opinion about moving regmap/i2c code from mfd driver to each driver.
> I'd rather take advice from Mark on this one.
I don't really case that much; I'm having a hard time seeing it as
particularly useful to do the refactoring but if it makes people
happy... Keeping things in the core would help promote reusability I
guess but I'm not sure that's likely to actually happen with this sort
of driver/device.
[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]
next prev parent reply other threads:[~2014-03-13 14:09 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 9:38 [PATCH v3 0/4] mfd: max8997: add regmap support Robert Baldyga
2014-03-13 9:38 ` [PATCH v3 1/4] mfd: max8997: use regmap to access registers Robert Baldyga
2014-03-18 9:51 ` Chanwoo Choi
2014-03-18 22:33 ` Bryan Wu
2014-03-13 9:38 ` [PATCH v3 2/4] mfd: max8997: handle IRQs using regmap Robert Baldyga
2014-03-13 9:44 ` Krzysztof Kozlowski
2014-03-13 10:45 ` Chanwoo Choi
2014-03-14 8:33 ` Robert Baldyga
2014-03-18 9:52 ` Chanwoo Choi
2014-03-13 9:38 ` [PATCH v3 3/4] mfd: max8997: change irq names to upper case Robert Baldyga
2014-03-13 9:44 ` Krzysztof Kozlowski
2014-03-13 10:18 ` Chanwoo Choi
2014-03-13 9:38 ` [PATCH v3 4/4] mfd: max8997: move regmap handling to function drivers Robert Baldyga
2014-03-13 9:50 ` Krzysztof Kozlowski
2014-03-13 11:09 ` Chanwoo Choi
2014-03-13 12:55 ` Lee Jones
2014-03-13 14:09 ` Mark Brown [this message]
2014-03-14 11:21 ` Robert Baldyga
2014-03-18 8:50 ` Lee Jones
2014-03-13 10:25 ` [PATCH v3 0/4] mfd: max8997: add regmap support Chanwoo Choi
2014-03-13 10:52 ` Robert Baldyga
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140313140901.GW366@sirena.org.uk \
--to=broonie@kernel.org \
--cc=a.zummo@towertech.it \
--cc=cooloney@gmail.com \
--cc=cw00.choi@samsung.com \
--cc=dbaryshkov@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=k.kozlowski@samsung.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=myungjoo.ham@samsung.com \
--cc=paul.gortmaker@windriver.com \
--cc=r.baldyga@samsung.com \
--cc=rpurdie@rpsys.net \
--cc=rtc-linux@googlegroups.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.