From: Robert Baldyga <r.baldyga@samsung.com>
To: Chanwoo Choi <cw00.choi@samsung.com>
Cc: sameo@linux.intel.com, lee.jones@linaro.org,
myungjoo.ham@samsung.com, dmitry.torokhov@gmail.com,
cooloney@gmail.com, rpurdie@rpsys.net, dbaryshkov@gmail.com,
dwmw2@infradead.org, lgirdwood@gmail.com, broonie@kernel.org,
a.zummo@towertech.it, paul.gortmaker@windriver.com,
linux-kernel@vger.kernel.org, linux-input@vger.kernel.org,
linux-leds@vger.kernel.org, rtc-linux@googlegroups.com,
m.szyprowski@samsung.com, k.kozlowski@samsung.com
Subject: Re: [PATCH v3 0/4] mfd: max8997: add regmap support
Date: Thu, 13 Mar 2014 11:52:57 +0100 [thread overview]
Message-ID: <53218E09.1040200@samsung.com> (raw)
In-Reply-To: <53218786.7010208@samsung.com>
Hi,
On 03/13/2014 11:25 AM, Chanwoo Choi wrote:
> Hi Robert,
>
> On 03/13/2014 06:38 PM, Robert Baldyga wrote:
>> Hi,
>>
>> This patchset modifies max8997 driver and associated function drivers to use
>> register maps instead of operating directly on i2c bus. This change allowed
>> to simplify irq handling, and to move some initializations to individual
>> function drivers. Hence now when some functions are not enabled, their i2c
>> clients, regmaps and irqs are not registered.
>>
>> Best regards
>> Robert Baldyga
>> Samsung R&D Institute Poland
>>
>> Changelog:
>>
>> v3:
>> - fix error handling
>> - fix deinitializations order
>> - move muic irq enum values renaming to separate patch
>>
>> v2: https://lkml.org/lkml/2014/3/12/237
>> - rebase patches on Lee Jones' MFD tree
>> - add missing selects in Kconfig
>> - add missing deinitializations
>> - add interrupt disabling when suspend
>> - few minor changes and typo fixes
>>
>> v1: https://lkml.org/lkml/2014/3/11/291
>>
>> Robert Baldyga (4):
>> mfd: max8997: use regmap to access registers
>> mfd: max8997: handle IRQs using regmap
>> mfd: max8997: change irq names to upper case
>> mfd: max8997: move regmap handling to function drivers
>>
>> drivers/extcon/extcon-max8997.c | 181 +++++++++++++---
>> drivers/input/misc/max8997_haptic.c | 121 +++++++++--
>> drivers/leds/leds-max8997.c | 13 +-
>> drivers/mfd/Kconfig | 3 +-
>> drivers/mfd/Makefile | 2 +-
>> drivers/mfd/max8997-irq.c | 387 -----------------------------------
>> drivers/mfd/max8997.c | 236 +++++++--------------
>> drivers/power/max8997_charger.c | 33 +--
>> drivers/regulator/max8997.c | 87 ++++----
>> drivers/rtc/rtc-max8997.c | 102 ++++++---
>> include/linux/mfd/max8997-private.h | 88 ++++++--
>> 11 files changed, 532 insertions(+), 721 deletions(-)
>> delete mode 100644 drivers/mfd/max8997-irq.c
>>
>
> This patch fix many parts of previous max8997.
> When I testd kernel build, it is ok.
>
> But, I have a question.
> The max8997 is used on trats board based on exynos4210.
> Did you test this patchset?
Yes, I have tested it on this board. Some function drivers requiring
platform data would not work yet, but it's not related to this patchset.
They didn't work before.
I'm actually working on patches for extcon-max8997.
Best regards
Robert Baldyga
prev parent reply other threads:[~2014-03-13 10:52 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 9:38 [PATCH v3 0/4] mfd: max8997: add regmap support Robert Baldyga
2014-03-13 9:38 ` [PATCH v3 1/4] mfd: max8997: use regmap to access registers Robert Baldyga
2014-03-18 9:51 ` Chanwoo Choi
2014-03-18 22:33 ` Bryan Wu
2014-03-13 9:38 ` [PATCH v3 2/4] mfd: max8997: handle IRQs using regmap Robert Baldyga
2014-03-13 9:44 ` Krzysztof Kozlowski
2014-03-13 10:45 ` Chanwoo Choi
2014-03-14 8:33 ` Robert Baldyga
2014-03-18 9:52 ` Chanwoo Choi
2014-03-13 9:38 ` [PATCH v3 3/4] mfd: max8997: change irq names to upper case Robert Baldyga
2014-03-13 9:44 ` Krzysztof Kozlowski
2014-03-13 10:18 ` Chanwoo Choi
2014-03-13 9:38 ` [PATCH v3 4/4] mfd: max8997: move regmap handling to function drivers Robert Baldyga
2014-03-13 9:50 ` Krzysztof Kozlowski
2014-03-13 11:09 ` Chanwoo Choi
2014-03-13 12:55 ` Lee Jones
2014-03-13 14:09 ` Mark Brown
2014-03-14 11:21 ` Robert Baldyga
2014-03-18 8:50 ` Lee Jones
2014-03-13 10:25 ` [PATCH v3 0/4] mfd: max8997: add regmap support Chanwoo Choi
2014-03-13 10:52 ` Robert Baldyga [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=53218E09.1040200@samsung.com \
--to=r.baldyga@samsung.com \
--cc=a.zummo@towertech.it \
--cc=broonie@kernel.org \
--cc=cooloney@gmail.com \
--cc=cw00.choi@samsung.com \
--cc=dbaryshkov@gmail.com \
--cc=dmitry.torokhov@gmail.com \
--cc=dwmw2@infradead.org \
--cc=k.kozlowski@samsung.com \
--cc=lee.jones@linaro.org \
--cc=lgirdwood@gmail.com \
--cc=linux-input@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=m.szyprowski@samsung.com \
--cc=myungjoo.ham@samsung.com \
--cc=paul.gortmaker@windriver.com \
--cc=rpurdie@rpsys.net \
--cc=rtc-linux@googlegroups.com \
--cc=sameo@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.