From: Olaf Hering <olaf@aepfle.de>
To: Ian Jackson <Ian.Jackson@eu.citrix.com>
Cc: Ian.Campbell@citrix.com, xen-devel@lists.xen.org
Subject: Re: [PATCH] tools/libxc: fix errno handling for HVM in xc_domain_save
Date: Thu, 13 Mar 2014 18:57:35 +0100 [thread overview]
Message-ID: <20140313175735.GA16807@aepfle.de> (raw)
In-Reply-To: <21281.61583.727192.311217@mariner.uk.xensource.com>
On Thu, Mar 13, Ian Jackson wrote:
> Olaf Hering writes ("[PATCH] tools/libxc: fix errno handling for HVM in xc_domain_save"):
> > The previous patch ("tools/libxc: pass errno to callers of
> > xc_domain_save") did not jump to the proper label if the domU is HVM.
> >
> > Also make it clearer what "out" and "out_rc" are supposed to mean:
> > label "out" is for failure case, it expects errno to be set.
> > label "out_rc" is for success case, it preserves the initial errno for
> > the caller.
>
> I agree with Ian that this is very confusing. How about this instead ?
That would fix the current bug, yes.
Olaf
next prev parent reply other threads:[~2014-03-13 17:57 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-13 17:34 [PATCH] tools/libxc: fix errno handling for HVM in xc_domain_save Olaf Hering
2014-03-13 17:44 ` Ian Campbell
2014-03-13 17:46 ` Andrew Cooper
2014-03-13 17:53 ` Ian Jackson
2014-03-13 17:57 ` Olaf Hering [this message]
2014-03-13 18:01 ` Ian Jackson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20140313175735.GA16807@aepfle.de \
--to=olaf@aepfle.de \
--cc=Ian.Campbell@citrix.com \
--cc=Ian.Jackson@eu.citrix.com \
--cc=xen-devel@lists.xen.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.