From: Arnd Bergmann <arnd@arndb.de>
To: Tanmay Inamdar <tinamdar@apm.com>
Cc: Bjorn Helgaas <bhelgaas@google.com>,
Jason Gunthorpe <jgunthorpe@obsidianresearch.com>,
Grant Likely <grant.likely@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
Catalin Marinas <catalin.marinas@arm.com>,
Rob Landley <rob@landley.net>, Liviu Dudau <liviu.dudau@arm.com>,
linux-pci@vger.kernel.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org, linux-doc@vger.kernel.org,
linux-kernel@vger.kernel.org, patches@apm.com, jcm@redhat.com
Subject: Re: [PATCH v4 2/4] arm64: dts: APM X-Gene PCIe device tree nodes
Date: Fri, 14 Mar 2014 13:07:22 +0100 [thread overview]
Message-ID: <201403141307.23286.arnd@arndb.de> (raw)
In-Reply-To: <1394085963-27553-3-git-send-email-tinamdar@apm.com>
On Thursday 06 March 2014, Tanmay Inamdar wrote:
> + pcie0: pcie@1f2b0000 {
> + status = "disabled";
> + device_type = "pci";
> + compatible = "apm,xgene-storm-pcie", "apm,xgene-pcie";
> + #interrupt-cells = <1>;
> + #size-cells = <2>;
> + #address-cells = <3>;
> + reg = < 0x00 0x1f2b0000 0x0 0x00010000 /* Controller registers */
> + 0xe0 0xd0000000 0x0 0x00200000>; /* PCI config space */
> + reg-names = "csr", "cfg";
> + ranges = <0x01000000 0x00 0x00000000 0xe0 0x00000000 0x00 0x00010000 /* io */
> + 0x02000000 0x00 0x10000000 0xe0 0x10000000 0x00 0x80000000>; /* mem */
> + dma-ranges = <0x42000000 0x40 0x00000000 0x40 0x00000000 0x40 0x00000000>;
> + interrupt-map-mask = <0x0 0x0 0x0 0x7>;
> + interrupt-map = <0x0 0x0 0x0 0x1 &gic 0x0 0xc2 0x1
> + 0x0 0x0 0x0 0x2 &gic 0x0 0xc3 0x1
> + 0x0 0x0 0x0 0x3 &gic 0x0 0xc4 0x1
> + 0x0 0x0 0x0 0x4 &gic 0x0 0xc5 0x1>;
> + clocks = <&pcie0clk 0>;
> + };
Is 0x40.0x00000000 the start of your RAM? I had expected RAM to start at 0.0,
and in that case the dma-ranges property would be wrong.
Arnd
WARNING: multiple messages have this Message-ID (diff)
From: arnd@arndb.de (Arnd Bergmann)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH v4 2/4] arm64: dts: APM X-Gene PCIe device tree nodes
Date: Fri, 14 Mar 2014 13:07:22 +0100 [thread overview]
Message-ID: <201403141307.23286.arnd@arndb.de> (raw)
In-Reply-To: <1394085963-27553-3-git-send-email-tinamdar@apm.com>
On Thursday 06 March 2014, Tanmay Inamdar wrote:
> + pcie0: pcie at 1f2b0000 {
> + status = "disabled";
> + device_type = "pci";
> + compatible = "apm,xgene-storm-pcie", "apm,xgene-pcie";
> + #interrupt-cells = <1>;
> + #size-cells = <2>;
> + #address-cells = <3>;
> + reg = < 0x00 0x1f2b0000 0x0 0x00010000 /* Controller registers */
> + 0xe0 0xd0000000 0x0 0x00200000>; /* PCI config space */
> + reg-names = "csr", "cfg";
> + ranges = <0x01000000 0x00 0x00000000 0xe0 0x00000000 0x00 0x00010000 /* io */
> + 0x02000000 0x00 0x10000000 0xe0 0x10000000 0x00 0x80000000>; /* mem */
> + dma-ranges = <0x42000000 0x40 0x00000000 0x40 0x00000000 0x40 0x00000000>;
> + interrupt-map-mask = <0x0 0x0 0x0 0x7>;
> + interrupt-map = <0x0 0x0 0x0 0x1 &gic 0x0 0xc2 0x1
> + 0x0 0x0 0x0 0x2 &gic 0x0 0xc3 0x1
> + 0x0 0x0 0x0 0x3 &gic 0x0 0xc4 0x1
> + 0x0 0x0 0x0 0x4 &gic 0x0 0xc5 0x1>;
> + clocks = <&pcie0clk 0>;
> + };
Is 0x40.0x00000000 the start of your RAM? I had expected RAM to start at 0.0,
and in that case the dma-ranges property would be wrong.
Arnd
next prev parent reply other threads:[~2014-03-14 12:07 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-03-06 6:05 [PATCH v4 0/4] APM X-Gene PCIe controller Tanmay Inamdar
2014-03-06 6:05 ` Tanmay Inamdar
2014-03-06 6:06 ` [PATCH v4 1/4] pci: APM X-Gene PCIe controller driver Tanmay Inamdar
2014-03-06 6:06 ` Tanmay Inamdar
2014-03-07 8:37 ` Jingoo Han
2014-03-07 8:37 ` Jingoo Han
2014-03-07 18:32 ` Tanmay Inamdar
2014-03-07 18:32 ` Tanmay Inamdar
2014-03-14 12:18 ` Arnd Bergmann
2014-03-14 12:18 ` Arnd Bergmann
2014-03-14 12:18 ` Arnd Bergmann
2014-03-15 3:29 ` Tanmay Inamdar
2014-03-15 3:29 ` Tanmay Inamdar
2014-03-06 6:06 ` [PATCH v4 2/4] arm64: dts: APM X-Gene PCIe device tree nodes Tanmay Inamdar
2014-03-06 6:06 ` Tanmay Inamdar
2014-03-12 8:31 ` Jingoo Han
2014-03-12 8:31 ` Jingoo Han
2014-03-12 16:44 ` Tanmay Inamdar
2014-03-12 16:44 ` Tanmay Inamdar
2014-03-14 12:07 ` Arnd Bergmann [this message]
2014-03-14 12:07 ` Arnd Bergmann
2014-03-15 3:27 ` Tanmay Inamdar
2014-03-15 3:27 ` Tanmay Inamdar
2014-03-15 8:58 ` Arnd Bergmann
2014-03-15 8:58 ` Arnd Bergmann
2014-03-06 6:06 ` [PATCH v4 3/4] dt-bindings: pci: xgene pcie device tree bindings Tanmay Inamdar
2014-03-06 6:06 ` Tanmay Inamdar
2014-03-06 6:06 ` [PATCH v4 4/4] MAINTAINERS: entry for APM X-Gene PCIe host driver Tanmay Inamdar
2014-03-06 6:06 ` Tanmay Inamdar
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=201403141307.23286.arnd@arndb.de \
--to=arnd@arndb.de \
--cc=bhelgaas@google.com \
--cc=catalin.marinas@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=grant.likely@linaro.org \
--cc=jcm@redhat.com \
--cc=jgunthorpe@obsidianresearch.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pci@vger.kernel.org \
--cc=liviu.dudau@arm.com \
--cc=patches@apm.com \
--cc=rob@landley.net \
--cc=robh+dt@kernel.org \
--cc=tinamdar@apm.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.